PokeAPI / PokeAPI/pokeapi

Data Model doesnt consider the subcategories of Pokemon

Open
#1,034 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5.4k
Forks
1.2k
Avg merge
2d 5h
Merged PRs (30d)
21

Description

As briefly mentioned by me in #1026 , the data model doesnt consider the different subcategories of Pokemon. While up untill Sun and Moon, the disction "is_legendary" was possible, it always disregarded the mythical moniker, and in sun and moon the moniker sub_legendary was introduced in code, into which ultra beasts also were put into.

And Scarlet and Violet/Gen 9 now further split this into Ultra Beasts, Sub Legendary, Paradox Pokemon, Restricted Legendary and Mythical.

Therefore the datapoints of is_legendary is much more detailed than is previously assumed. One could also argue lorewise while Necrozma is a Restricted Legendary, its also is a Ultra Beast and much more. Koraidon and Miraidon are called paradox pokemon, but are handled as restricted legendaries in code.

So, instead of strict boolean is_legendary and is_starter, a list of categories a pokemon is in would be more appropiate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points; begin by locating the current data-model definitions for is_legendary and is_starter. Done means the representation can express the listed Pokémon categories, but the issue does not specify an implementation target or validation test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.