Point72 / Point72/csp

Build very sensitive to compiler differences, consider having a "strict" option

Open
#361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

part: build type: enhancement
Dominant language
Python
Stars
441
Forks
90
Avg merge
1d 12m
Merged PRs (30d)
5

Description

Compilers might have different considerations for what is, and what is not, a warning. Example: https://github.com/Point72/csp/pull/359

For perspective for example, we had a "STRICT" flag: https://github.com/finos/perspective/blob/08448ccc7ad8b9ca2c98659b1c8187e7ab40aa68/cpp/perspective/CMakeLists.txt#L73
We should consider doing something similar. We can enable it in CI/locally where we have full control over the env, but allow it to be unset for end users that might be building from source against other compilers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the compiler-warning behavior described in pull request 359 and the referenced cpp/perspective/CMakeLists.txt example. Check how strict warnings could be enabled in CI and local builds while remaining unset for end users building from source. Done means the option behavior is defined and works across those build contexts.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.