Removing Data Model 2 functions from ipmag.py
@apivarunas is already working on this.
Since Oct 28, 2025.
- Dominant language
- Jupyter Notebook
- Stars
- 81
- Forks
- 45
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 8
Description
I'm currently doing a careful look through of all functions in pmagpy.ipmag that are supporting MagIC Data Model 2.
There are seven functions which fall into this category:
ani_depthplot2
upload_magic2
upload_magic3 (tangentially.... the correct function is now upload_magic which this function points to)
chi_magic2
hysteresis_magic2
aarm_magic_dm2
atrm_magic_dm2
These seven functions represent about 10% of the total code within ipmag, and all have superseding functions that work with Data Model 3.0. I haven't pulled the trigger on any changes, since there are a variety of issues.
Some functions have to be plucked out of other files as well, for instance, ipmag.ani_depthplot2 shows up in both ani_depthplot2.py and ani_depthplot.py...
At least 1 function seems to be still of use, aarm_magic_dm2 as discussed in #720.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.