PmagPy / PmagPy/PmagPy

Expand common_mean_bayes() to include test for differing precision

Open
#656 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

New Feature
Dominant language
Jupyter Notebook
Stars
81
Forks
45
Avg merge
1d 14h
Merged PRs (30d)
8

Description

I just committed a common_mean_bayes() function to ipmag.py that implements the Heslop and Roberts (2018) common mean/reversal test.

I have utilized their code to implement the version of the test that us for populations with common precision (Appendix A; jgrb52994-sup-0003-Data S2.unk).

We should also implement the version with differing precisions (could be a flag in the same function), but this involves import of a special library quadpy which we may not want to make a dependency of ipmag.py. The version of the test is documented in Appendix B and SI materials: jgrb52994-sup-0004-Data S3.unk.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ipmag.py at common_mean_bayes() and compare its existing common-precision implementation with the differing-precision version described in Appendix B and the linked SI materials. Review how quadpy would be imported or isolated before deciding how the option fits the function. Done means the differing-precision test is supported without making an unsuitable dependency choice.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.