Platonic-Systems / Platonic-Systems/process-compose-flake

use writeShellApplication for probe's exec.command

Open
#90 20 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Nix
Stars
205
Forks
30
PR merge metrics
No merged PRs in 30d

Description

It's confusing since code in probes exec.command behaves differently than in process command, since $variable needs to be escaped ($$) in order to be resolved at runtime, instead of at config parsing time

for example, the following in probe's exec.command

a=something
echo "a: $a"

would print a: unless env var a was set when PC was started

in order for it to behave like in process command, it would need to be:

a=something
echo "a: $$a"

see:
https://github.com/F1bonacc1/process-compose/issues/63
https://github.com/F1bonacc1/process-compose/issues/63#issuecomment-1615161806

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the probe exec.command implementation and comparing it with the process command path. Read the writeShellApplication behavior and the linked process-compose issue for the intended expansion semantics. Done means probe commands resolve variables at runtime like process commands, without requiring doubled dollar signs.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.