PipedreamHQ / PipedreamHQ/pipedream

[BUG] Invoking a Deactivated Source HTTP Webhook Returns 200 Response - Used to return 400

Open
#6,157 2 comments 0 reactions 0 assignees View on GitHub
bug tracked internally triaged
Dominant language
JavaScript
Stars
11.7k
Forks
5.8k
Avg merge
3d 10h
Merged PRs (30d)
102

Description

**Describe the bug**
The the behavior of Deactivating a Source HTTP Webhook changed. It was returning a 400 bad request for years when deactivated, but now returns a 200 with a custom response leading to the documentation.

**To Reproduce**
Steps to reproduce the behavior:
1. Create a simple Webhook Source
2. Go to the created pipedream uri for the webhook --> a 200 OK response is returned
3. Deactivate the Webhook manually or through the REST API
![image](https://user-images.githubusercontent.com/6446645/234331689-d536b443-c72a-44da-b6fd-5f13f6d71621.png)
https://pipedream.com/docs/api/rest/#update-a-source
![image](https://user-images.githubusercontent.com/6446645/234331825-2d22c195-0a9e-4a58-bd5c-5350097c7c60.png)
4. Go to the created pipedream uri for the webook --> a 200 OK response is returned

**Expected behavior**
A 400 Bad Request response is returned.

**Screenshots**
The returned response:
![image](https://user-images.githubusercontent.com/6446645/234332094-8c456838-9c8b-4a59-9c92-b3b69a5f25d3.png)

**Desktop (please complete the following information):**
- OS: Windows
- Browser: Happens on all browsers/HTTP clients
- Version: N/A

**Smartphone (please complete the following information):**
N/A

**Additional context**
A deactivated Webhook used to return a 400 Bad Request for at least 2.5 years, this change only happened recently.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.