PipedreamHQ / PipedreamHQ/pipedream
[BUG] Submit form not taking URL characters as valid
- Dominant language
- JavaScript
- Stars
- 11.7k
- Forks
- 5.8k
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 102
Description
**Describe the bug**
The submit form does not recognize URLs entered in the URL field that are valid characters for a URL, such as the comma ",", or semi-colon ';"
**To Reproduce**
Steps to reproduce the behavior:
1. Go to [Submit an App](https://pipedream.com/submit-an-app) form
2. Fill out the app description fields using dummy data
3. Set the test request table's URL field to a URL containing one of the offending values such as ",". For example>
` https://www.google.com.mx/maps/@37.773972,-122.431297,15z`
5. See error, on the test request table you see "REQUIRED"/"URL should look like a URL"
**Expected behavior**
on the test request table you should see "VALID ✓"
**Screenshots**

**Desktop (please complete the following information):**
OS:Microsoft Windows 10 Home Single Language
OS Version: 10.0.19044 N/A Build 19044
Browser Chrome
Version: 108.0.5359.125 (Build oficial) (64 bits) (cohort: Stable)
**Additional context**
This was found while submitting the Pirate Wheater app, whose test request URL has the format
`https://api.pirateweather.net/forecast/{{api_key}}/37.773972,-122.431297`
According to this [StackOverflow ](https://stackoverflow.com/questions/1547899/which-characters-make-a-url-invalid)article the following characters are valid within a URL:
In general URIs as defined by [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986/) (see [Section 2: Characters](https://www.rfc-editor.org/rfc/rfc3986#section-2)) may contain any of the following 84 characters:
>
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~:/?#[]@!$&'()*+,;=
Contributor guide
Assessment
This issue has not been assessed yet.