PipedreamHQ / PipedreamHQ/pipedream

[BUG] File attachments in workflows can have the same name

Open
#1,245 0 comments 0 reactions 0 assignees View on GitHub
bug tracked internally triaged
Dominant language
JavaScript
Stars
11.7k
Forks
5.8k
Avg merge
3d 10h
Merged PRs (30d)
102

Description

**Describe the bug**
File attachments to the workflow don't have a unique namespace enforced; you can attach two files with the same name, and it's ambiguous which one would be loaded with $attachments[fileName]

**To Reproduce**
1. Make a workflow
2. Attach a file in the workflow
3. Attach the same file again.

**Expected behavior**
An error saying there's already a file with that name.

**Screenshots**
![image](https://user-images.githubusercontent.com/26447704/118870915-e49f0300-b89b-11eb-964c-3d7637e5b407.png)

**Desktop (please complete the following information):**
Chrome browser

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.