Pioreactor / Pioreactor/pioreactor
better handling of config type errors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 149
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
Ex: I had a comment beside the KF parameters,
[growth_rate_kalman]
acc_std=0.2
obs_std=3.0 # ↑ smooths growth rate
od_std=0.001
rate_std=2.5 # ↑ more responsive growth rate
but this isn't allowed in ini files, and when I call .getfloat, an error is thrown. However, the user just sees the job exit, with no error / warning. They need to run it from the command line to see the ValueError is thrown.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where configuration values are parsed with .getfloat and how the job exits when that raises ValueError. Reproduce the malformed inline-comment value from the issue, then verify that users receive an error or warning instead of a silent job exit and add coverage for that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100