We ought to consolidate code in Wrangler for computing a URL given an absoluteURL and a RID
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- TypeScript
- Stars
- 51
- Forks
- 10
- Avg merge
- 4m
- Merged PRs (30d)
- 1
Description
To install a ruleset, you have two options:
- Provide the absolute (full) URL of where the source code is located, or
- Provide an absolute URL of an already-installed ruleset (usually the one that is evaluating) and the RID of another ruleset whose source code is located in the same folder (see RFC-3986, section 4.2)
As Wrangler is written now, there are two places where we compute an absolute URL from a given URL and a RID. These are:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open packages/pico-engine/krl/io.picolabs.wrangler.krl and compare install_ruleset_relatively with initialize_child_after_creation. Start with the official computation in install_ruleset_relatively, then update the child-initialization path so it raises the same event with the required attributes. Done means both paths use the consolidated URL computation.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100