PhilippC / PhilippC/keepass2android

[FEAT] improve the dialog when deleting a password

Open
#3,262 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
6.2k
Forks
478
Avg merge
1h 4m
Merged PRs (30d)
2

Description

When deleting a password, a dialog is shown that is very confusing. A dialog is shown that asks the question from AskDeletePermanentlyEntry.

Current dialog:
"Do you want to delete this entry permanently? Press No to recycle."

This is technically correct, but very confusing. People are used to not read such dialoges. They are trained since yeras: After I click aywhere, and a dialog pops up, I need just click on "yes" to confirm my choice. And "no" if I want to abort the delete command.

suggestion how to improve:
"Do you like to delete this entry?"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the AskDeletePermanentlyEntry dialog and trace where it is shown when deleting a password. Update the wording and action labels to distinguish recycling from permanent deletion, then verify that each choice still performs the intended action.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, csharp
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.