PhilippC / PhilippC/keepass2android
[BUG] Samsung shared prefs migration breaks biometric auth
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.2k
- Forks
- 478
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 2
Description
Checks
- I have read the FAQ section, searched the open issues, and still think this is a new bug.
Describe the bug you encountered:
This happened when I purchased a Samsung Tab S9 FE and used my existing Samsung phone to migrate current apps. Samsung must execute an app backup and restore for each because the Keepass2Android biometric setting was not set to the default on the new tablet, but to the same setting as the phone (which had prompted and enrolled for biometrics). The app on the tablet would never prompt until I changed from full to quickunlock in order to force the prompt. The initial state, therefore, was broken biometrics on the tablet until I did this. This could happen for others since Samsung has such a large market share. For now, this workaround takes care of it and could be an FAQ, but should be addressed at some point. Basically, the app should not assume users are enrolled even if the setting is enabled.
Describe what you expected to happen:
App should check biometric enrollment state even if setting implies user has enrolled.
What version of Keepass2Android are you using?
latest from Play Store as of 12/29/2024
Which version of Android are you on?
latest for Samsung - Android 14, One UI version 6.1.1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Samsung backup-and-restore scenario described on Android 14 with One UI 6.1.1, using a setting that indicates biometrics are enabled before enrollment on the restored device. Trace the biometric setting and enrollment check, then verify that the app prompts correctly without requiring the full-to-quickunlock workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, csharp
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100