PhilippC / PhilippC/keepass2android
Work offline setting gets lost with child databases
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.2k
- Forks
- 478
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 2
Description
FileSelectActivity.OnResume() calls App.Kp2a.OfflineMode = false; and never resets this. This could explain the behavior described by a user (mail from 2021-10-07):
I have several databases that open together via AutoOpen entries, and this has been working well for several years.
These files are stored on a sftp server, and this also has been working well for several years.this has happened for a while now, but has not always been a problem. I have recent cache copies and I open those easily. there is a checkbox, something like "local files only" on the master password prompt screen, and I have that checked so program doesn't wait and wait looking for the remote files.
I do anything that causes a database save, but keepass forgets that I told it not to update remote files, and starts looking for the sftp server. I curse a bit, click "Work on internal cache only" but keepass will forget this later and try again to find sftp server. I can interrupt this cycle only by toggling Airplane Mode, then keepass will immediately give up on the sftp server, and I will start this cycle again.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at FileSelectActivity.OnResume(), focusing on the App.Kp2a.OfflineMode assignment and the flow that opens child databases. Reproduce the reported AutoOpen and cached-database scenario with Work on internal cache only enabled; done means that setting remains effective after a save or child-database operation without retrying the SFTP connection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, csharp
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100