PerlDancer / PerlDancer/Dancer2

Session written to storage before after hooks executed

Open
#1,261 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Question
Dominant language
Perl
Stars
604
Forks
288
Avg merge
1d 5h
Merged PRs (30d)
5

Description

Arising from #1256:

If you make changes to the session in an after hook, your changes will not be written to storage, because writing sessions to storage also takes place in an (earlier) after hook.

This is a change from Dancer1. Is this intentional?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #1256 and tracing the session storage and after-hook ordering described here. Compare the behavior with Dancer1, then establish whether the ordering is intentional and document or implement the agreed behavior with regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.