Perl-Toolchain-Gang / Perl-Toolchain-Gang/Module-Metadata

package_versions_from_directory needs test for conflict checking

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Perl
Stars
8
Forks
17
PR merge metrics
No merged PRs in 30d

Description

I don't have the time to make a test for this right now, thus i am documenting here what needs to be done:

In t/metadata.t the tests for package_versions_from_directory need to be extended by way of adding another file to the dist being inspected, said file needing to be stuck in a sub dir, e.g. Nested::Simple. The file should contain code sufficient to trigger the error of "Unexpected conflict in '$package'; multiple versions found.\n". Said throwing should be considered a success.

This needs to be tested because in its current state the path splitting a little further up would keep this check from functioning properly. I am providing a fix for this in a pull request to come, but a test will need to be made as per above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in t/metadata.t with the existing package_versions_from_directory tests. Add a file in a nested subdirectory, such as Nested::Simple, with content that creates the stated package-version conflict; done means the test observes the expected Unexpected conflict in '$package'; multiple versions found. error.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.