PerfectlySoft / PerfectlySoft/Perfect-Session
Session cookie cannot be configured with Session storage duration.
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 4
- Forks
- 14
- Avg merge
- 17m
- Merged PRs (30d)
- 1
Description
SessionConfig does not allow configuration of the session cookie to expire when the browser tab is closed. Instead, a Max-Age needs to be specified in SessionConfig.idle which is then converted into an Expiry date.
It might be desirable to expose the HTTPCookie.Expiration type instead of just allowing Max-Age cookies to allow more flexible cookie configurations. Session cookies that get removed on tab close cannot be emulated with the existing mechanism (HTTPCookie.Expiration.session would be required).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing SessionConfig, especially SessionConfig.idle, and the HTTPCookie.Expiration type mentioned in the issue. Determine how session-cookie expiration is represented, then define done as supporting browser-tab session expiration alongside the existing Max-Age-based behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100