PerfectlySoft / PerfectlySoft/Perfect-Session

CSRFFilter always accepts

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
4
Forks
14
Avg merge
17m
Merged PRs (30d)
1

Description

CSRFFilter.swift line 19.

if !AuthFilter.shouldWeAccept(request.path) {
	return true
}

when running session demo, csrf filter doesn't work.
Is this ! unnecessary ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at CSRFFilter.swift line 19 and reproduce the failure with the session demo, then trace how AuthFilter.shouldWeAccept(request.path) is intended to gate CSRF handling. Done means the session demo shows the CSRF filter rejecting the invalid request and the behavior is verified against the reported condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.