PerfectlySoft / PerfectlySoft/Perfect-Redis

Refactor internally to use sendCommandAsRESP throughout

Open
#10 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
28
Forks
16
Avg merge
23m
Merged PRs (30d)
1

Description

from @sportlabsMike

"Perhaps in time the library can be refactored internally to use sendCommandAsRESP throughout"

"The library currently sends commands in the 'inline' format rather than using the REdis Serialization Protocol (see docs ). The 'inline' approach has a much smaller limit than RESP in terms of the size of the data that can be sent in for example a SET command.

By adding public func sendCommandAsRESP these limits can be avoided when necessary.

Perhaps in time the library can be refactored internally to use sendCommandAsRESP throughout, but I don't currently have time to do this."

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the public sendCommandAsRESP method and the internal paths that still send commands in inline format. Trace how commands are assembled and identify the scope of replacing those paths; done means internal commands consistently use RESP and retain existing behavior, including support for larger command data.

Written by the indexing model from the issue text.

Assessment

Tech stack
redis, swift
Domain
database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.