PerfectlySoft / PerfectlySoft/Perfect-Notifications
Parameter production is unused
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 117
- Forks
- 29
- Avg merge
- 16m
- Merged PRs (30d)
- 1
Description
public static func addConfigurationAPNS(name: String, production: Bool, certificatePath: String) {
addConfigurationIOS(name: name) {
net in
guard File(certificatePath).exists else {
fatalError("File not found (certificatePath)")
}
guard net.useCertificateFile(cert: certificatePath)
&& net.usePrivateKeyFile(cert: certificatePath)
&& net.checkPrivateKey() else {
let code = Int32(net.errorCode())
print("Error validating private key file: (net.errorStr(forCode: code))")
return
}
}
}
The parameter is never used within the function
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with public static func addConfigurationAPNS(name:production:certificatePath:) and inspect its callers and the surrounding APNs configuration flow. Determine whether production should affect behavior or be removed from the API; done means the parameter is no longer unused and any affected callers or tests remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100