PerfectlySoft / PerfectlySoft/Perfect-MySQL
Failing tests for varchars
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 126
- Forks
- 58
- Avg merge
- 25m
- Merged PRs (30d)
- 1
Description
I came across this library and thought of contributing to it. Cloned the repo on the system and started with tests. When I ran swift test after swift build, encountered two failing tests.
/testcodes/Perfect-MySQL/Tests/MySQL/MySQLTests.swift:330: error: -[MySQLTestSuite.MySQLTests testQueryStmt2] : XCTAssertTrue failed - 1366 Incorrect string value: '\xF0\x9F\x91\xBB' for column 'varchar' at row 1 - 1366 Incorrect string value: '\xF0\x9F\x91\xBB' for column 'varchar' at row 1
/testcodes/Perfect-MySQL/Tests/MySQL/MySQLTests.swift:330: error: -[MySQLTestSuite.MySQLTests testQueryStmt2] : XCTAssertTrue failed - 1366 Incorrect string value: '\xF0\x9F\x91\xBB' for column 'varchar' at row 1 - 1366 Incorrect string value: '\xF0\x9F\x91\xBB' for column 'varchar' at row 1
Swift version:
Apple Swift version 3.0 (swiftlang-800.0.33.1 clang-800.0.31)
Target: x86_64-apple-macosx10.9
Might be helpful @kjessup
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MySQLTests.swift around line 330 and reproduce the failure using swift test after swift build. Check the testQueryStmt2 setup and the reported varchar error; done means the two failing assertions pass without the incorrect-string-value error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, swift
- Domain
- database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100