PedestrianDynamics / PedestrianDynamics/PedPy
compute_line_flow unit
Open
Nobody has claimed this yet.
- Dominant language
- Pascal
- Stars
- 35
- Forks
- 18
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Description
compute_line_flow returns a DataFrame containing a "flow" column with unit [1/s]. Based on the equation provided in the user reference, this should be [1/ms]. So either, the reference is false or the method does not calculate what it is supposed to. Please check this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the compute_line_flow entry point and compare its reported flow unit with the equation in the user reference. Determine whether the implementation or the reference is incorrect, then make the unit consistent and verify the result with the relevant test coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100