PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Foulborn variants for jewels which change radius in item db
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
In #9946 I noticed that adding support for this wasn't possible. It seems that the item parsing doesn't really consider radius a mod, which means that it didn't seem to be possible to add variants which change the radius. I wasn't able to support this item in that PR because it only processes mods instead of, say, the raw item text.
How does Path of Building behave?
unique db only has regular variant
How to reproduce the issue
No response
PoB for PoE1 build code
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the item parsing path and the unique item database handling described in the issue, focusing on how mods and raw item text are processed. Done means the unique database includes Foulborn jewel variants whose radius changes are represented correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100