PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add "Blacklist" for weight calculating while searching for items

Open
#9,703 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

When PoB calculated weight of mods, some mods get drastically overweighted while in reality they are useless. As example, mod like "Cast speed %" for "cast when Stun" build somehow get weight of 81 while "increased Fire Damage" get less than 1. Another common offender is anything that give culling strike.

Describe the solution you'd like

Add ability to in addition to "find best" - manually review weighted mods, remove them from weights and "rerun calculations". It especially useful in cases like searching for "Megalomaniac" with amount of possible nodes being to high for single tradesearch. (It also and be added option to make some mods mandatory)

Describe alternatives you've considered

Making some manual list of "commonly overweighted mods" like Culling Strike, "you have culling strike against cursed enemies", "Elemental Overload" etc.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests; start by locating the existing weight-calculation and “find best” flows in Path of Building. Define how users would review and remove weighted mods, rerun calculations, and optionally mark mods as mandatory, then verify those workflows with the Megalomaniac and cited overweighted-mod cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, search
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.