PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Constant OnFrame / Launch.lua Crashes

Open
#9,690 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Expecting normal usage / not constant crashes and / or errors.

How does Path of Building behave?

I'm getting constant OnFrame errors with the latest version of PoB. This happens on all screens, including the builds index. A stack trace as an example from the Build index screen.

Error:

In 'OnFrame': Modules/ModParser.lua:6364: calling 'find' on bad self (string expected, got nil)
stack traceback:
	[C]: in function 'find'
	Modules/ModParser.lua:6364: in function 'scan'
	Modules/ModParser.lua:6498: in function 'parseMod'
	Modules/ModParser.lua:6744: in function 'parseMod'
	Classes/Item.lua:743: in function 'ParseRaw'
	Classes/ItemsTab.lua:1036: in function <Classes/ItemsTab.lua:1004>
	Modules/Build.lua:630: in function 'CallMode'
	Modules/Main.lua:354: in function <Modules/Main.lua:340>
	[C]: in function 'PCall'
	Launch.lua:111: in function <Launch.lua:108>
v2.63.0 master
Press Enter/Escape to dismiss, or F5 to restart the application.
Press CTRL + C to copy error text.

A stack trace while viewing the calc tab.

Error:

In 'OnFrame': Classes/CalcSectionControl.lua:291: attempt to index field 'calcsTab' (a trace value)
stack traceback:
	Classes/CalcSectionControl.lua:291: in function 'Draw'
	Classes/ControlHost.lua:91: in function 'DrawControls'
	Classes/CalcsTab.lua:342: in function 'Draw'
	Modules/Build.lua:1204: in function 'CallMode'
	Modules/Main.lua:370: in function <Modules/Main.lua:340>
	[C]: in function 'PCall'
	Launch.lua:111: in function <Launch.lua:108>
v2.63.0 master
Press Enter/Escape to dismiss, or F5 to restart the application.
Press CTRL + C to copy error text.

This is occurring at a fairly constant rate to the point that it's relatively unusable. (Every few seconds, I imagine as part of the UI loop).

I have attempted an uninstall / reinstall but the behaviour / bug has persisted.

How to reproduce the issue

No set behavior appears to trigger this behavior, in that I can't mouse over a particular field and trigger it constantly. It does appear to occur when interacting with the program, navigating around menus, etc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the two stack traces at Modules/ModParser.lua:6364 and Classes/CalcSectionControl.lua:291, then follow their callers through Classes/Item.lua, Classes/ItemsTab.lua, Classes/CalcsTab.lua, and Launch.lua:111. Reproduce the errors while navigating menus, the build index, and the calc tab; done means normal interaction no longer produces recurring OnFrame crashes.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.