PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Does not use +x to maximum shockwave cooldown uses
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
the new rings with +x maximum shockwave cooldown uses does not add cooldown uses on calculation page, i tried adding a few similar to custom in config, not recognized.
What is the value from the calculation in Path of Building?
1
How to reproduce the issue
Equip a ring with shockwave +x cooldown uses if in right ring slot
PoB for PoE1 build code
https://pobb.in/BodVE2lNVpmn
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by importing the linked PoE1 build code and reproducing the ring setup in the calculation page, including a custom +x cooldown-use value in config. Trace how shockwave cooldown uses are read and displayed; done means the ring's maximum uses are reflected in the calculation instead of remaining at 1.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100