PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Accept input from numeric pad keys when NumLock is off

Open
#9,675 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

When NumLock is on, PathOfBuilding treats input from the numeric key pad as expected.

When NumLock is off, PathOfBuilding currently seems to ignore input from the numeric key pad.

Many/most programs on Windows (e.g. Notepad, the dialog in Chrome that I am typing this in, and Path of Exile itself) by default treat keypad input when NumLock is off as follows:

  • Keypad "7" = Home
  • Keypad "8" = Up
  • Keypad "9" = PgUp
  • Keypad "4" = Left
  • Keypad "6" = Right
  • Keypad "1" = End
  • Keypad "2" = Down
  • Keypad "3" = PgDn
  • Keypad "0" = Ins
  • Keypad "." = Del
Describe the solution you'd like

When I am typing in PathOfBuilding and NumLock is off, I would like the keypad keys to perform navigation like in other programs on Windows.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Reproduce the issue in Path of Building on Windows with NumLock off, then trace the keyboard input handling for numeric pad events. Done means the keypad navigation keys perform the listed Home, arrow, Page, Insert, and Delete actions while NumLock is off.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.