PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Full Impale DPS for Rage Vortex's Rage Storm Does Not Calculate Correctly

Open
#9,487 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

"The Impaled debuff records 10% of the physical damage of the hit that applies it. Each time the target is hit after that, by any source, the debuff deals that amount of reflected physical damage. Impale lasts for 5 hits by default, or 8 seconds. Impale stacks freely, limited by the number of hits each debuff can last, as each hit that applies a new impale will also consume hits from existing impales." -poewiki

Assuming 100% chance to Impale, all Hits that qualify for an Impale (Attacks, in this case) should apply the Impale debuff assuming they deal Physical damage. On the attached PoB, I'm running a build that uses entirely Physical damage. I have 100% chance to Impale, which means each hit of Rage Storm from Rage Vortex is applying Impale.

On a per-hit basis, this appears to be calculated correctly:

Image

With 100% chance to Impale and no extra 'special sauce' effects such as making Impales last for extra hits, you could say that Impales effectively increase overall DPS by 50% of whatever the regular Physical DPS is. The image is correct in this regard as the Impale damage is (roughly) half of the Average Damage of the Rage Storm. It is not exactly 50% because the PoB in question has extra impale effect sprinkled in.

So, when calculating the Full DPS for Rage Storm, the program (essentially should) multiply both the Average Damage and the Impale Damage by the hit rate. In this case, [(2,113,866.3 x 14.04) + (1,074,144.7 x14.04)]. This totals to 44,759,674.44 'Full DPS', not including the initial hit of Rage Vortex. That is purely Rage Storm DPS. The actual number probably wouldn't be exactly that, but that should be the rough calculation for it.

What is the value from the calculation in Path of Building?
Image

PoB simply takes the Impale Damage from the single hit calculation and applies it to the Full DPS calculation instead of displaying an Impale DPS number that is more appropriate to the actual hit rate of the Rage Storm, specifically.

This can be very roughly be observed if I manually add a custom modifier to 'approximate' the actual DPS by modifying how many hits the impales last. Currently, the Impales for that build last 5 hits. In order to emulate a hit rate of 14.04 for the Impale DPS, I can multiply the number of hits that the Impales last for (5) by the hit rate of Rage Storm (14.04). [5 x 14.04] = 70.2. If I subtract the 5 hits that the game already has by default (because the additional hit modifier only accounts for additional hits instead of total hits) that gives me roughly 65. If I add this to the custom modifiers...

Image

Now the Full DPS for Rage Storm looks much closer to how it actually should:

Image
How to reproduce the issue
  1. Select Rage Vortex as the main skill and check the 'Include in Full DPS' box.
  2. Make sure Rage Storm is selected in the drop-down box.
  3. Acquire 100% chance to Impale.
  4. Acquire any amount of attack speed to raise the hit rate of Rage Storm above 1.0 and, preferentially, additional physical damage to make the numbers easier to visualize.
  5. Observe the Full DPS breakdown does not take hit rate into account when calculating Full Impale DPS.

This is my first ever GitHub ticket, apologies if it was filled out incorrectly.

PoB for PoE1 build code
eNrtfWtz20ay6Oflr0Cpau8X64F5Asi1zynqZSmRbEWS7SRfXANgQCIGARoA9cjW_vfTMwBIgAJIkOLm7t6TuEohwemenp5-zwNv__tpEhkPMs3CJH63hw7NPUPGXuKH8ejd3qf78wN777__a_D2RuTjj8HxLIzUL_81-Ntb_dnIRTqS-ecKnnwF-KmI87FM4mvxe5K-T_x3e1ezWKRhVvspjMufhq4rU0C-Z3hjkQovl-mVfJDRcJYn14kv3-0FIsrknjERYXyXeN9k_j5NZlOgFbp6COVj0ery-ubj7T1giUSWfRATeHQN-Ga-TPcMkXky9k8WPx0DwTL9pn6LVG_v9hx7z3BF7If5u70PSSz3YIx_e3sTiWeZ3uUiNzL4A-QCq8RInooJ_IX-RTQDdBghYnN-iLnD945WQh7P0izfAvxuKqU_h0D00KQYU0672t-k8iwIpJeHD_IkDfOTsYi9RZdmF9ymba9nUR5Oo1Cxcl37ixeokdnZ-D7JRXR6c7fgksNtQgmIKKLEwqvhknw9OccRsLTeg4NNyzrUs0EwIqvhmlNIuQlTeGgy7iBuWuuI26LXy8lURLIOiEyLIkoPLdOy7U5-fAnz8UtYgmzbROahY1m0G_ZkFkWg7nXATm7eStCoB5GDHejV_iSZuGEs_eHDaEEVpzZxrEMT5tmxUacqpVJ8DArxvhV-OMuuZZ7KbDEbh516cS1icZJkPcRDtbyRKViOfCOAO-klYGw27WNDyKswkI2W2MSr2m40khKghR5sE37ICLEsbPfobsNBnd31bbcx4u0IugUd79fyLplFPVvmC1NJCO3Wp-_1loh3WoZT-VSzCWQFwnpLp3P-LuO85mjwCnyNlsjpJvAhUXZhPW-0fTy7uFkwyMHUPnQoZ4g6jHV6u_FzFnoiuhZP4WQ2AUdzL77JRYeIcId0y-tonMdg57qgqUVQJ8nnYSq3AjxJIn87wLFIss6RQlyAus1NGF9AkDP0vBnEWs9zKKs78FDaPG_HTEpXRCjeD6r1ZezVpIKuQvwpTrXbqIU2q7pQILegviqUciPZG2bRTWkG-gQgRWcjGZc9Lrh1gE3zcGWHV1J64_fAbegPpmgOybF5SPBK57Ro2y2xmtWqcZ3VK51MC6OR1Q9gmWX4kDKQTlz8ZauQtLMP4UO0CqqLed3WPZbp6PluHMpoMTyL9GleEXcipj0gNd_r4L343-yvjSO9QDdmyxeR-v1cXE1dyap27dQT0q0MZw8iq1t-YlK0mrsFQJ2xvNM2XUsIxQHCl31Tlps0-V0lRdFmYMN0kswWzpgRbq8cRdG-YQipvc55FSnFrfRnXsNbss7xzzO84wgy476DmUMBqVG0Eegwz4X37TTxR71ZpzvZCKJJ391sOgVTpIRiCYHjrPLJkI-EtXDMMdc3_ghiXTcEtr3Kd_fuYNF4uQMHrY1JeveyBLHcFepOSnU8sdQPZT1aL_exfkavwXJMwJnoasZ14tecCuTPnVbkHPLQRvZq2pQx0zpEKuHmK8GWkm3kMOfQ4Q61KZ2bohL_3bcwiowMNNeDpvXCg-Uwyg8tbjKE9moG0ficpLkKqjMFeiPS6vldnqSTXthVFm9CPEEsZplz5ArGKNJ2Q9Nf62AV2gZRHWOuyhgyyw1dy-jq4aWlSh5hxseq5rdItkmf1hCurgc4T2X8x3Nv_I3mvTo4i32Ie8GGLPdh9oVo6-Y-nIAfyrJTkQuYCFWiPA-jXKanoCMKVuE3_DIJ-izSUMQ5gpl_8RDrh5kUqTe-AuBzEUUuGFwlLoun5fy8PdIlWPVJzdqzIaZTGfvzgundOHkc-g-KgPskibL5Dz5MfBjrSg1Y9CgqsN2nUhqisrueokSPTn0xJiKD8TwXegyY_kEIZ9a-A7L7z_1_WAzb-9S2kA1fEEbc2Ue2zRz45lAL7TNuU_UTViXLfWYii8E3bjoO3ocE0-TqN3iM9jklNoJvoNuAHhRC47cZ4_AT6J4Co9Tk-xYi1j_3jByIrhWfsVUWgC99zck4gbEqFbOxs48tIFChsa19jm14ALTxfUgtLXvfIRx6Zxa39jGQi_cJNh39hNJ9zi0OA8Q2tCGUOeY-YjY8IUCKuU8QZgpK0U8IVtgBjwnoiU2ALepJMXKELBgxNhkDnsDgTYXZgnE6NiFAE0HOPicWJvsQWgOtKut1NA0wfNMkCMZgw-ARR1z3woCboNPOPqi1SfYxcWyqe8fqr2UCHgd6Z2Au8b6eCtUh2qcOstSMIcfZL2YSfrPYPjAV0X0M1ABp1NSkUSAHYfiyjxwEzMCmTdg-YZwrkikwlnCTAgZGKNoHg-wACQg59j5DDO9TE9lqVCaFBxiGCVQDcwiYe_jLFUKbQtcwVMz2tSQBDgKCwW3FRGzBwLgFqKlFMYcHHFuKaKzGC1igBxBDGKNjAi4YGXwkFIauRYgAGmjoYMV4bkEX3ESMqOZckcXgVwjmbOAM4RZMl8M0fygCEQC5UdPrwLQraVB8sE1Hd0KBA9CPnkagmIIfAu5RGLXiMAXeKnKYpUQc7C98BJ5wTQjdL-QZRAX6MC019VqmgVEmcJA6wH0KU1YIJFdiYypxUrxhjNoM_oJE7heaBn3AeIitBAmYCKwoFAu8FuCBDA16oYRYVJkQVfkS6fNwsR6iNMVsrJCoJ1jr_t_efrq90h_-Ns7zafbD0dHj4-PhVOTjJJBPEEQfesnkaApAYDUOtAM5UCp5NIT_jkdnJ_7d9IN75tp3T-Htr5fPyA7vbn87_9H5wv18_ESdr5e_jeQ4Gmf08uKXPw7sGPHR1fj459uD5Gfuxn-4X39P_wDVzA-mX90f6dcfD25v0zPfzz5c_f40Tb59tYfi4Uyeyvsvd-73lN_LUXB94f_0fH7-e2h-_YP8-sdNdmtOf53ZH89PTryvwW-X5xcXI3whstPfnx4-fmXRxZfR9MezC-_LT7b47EYnX95_PP2M4oPYfniPhxPr6af797e_PJx6k6fkN5myp6eY_sKGtwdX8XFin53JL2Mbf37_dD2Kxp-S7w98PML89I4_PP4ehic33_EfP4_dG-9ZDokVfYs_f4x-CsI7bP7inP764Ef2FY3DX3_z2dfoZvbzxceDn06-T93R45A9nv58_GE4pMP734YfLod4dBoOPyZn5uP9l-HHX386IGic2Tdff_l-Ks9O7r9ekp9Opcs-Xnz5XdrZb-cHX-2xe_wwPmC__fj9-eDHD8Sa_Tx8905P7FE1s2-LNbWsmObymxHmclLIgbah2pwqrSw83st2aNFOaUdXM7pophWzqx1ftNM2sKsdqXWrbF9XO1Zrp6xNVzur1k4Zi7Ld26M6k96qsDcNwbOUSKrvpfcsnOSlyuVU4pgf4VP199OlfpQdXcbvxQRUBPxylqciugfXHx3dFEqkvPC9yPMkyY5-CnPxIOBnV5a_Hr8_nMYj8ODg7YpWRhIY-VgaRVsI55IEwrk0jPXa5pyJyp7tGaGnPf6cJB06XsLDrNLh7CgKAzkSYTyVabG2q3ssRvo385D9XfVYpIFGkbAaujABUaTIDFX7KphyVHHlX8ykYZqMk3g0C_vxad7cuE6S-FGkvqqdzmVcOdZ-fFokdR8AuM6kN_zvRp4YqoFRtFAh2C658hnIge9Ht7NYnqQigGhu1DJy9fNI_VwN_otIpzUJVxFLv8EOc3AMiuuZ7vN92adqhVB97MezIMiMJDaek5khn6aQWhvE_LuRRSoXKNqAkepoFegos2h1FU5AK33FSWS0juQ_Wc5UQPrnydniqzZZYM4gptcZhBqh-qB7zowMUgZVb4H88b2c3D9PVfQ8vLpSOUMgZpF6-vNMRGH-rKMG1X4Y5eUj-HGRZGQFjuz4GZLLd3t5OoOHZXqhOruTeZHs1NudqzrnYmlYp6WLnq-KnRoxZNbzlZ4yRykxGqFf5S3lQyMSrgLaUyKotiDIaCLzYjfJcEHNiYi8TNOz9IN-JmO12uBXowhjL5rBRMZlBl6NuZRAoLTIpdVMq20s8glsqS7oFYjeR4krIjxnVf0pqjqJQSyLPKyJ4nvFfqy2vxRp48uOylbqh9OCf5AYJbO44Hm55UVhGBWO71rmwof09egSPGF2pCakkEb4BLyJ7pNhOsmWOXHUNuLLOAfVBWRgIE5UlXirQdexGBpN18Bf9Ndr7KjX0DvGsnL8x2AHIqmty_bDXyD5P2KaZP83W82D5T53yIL24azkwHmSuqEPBu8WLPhGDKiVoFCdHXOMRoHye80G1diw1PEOudA6pCYT3haNV9ieLxLmMjbwn2d9Pst4JINZtL0gVhiW5Y80GN_opxfb7V5sb6F_peTN3fj2A56jWK1xzZ52OOS2Ifz7C5ouk77K4FcYVrO90c8Oud5C_6ZMh5E9qIryn8XyW3DLz69ieYVhieVNjje62WVY0UL_St0u41KVYeZqzWmrIc-hO0a73MkuXMg8nl4ifeVoP8-iWG1yCVX329ruJo6OIbe32skUf5CPreP4d1etC6A48j8GN2ATtuZ-gUTlgxWajglY7q1tBjRp12EMwf3S0Bdzs9xm-SE4racwOwPc8g5yxlCmVc966XjTyW1n0pauChl3j0oz_hUzfNSj-z9PtnSFbhj7dyL2t00OdJEP4I0CSYdcNXvqpde8X0rQMoRt5_3PY_wV9HgXicm2ngPAjQK-g9-LDnZpQ5fJ_vdn9F_pX_tMHCf-s1FtJNvtZOjn7UHiSL7YolJ2hredG9wMImsbTrrC9joZ_ZQD9YwhF3j7h5A3s-hBpmEmtzQFNfiuAb_saSc2YR5KvhhCn3GrIvAra5FNFGtG39p4RwxoG0sfHoAm52GwbUw3h14z8uV2Oxr0EvF9xjt8VKcDpK93yjY3mm5bICkxGhqlUeE0KqRrWLOSoF7sYj251dLDTTTLtuHecTrLxSsysTnPaoh68uklxG64M8fbzZM-Li3J_8S87EYtYW1rtAvYLq43f95J5Nagtpe0pWkyKnY4Lw2xGMw6IVuAr5OtFy13ZKB0ZnAtRqH3HyJR55HMxiqVydWR7y2dgsJRpGMFlq7wtNnXLkWtdRh9RO4y9lIpMunXj9RuJ35zVIbCpeoeFbY10tigIQmWoHYkmSsH2l9I_7QqQXE_wXYzMQfuXC5carATGVwiuZOn5cc7mesdCMXOA_XxJImDcFTuESi-lJsENNj8iZGHeSRrFNcX_S_j6SzXvHi39yhSL31W10OoLe-pvtHievhLRVK96WR-i8EXDfQJJOVWqmNvETjeeDZxZap8awuo2sxSBGYQZxThqJskkRRxkwN1mFkmm1vp-0As7Y5fC6II-xhnkZjp6t7a9mpvaKgGoAZfsGHBgrXQy5d-LFheXf6xCqi8DmQBNL8WZOVkFWfXqulxqgNBXc0_SJG6z2exnISKgxUcWskN1fx5vhFAnZ9czwvl-SsTs0by1CzNFwb6z9GxlPFFmG8wQQs2DDVlEFo-F7OsNm2dztJSeOdcMdez5V6ArejFkppwATfOI5F964C6iYQnx0nky3TOzurMXnWgYkElNbvhpCJxfiyqyjEqSIwpWgOrtlZtBuYVRgrMsN5MFo5Ax5U9bbEhHX2q02hbkKr3Ri0g5lthO4dWP_NVQZF1zCwvoanaW6bZp5vl4djVia02sJolDsE2pBKCGuF901y8k1FQE1DWY_qWh8jMHkA3sqYHZB1A7cKcvpP84nRfb_KUeGxM3vIEkD69bExaVdqsADhybKcb5s5LUm-sJ7fNFr8EyMJRGH0MtOMEsJHsB6Zpmx9DXlg3RNexrjyPm0TRrYjr_LPWsWK5rtFPkdUpshYTh3pLU1_BuBsn3rcOzr89mgdaOj4rvlUHxD6H8tH4I0kmv77bO2AYHyLCbGwhzPH84NpdnqpQWbW6mi8rqW-_wCemrhzCxEG249i82EGqjtudhuCUIMDx1I7TuTt4q-PMMiRUn6tdoxAOFde4FMsb-nG18bQTox6ewlKPGG-FWr78wbgd3p4NhtMEZu15mknjBEbrD65UsGWcRDO1Mdn4UT7KaPApDr_PpHF5-oPBHA9ZnnCJb5uBbfPAx75NXcdyPHV0xyaeaTMvcAMsmC8DiyIHbCYCZpmOxMgbaGo0l34wbDzQn27l9x8Mag4uJ2AGvTDPfjDI4B-e2v4s_X8OfT8zbKPcgGwU4fPiZ2xAA8jBmr8bIpUF9UZ5kqGBENrfTQTkOUtQoxTisx8MhP-ukpcyu1sq-A1WwMOEJBWSN1htVoY4SkYRuEW1Uxm10WqEmXE-S8NklhnDLFMRfnfDyzSJjWMg7JtMu1td623lelv2-Sz2hTqADKRp5YDsQCu3kaq_kLIfsiqhKNWnswVe24KsbUHXtmBrW_C1LaqT3zpta2oBbtECmNjidKjxMY01twbX0g9nk25FIJzwgArhmS4LkJQBDwh2fJNZxHdt5GLMkHR9Lkzmcdc1LZczTLDrS4klIX5TEUhNEfhKRWCditApDaKhCJvowZlab1D1DX36JTN8CVqAzbpybKgTpL9OXEnhG8fPQIQAdqxoeJ24xrWWcJjR_89kvE2CyZIEn11dngwWK8a6NDY4UaWS_KXc-q7JWOAAb5ltE4Qo8yijDAy4YxEaUB4gh3mWxYkEN-c6PpU-NLEoJsLnPmnKLR0sTq2A2RyAAM8gksoMfa7SqO6jrAu0ORhGETidHFrdgcrJfeNuFlebvm8TkRphoM_JjAXMsrJhE5F7Y7Vtb5L4YQCBsjpJUx8wqCwMOE1nUyCllwS08ZU2-frpw-XPn86AsbPITdLYuAdK3oOPjI0PKvyYgIcZfA4h8Q1F_JLPNGAkMC3kOyZwDVwlsm1MuUSBSYnJpA8Mh1kIqGlSyybwI3elizj3kTCxby3bh-LWvx8M7Z-XuN7gbqkepQ7rzY7N8zJGkhpKTc8iWfiF2m8ZaLZRdDVY6K1RRPtKdau7SQx9U0l1Hk7khmXqc3JARHFZwOAfk1kutF2qm4vqOgxDJ1bGFOayqPIYRZlnR-rbNr2sdXpvpeKdACrESG_ZG0D-MMmSlikVHDvCdk0TE09gIX0_CBh1JQeLzjgijs18n1FBA9Nnpi9dj0kKXsBxPd9hYkl1eHParhIIwUCQ5tcvlAwxpPDG5Tnmhoy3DZG3DvFajkSUTEQcCm-tXwMr4FkOs6lNfM_FtomdINAhHea2xz2Jqeups94-GIWABdKRDrEdYoH0-kSIF_Zh7tcYXTIDyp3RZXe2zikZH5Jc2YJud7DYV51MwKjM0lVxF0ilPmJXGM1uF6NEQ9X0JhvamX8XT9MmLVaHvVuyq13qwJhLnUD6Djepa0mGwa-Y1Oc2JcglFBwGJVRw6kmPBxxMGvV97FGXC19aNgqW1eHfwpMUrvO1nsRuiTHvpuArwJQmj9HgPJqpkR6LzAtjCMmKQsIPEFrh8jP8VN0oGkYSxnqIbYsOyqweWtqo-tLWFPH6TEGuGpgQqVLmcmKCmlqOsARxmSklcaiNsWkJH3E_oJZp-wxyNxNT0w9cD3nIQYM7SHMV1yAUg3TXUOMcnAllP0B1viRpBJqsHy4pf3lMUg1sUKZhwI0D9e-4bhns-rTiAdeuZCntMoI0mRgXysHkaqOAOnytPVsZgb5B-nDopDglacxLBPWTom9UYuetdmaDNwy9CFLfcK6elRwHD6kcK6CjpNlnAE0p0YS0ErAI1u26Vyyq0oYqS5driP_rUrUVLexuRXNaTZiK1M5AOmMQnuFU5Q4nYzAuMBWlEhbXCw6KuwbLbxCy0UH99sGXekXgv0ZAgDxL3cviWdKzuKn8P3yFfJDDE-o5EA3YXoAl94TJpW-bnjQ5ggDPMyFiCMhyjDdXl6a2GLf1MonT1JVfwbwpfTCw9XcjVTfpgTydPeWpaOiNKopqZbrL0_CbzAasLn8NAb5Pw9EIVFuUCeNCPgt3CPIfJZk2B0uxSrZvPIb5GCDBBrEyaAElBS1NHuPBG8t8qS3IKs50q7J5XVPUuCIdE6lQdbkjRUSqIiNty0uEL1oNTkQcJ-rKLxjIgJktKlcRZ1R3PCrdln-mk9-Flr1Kh5DZ4q0u4yCMwR0bP4VZNtDXsilWf5pF-laCuhYEFsSHAWNIKI-vrlm3mONyjmUQCEcg0-IuEoSIAEMm5PqBRYnwhGAU2vm2XC4JzrXAako6Muu2u7wprlzaVPIArqEQv7JaMfiUwQ96Sd_AjvE5TCKVeJyCjEFIiNlabAO7ITH6DghXn0TI8gRUbVDGpTP1q_sMAQZEirpVEXAQUgcvlKew7ka1-DhoUtWGSke9mfGm4TBkgQa8ZEH5a8W0tzNoFaC2wvJ7YNTEeB-mPlB3C8lG6Bl3AqKrelzCQBwgTYYkingyMG1PSAQpsUfAWCJEKbGkEh6XMMvx9FVdYGUFAemS2ET4RQS5qKE1ZAcNMG3MpN5H8qKu-49AvY0D8gX_n28o63bibxyrxevbGkCtIzXaUqv1zopbGUTqYjkDmS8CHWhe7DQtBFmm9SIfbim-nVd0F0HYX1VedeNyi0zeiqlik3EBkzG4ePZTiL-V2r9Xi_qRWiOoAnGEra5AfBGDI2p3x-AmNu26rHNIkwJTEjuQylwiyK2lRzwH2cjGnu8Qk3sOxA3cEYx7dmAiSKt11QjsK8JyyxicrYjBG3EFW4or2IbGtixOQ2OnTaCrZnUdQ5i3xAOoR4SOma2Rlpe6L-Jxqy1Kx-hlNxi1hx0LRWuUrZob_Gqt6ItWf-lkv1BkRQtnbYv5qwLaVH-pPv7h4-318GpwlcSj7DFJ_YZWUmxRHCDpmggFwjKJ7SBsU2ExCXkw58JWtTzsYQ4-yXUItyDO8XwhpETEMxvKhsyuCP7gfU3T7KZresPNNlnetvSAaJszVtr7QYTR4D6Zij-MW9VDnQ2eFL4rLB-iN-kIRyIwPy5Tb9vxHe4w0zR94tseDTxgUmASjgLMGCXcJAGFvGnJ5tQcMVtyxA27MnxIQr9WiB6GkfqUtebgKlNY6NrCM8_zf9N5qeeErtHzD0l8oMrbsdQv_qlqjTqAO9BWRr-hw1DX9BvqdSf_CxaYEGtbYRrOoqq29mmahioDHHyMn5-M4WQGzrOREkghiY9MHAhEXciDqYWJhanPJYiPjbnJLBv-b3KMbQuB5wPHZzsEkgLPl661oojMmm5qsZg5LwVeg4Bow3s-S59BLLRUqCwSfFAaujNoA3KhCzeQDMt4lI8HyGnaceX5K81sCFSxoXLuCbWYqMSkyrzv8lmsd8brnHOeVQ700QhonhlxYtReHPVXsKYvIWwL1pJcr15BFpRNBxf6PrmuFBSBkZYEE58FtFiisJGUDuJWQCzbMplLEfMxlxBQubYAObOJ5ViO9HzqQdjVGTMh3hQ3yOiEX2zrfJlAGPMXGdRTT2Ia9zJWW5HOJi5Y-H6pJ3delXriRnmno8ihy406vSyQNMlckYuah7go0XZfh_n_LhldWtW4Hr4H23UCth0mUcxXB36ehRCOhupMqaH35lbXGF6oZd36KocZ4MBjEAa42DFNz8YQGzDETd92PM5BwhCzfJ9w6XieK1RKy1wV0TNuI4f5q0riXWtjaGHW1M5043Es43nlS5e9jGAWRQPSmOV5TcFeseBaLo31KTK_bhralkCOUyXBJ2Hq6ZoAyNZyIGJyB3SZmxgyIeF6Ur3uzwN1dbnpBcT3fQjSmLrWH3smk57wGfGoilVswQBArNhVQ7cLRFCjwt-oGKsfW1ILVNT_O5fYoUVHrYCQv4KVf4V7cVrrU8_TsXEH8pGCKIJxAM3PwYo1_Ao1Qb8lRhD_ewElFjMpQ25AHCx8B7J3n3ILMgR1pT2RyKLghWwsEeh-YJkoWFJ-qyMXh3_11TALdYQ4Db0-eyqalHp9Xa1ngkGOw3zmg5w1a0Xri164EWCXNx5r9BCP61DoVD7lUjFxgIm9ZotkZhTZOKjI8q_k0Gmu8K2-XRk0qjXd_yvF3qLaj802_wjSBPOqbJVMKxd5J6bTsTJRc_94shx3gd9jFOIsDxyiy-wAkmPEQfgFFZAZMluqvTAMC-kQl_imhITSAm_qgN901dsdVtWquou5PZ2j1eocF6UbVg9h9CsFa0vMev9hQww3cZ2v2paBUdsMHc9cV9v80_AhjGVB0nxm7qRen2ls5BHCDDzOMMWE2BQMlE-RAOvk2aYbsEBIG9kQHFPhuha4VyvgELs4DnMdSOwp7he4cNLckUFqq5DDiTrCUgWdYEVQM2CZR6OpikZZsYFs_hCkLwqVbsfKC-bR8-B9EX1eTiZgr_NnZRL0y3wUV4IkNaxyxTFT2z5mhWyEEFpXjdoQzBf6yovkV-ER5SkyFRQvwf3H7wXCuHUlfVFlOUnCaHCqEtfcOE7DkXpxeCwXBXMT0c6tKxwhVCubq6addXPdth4RMjeQpoupxQLb9RCYEp-B7ZDYFNi04ZGwJZeESdcCWfelKQLPltjiyLGQ0zxwwGtr7MhZ3pKi_3VuxEaLpXZmbrTUXjhDJW3YflG3qhfHkYlfliF0NaFk1-ANf1njOuBm91pVqVU99tK8KKj9Z250267ihUlfr6jTlkbG-BOk76GfZF4ybWaO2HKkz6hvc8cJfAJZiuUI1-c-MqmLg8C2TFNQ7rueIwg4xIBZnhdgU0qTcCp7GuDtnKPd6hxVibVW32jfIfyn-UHaK5MvKtqNGbmBThJo15gN22Rcer5kruu44AF9j4EFodKTkuiKNwtcgbjkFCJ68I-QhkJjjolvWSKgnXt1_nV5PGMt1uBP4z5rSZq-qAPqxkWSBIMvz-Cl42L9VF9hstjEaHV7AjDRVm0To7XCEeimtQl0JfU9y6U2Qg41QWcgtHGoT5ntCphPz7Z9dSbPsh2KiCMt8Aqq1ocF8gLCmbvlAirvXEA1mpsYbdpM21SJrEeBobmAqKuHVc6lFhfXLoXSlzVq1Ni2Ukyg3iqijxYGEJT5830JrU6DmN0VpNrBu34VlL_SsjVpmbrgY8XpzsYLPqKkeHXTjfvp9kqdOS2Ot1bXn-s7ZY2h-5xlojrvZdC9-due5qd4t0KENkeElnHwHeBgO8BBd4CDbIOjjbF8V4jYrhDRXSHaGY_wrhC1SrH-6dIHLG34iuOTxfvWWl-_1hOBfsFa-_vW-iHQb3JrfbFbPwTFK-ha30jXycziKvJe09GHhOLtdq0vu9uQhE1Eq3YT7WsEq50QuhtCyKsJYbshhL6aEL4bQjYbD8Sgr_FYK-jgr6Xj9TKGXksCeS0C-loEr57NjaZBRvmreNgCj18JT14JT18J3zkBxW0j81v7XmIrsusa_5C1DYIaAzHZBkGNg7h3FFCjeq2nKbYy1SDYOojq9XoVhN03xF6AOBuYphoDcD9LUhsM7qV2tS7Wjl6t3zc4bPeCqA0e0V4QZNt4o3iJb-s7fbfLgvCu0imyK0RsV4j4NohenyTincT6u5imXczQK4x2YUtea_ZruoW265G8mmb0SldTE2m85SDwqwfx2nhjF-q0iW4Xe_Tq1phvqz07Cpx3YQz4K0Wppj6YbmQeXy1Am09e3TFuWJ1QL6FveyV9vypJrV9Sr1IWl-Kpq_CEL-_0bXdfpKoZZ_q2uuJaZH1v3UTdO20Ay_NbKaLJu72bkz39dejpC5YvRDZ-t-d6pkOlkIggS1jUC5hklu9w7LrEpK7PAhdJOwALJJ_0-0REqq5zLmuhCp1aP4Gpl2mB0LERVrcWuBZ2BHckgc9E2oybrg09SZ8wF3CL4na9D0levBFa0V59easvtS7qsbULXPXV1F-LywJfXhLbvGk2zLyv6l7b5tXLZ-fnZyf3l5_PSpA7WdT3s5mbFR_f7an7BfU2vlOZizDKioJveWF0pO_T9ZIoEtNMXTBde79XKzYNd7G4_1Lhqn3dAJO--gtGoc9J68uDFa7Ft02JKkhQWzvuw0lJ2Wmy2eiKdfITJWIiL3GUF7RugEWtz5fDUR83gi02axfA1edNOZGrl4xPpaeuz1bXNtanXL2AvHy2CV_KjXHz-a5uZ90Ah94kUyAoP24AfJOEmbprVEFXnzfhqtqyWHG1_LwB-Kn0RDn28uMGwHqX13sRxom6XbrAMn-2EaYPSayFHJSmWvwq0J1FcvFgA4Qf1W3AxUJvieka7Mz8wWaKU558KfDUv2_CqzAoZ6n4tAGo2pFcjkF_2sQS1e7kKBnaeLIBKjBf_tyQbQZaLI-W_KtuCt5kCqr03V983oQJ1XW-evzVl02URNtfvUpb2AatLssPNzIYEJa8Hs1p4o92QI1eFK-WyOeMeg1GHT2W81193gD8U65vk1uDZXENfKfCvQ6D0rbXYbgPY73LemsEt_NI5HY5CFkDOX_zg_bV1Zf-8PMLYbbGUNxNuDW4vrl7a2ht_09loG90XjiAxZNNpLn5vo5X4VJnHBdvT3gVKj3EJaPUiawPu0pH25NrazAW5kNvDa_bk_LBpsYX4oKLeeS5LabC-0PeewFJVj6-SZLodQivi51DQNkOxqk2b8-mIvYrdB-b8X4H2nXTkOQZ4DyehZF_Kkcyfi0P9VX3PRAtbmU_KlPEt0c3Ih9_DDQtMKH_Nfgf5P501A==
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Path of Building with Rage Vortex selected as the main skill, Rage Storm enabled, 100% chance to Impale, and a hit rate above 1.0, using the provided PoE1 build code. Trace the Full DPS and Impale DPS calculation paths for Rage Storm; done means the Full DPS breakdown accounts for the storm hit rate and matches the reported per-hit values.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.