PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Lancing Steel damage calculation error

Open
#9,467 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Damage calculation for Lancing Steel should not display errors.

How does Path of Building behave?

Lancing Steel displays a red "nan" output for damage calculations when setting the Skill Part to "All Projectiles Hit."
Same issue occurs for Lancing Steel of Spraying.

How to reproduce the issue
  1. Equip any sword.
  2. Add Lancing Steel.
  3. Switch Skill Part from "Single Projectile Hit" to "All Projectiles Hit."
PoB for PoE1 build code
https://pobb.in/T9NePz1hNi07
Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked PoB build, using Lancing Steel and the "All Projectiles Hit" skill part; also check Lancing Steel of Spraying. Trace the damage calculation for these skill parts and identify why it produces a red "nan" value. Done means both skills display valid damage calculations for the described setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.