PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
The Sundered Will and other Keepers rings rounding different % damage sources separately
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
All sources of % increased X damage are added together, then the 15% value is applied when calculating aura effect.
What is the value from the calculation in Path of Building?
The 15% effect + rounding appears to be applying to each source of % increased x damage individually, resulting in a math discrepancy.
For example, 6% inc chaos damage grants 0% aura effect, due to it being rounded down to 0% per occurence.
How to reproduce the issue
No response
PoB for PoE1 build code
eNrtXG1z2zYS_hz9CoxmetNOLVskJVv22e3Isp34zo5Vy2munzIwCUloIFIhQTtqk_9-uwBf9QpK-nbXTBMR2H2wWOxiFyDA81-_TgR5YWHEA_-ibh0264T5buBxf3RR__B00-jUf_2ldt6ncvwwvIy5wJpfam_O1W8ypb4cs8C_p38G4dvAu6i_D3xWJ4K9MHFRb9eJO6YhdSUL77CoG8vgPvDYRV2GMdBNKPcHgfuZybdhEE8v6nadSBqOmPw9lcn5BDI9U9_jMkV3BY2i93QCMAMXiOrkhbNXjXt73394fKrnknG_JBmNXOZ7vRxBFUOP3pz3BZ2xcCCpJBH8dVHvgmLoiL3jElqgIgbqZv1oLe1lHEbyik7g52aewZQxLyOzVpH1Qi7vYyH5VHAW5vSH7VUcIHFvTH03l8FqrpTiKZBUXPUHm-XVlIEsoDr2aik-cjkG6iL0ZoZLAToxkgapb0c-l8yYvB_wKPAr9dVc-l4sBDiHEfoji1j4QiU3lKYXTJ65X1bMemm6IaMPw-vhkLnykXo8ju6ZDFmUsTuHziree-rTXhAZWD1S9lkILiUrMQyYG4AXVm2jIucdHzJzykr9SBiqSrNdP64HpnSVgbcT6BGmNzPKQRALQ0qZT20n7dWO86VIaHVW4l2xrxnZaqpbXxq0esVeAqkDjcm0cf2un0vYcg4ty2q3Tk6c41Vc_fEs4i4V9_Qrn8QTmL6f6GeWN9dqr7Gq0Vj6MO-s4rWclYHlhodsC7ZeILxt2MY0iFbytVrr_Cajs5vroql7hsS3vmvmjR_8UM3DhSC8Bh85HsFJMNA_C2bKkjeS-JpJTNZtjZifNDgz69AdY-74LeRUj1Qys5m1II21VrNIbKRZJFyi2TX4ZY4KakLG5WqyDjvrmCoq6tpn4Wg2GHMmvGrUqWA9OjXKB92zIreRvsvNVbKZImtFlXykoWcWKKrK9EKj4lRrnaxXlyY3s0wGySUweGwuO17J0Q-DPyGB4qIaWzecBHEepeyO1V7bCU1v1Ic0VOg1xiPzYrcUmezVilW5IH9hlwJWXKZdybhAUCEqsXalpO7nq8AbGStONVKJoyzfIJ5OYR5BizAFwCAI6Tgv5CiNtgH1A5izkVdjuDRvIKc2biBLAcxbmWMx7wvG8PlmnFMDcuMmsgG9hwljAoFArZJhcZ-zHp6udKcbWIQZragUYXl5t9rnglcQfoz7ElE1akh38gXXSlFC5v81M8YvkRs1cO17cYjeYNzGPMeyZp74BObTKLqikhIvyZB_pyGnvrRwO2O-0FaFEaOhO74Dk7ihQjzDDHFRL5bCE-KfH6kdJvx1K9kkInHE9BLlI6PTwB8woPS5ANZx8IqiX3GwHNCNy6J0e4kqQ0J-RW7pfR58JtxLn988gnhydkY-vL_97cN17WnMyCD2PcDyyEcuRO0mHnEEIo_gMTW1kQXrkDPSsmu3k6ngLpfRGbFrPer7gSRhIAQBg-VDzsKIBEPyPvAbyheInrbJ02zKotrfko6isz_ZK8xcEBs_hcpTUO3ff7Z_IDIgE50uE838mNUvsFIpQ_4cS_b9bxi3ETtrHra___zjScNyfkIgUDXppjRpyy6ifvKUSEW-rudFBHktxfujddKwAabYg3WylySwnIZ9-pPqzGIncsIf7WbDaQId992Q0QhUjzsYqDw9IeCvLtgkGXyGIYkWeNvAG2I0BM7C7gpyw_iAVcwQocxsfb9NWosI9ZEviaZRLm4yYFREoMTpVMywqixSRIZhkI6RboGAJ_1oNRsWigVkcsx4qB3ogMRTNSLZ4EK91W7-gKZ4DmbziLIl9kmUoDjlJTPeHIW9kcLZSNHaSNHeSHG8keJkI0Uno0gXCkfoqbnLvuhpBOqh27r3q_xXxTdU7D2jGOZq_ZBHE7AIl_wLTbaWTElnBJdN-ZNOiInOiPNiXDLkTzpbKzDpFJRA4oxN5XS5v2Vlb0XwTAXBLV2iM5S8Lk3tUhcryJhE64UazBYWCjFHWaQsOu9cacElBzCluxJ8KCOx7JrePwQ5MBbU7viEI4UMoLI4ATZrfydDBJ7Vp5CFwZSZ-ANH9SCK9qQRjLQkP7fREZItAT0SGYJthOAUJ4zy4GVIzhayqAHPEFpGCCflyUvZSAbRrg4xZ1YZ1LFZf-xl036KcWKE0f6B3GbiFCxXGekAUD-z1Igz5I4R8nGxo_N2n2GdVsdacJXcJJvV0YrulQNZ1YGKLpkD2VtIVIrBGZKhjbeWx-H_B54NFKcbKazmZpLNWrU2q9VaoteVgdKpJ0OxLE5eMSrH_4BcOvpnRB7gd60byRDcEFYDktX0DAZpbcdqJw-XYILJ7hwXDGf_PHaBfduHzcNmucgpF_XiEBJ0uSTKOLXfYiqUeHazpl8JQ0h5bGR_Cnn3cSnvtmqlhLPTsGydb-Lkdy3UGhJ6ldt7VIwNTyEfjVhIFDq0TZRadKr5OmaQQH6J-XTKvHIrrSasrpdm1oW8NE0AC2FBbYkQtaQtk3aaDdueT4DLMcQpZ9bHzcaJFmFSjKCWSjiThpLsVe3tASKkquUoax3Y36HDMGG02s1yxjsFpURqwYVN-LA-e55hiJ3wogKt738EMZEUIsE6hGEQEquZPMGSyCf_xoVVHu0PHHMgZwHnbQC2dhMEchpyX0b_6xPasslobo6A9fDqFXVhbXw-ELCi9dVJicvAmyVGSbrPsyjCLEB5KgGpISec3Hq4p6B-9p8_PN4la_kyDCQSL7DgmkOwdkawd0ZwdkZo7YzQ3hmhylhcgs_sNBRLAexdAZxdAVq7ArR3Bag0CkzInQZhCb-9I7-zI39rR_72jvyb9a_obj0oTGDUzgBpdU6OO2UO4gceQyRdtyjAjaDR50pDpjnsyhxOZY6qA1GBXMcNYpHBK53uYoBrgazqQLYC2pcA7X0BVZkT3jExYXL_CNt0pgJLdxILJrcdsT3Y0NZmV2nCzxKhnMsxc8cq-sfXDZU8fq31OVVb3psHt6q2XLA4a2MSFNLhFjlLlTRLtVA9vdxGfbvPfdZeJuIdbGcVRmsPGO09YBzva3ayKk_G-2rZ2RdQa19A7X0BbTU6-8gY9hB69jJM-xihfQzO3jMPa2cEe2cEZ2eE1nZ5wm5r7JUw9n5gnP3A7Ek3G8xV72QNmFSnRNThEPzVo8KN9P6WP43TZiY8cj89x8Mh3g6qk0iG6mbT9c3Nde_p9vfrBLLIEuEblE9-PHnGyzb6X9wf1JQDpk4IEDcQgk4jBkIOqYiY3jVTb1_07jY0Fj9Hmvqi_jtnr6ryiknKRWSE9o5nV4mKWAonrzNB-khDN-SYkhSBrr-yEN8tZrUmUOr-z4I4WhY84onHgsx0pW8_FaH0rnWPRlIdQjVBwfeRZRAsMevK7WRKxZxykzLjwcaTPHj6KFqiFImnfKbM5UPuahrDUU_PLpZ047pxSN2ZEYa6RVXm10UmzPqWVJk7KTPSqrqTNadVXWZkX8ylszK3LjJhzg4xlwGy4sDHy3wmSNeCdbnAd0dzI_s-8JWxg99kBCaA9zAT6XNDc4APcszCtMYEKX_btOA9abmRrtS9ipKasMSoL-riQJFVlRjptXSUvjQbFWsMJ7U5CFViwpoeYS0y6zLDIUgW_yX16zIjJaRn3Ev9TwqNnERNt92XgHuLM8V85c6A6tT3HuTCc927w8wf9DZCVJsvc_6SlK1k12dIV3F_kBzfV-8Ggh63GwI63m4IT9x3ZRwyI4DHhWzkcW0OknNmZ49LsTop3JY_O6e8NYI-Tb01uzrsbTz_X7GhOp-8JABkVbth3QSQ0UG6oQ6_7og1kLF_BepdD5UraEMPDSYkcywdeSspTU8qybXDxflSV-wOBHnBO9MEdCVSdgniHaMC760HYjfA-XuXBkOwEgvvcsVT6nsp2kOVtH-19gIZAag69n-Fd8ainaTEoyqzAs75UbpCPH8fQI6E0FiaPpw_hYzhMo38FQSTPy7qp4fNzmmrbXfWXjHQFxcGMsT3hMh5pz99gWcw8PE_eEHmpHVo2zb8oy-5qqaSywl4_yu7mYAPyeEWGs66-acqcC2sjmZMYG3EwlmSLqbvJuFHu9NxnAO7Y9vWgdW2Wq2DU6tzkLzMdFMMEEpiN_OPa9gnpW9iaCK9Woc1t_rxZizlNDo7Onp9fT2cUjkOhuwrF-zQDSZHU33usKFWzQ0EP-rCf5cj-P9t6_RhNroS4TEWXSjQoxQ1eQEb6SaSp7k3rdk-gJ3uIBwVuc7R8EIO_U82BlB_aqhRwWpTIPCHfJSoWj8Ub4JkJaUjL31BXTYOhMfCZEuAoS2Vb94VdgbslpWKt8ga8REXD0MVJ8CEVABJOdew4dUadpUcWCtwtFezKCHxoGk1ARWbOm41z9c5PV7NNs1uRi5K2WpuaC47pdtHr03ZHIO-pYl7ytPe2BS6Y6FPrU2aKNzWM24ky-ezcWparTXdGbiBmjSo-9nMHPJBmpfNWSObq80bnALPdT7xEQt7QewXe7ahyXSdk9IfW6edU4NhqjSuqPLKDFsYeWZ11XgHY5hyqo5Vcj0XIpY6lpcznmyypWRbLKffxID7XemGkem4Is-8FtZZ0iT7_BB-RgdvximFKGsaMDGsMEMt3Fad9zII1Om0rMO2esKfydn2CHLct2wSXc6u-oMb3C6Y-0BOiSAN1B4bUugFlCcnjVU0VJEd1pKaQ13Lg5X83Z2u6QqZECNclsbkUEmw94Nwkn29I712mOwF59EmLSifr8RCwnz8pIRX_CxWNwdRiUuWAJSqklJBn1GOOp4eFjGEUD-5CKvrj9a0FYGDu_jhLAi1Z87ZwqnwA1I8Fr5KNrzYKQI5dzZiQVhro6hJOgC6VUaj06P8THY9EV_fRrGT7s91Kfn6mI3ji-3eegmERvhSGP8impXyu2jWJc0dKfmTJCMZRmWc2iTxZ5-GcgamEUnu02RHSIBsdDqF5CqznQGalfeC7voEWX1mVAr7-isaIoMceDiMEqdRuPcMfUTvISuJ5i9Hf5vqc_nfJvTrxWlbCVpCW4nfi8Ok-TeNRoOoR6LueBF4rlkVoK715IyfasNLlBo0ez7rc9-nrmCXQRTV8uLuCKwk_WhaupQo1D_SkD2EH3z-JS4W6x1p5hWRRMioN9PRtVQD8-Nkqj4TIaFnHt5vyCsv41DdEVwAuoRZUgq2pAUMCcua7o3BHJbKRNUdgoq6hIFNtNhVqxp9b6DhNL9ZbbyjxinRgelbof7b7fvetwb8wdcPF9q09XrhiKl_cJa7uGL4VuxA0WTSHr3Q8KI7HAqOtzMuZ6qJWmGJVTtebLpQvfeml-nr_Ei5hLoZPsEqwhSFKk1cGNwWycofLfwvQH7r1Q==
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is identified. Start by reproducing the discrepancy with the supplied PoB for PoE1 build code, then trace the aura-effect calculation for Sundered Will and other Keepers rings, focusing on whether % increased damage sources are aggregated before rounding. Done means the calculation matches the in-game value, including small sources such as 6% increased chaos damage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100