PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Small Resistence Cluster Misscalculation
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
When a Lightning Resistance Small Cluster has the “35% increased Effect” stat and Lightning Resistance as a suffix, the game first adds both stats together and then multiplies by 1.35.
15% + 11% = 26%
26% * 1.35 = 35.1%, rounded down to 35%.
What is the value from the calculation in Path of Building?
In PoB, however, both stats are currently multiplied first, then rounded, and only afterward added:
15% * 1.35 = 20.25%, rounded down to 20%
11% * 1.35 = 14.85%, rounded down to 14%
Then added: 14% + 20% = 34%.
The same error occurs with all other clusters that can roll the same affix multiple times. Chaos, Fire, Cold etc.
How to reproduce the issue
No response
PoB for PoE1 build code
eNqtXFtz4jgWfp78ChdV-7TpBF8wJJXMFCHkMpV0GEi6d_elS7EFaFtYrC0nYabmv--RZBubcJEw_dBty-f7ztGRdHQ79MVvHzNqveE4ISy6bNgnzYaFo4CFJJpcNl6eb750Gr_9enQxQHz6NL5KCRVffj365UI-W28Evz-yEF827h8HT8PnhhVQlCRf0QyKRgGQNiyUBDgKe8vyryzCDWuOIj7FLHpE_2XxLQs_lZOoUh5MUYwCjuMH_IZpN-VMKeZxCl9niEQjFvzE_DZm6Ryq0rBeURQSnuOpgEF5p2FxFE8w_5bX2v3RbECVfrkYULTA8Ygjbr0hmgJ586R51rASKLlsdMFNaIKv0Qz-bpzqI67SOOE7YPaJk6NGc4zDzfy52CDG_fEYB5y84V5MeG-KogDvxmnI2ietsvRjSjmZU4LjjYiiyne7DTmxm51c_JlxRK8Ho91mK0nG9Xi_Ez69ouDHrdyriPtJRDg2ggwYSVhkVAMt4V5KKYw0LdkhTnD8hjjZYUjZ9h6bvZJoh39y4UcUoR5LuJ7kAMcw4LkRYIQDBjHCVIch8oGMsb6kUT0ygKk1-9WjP9KVMybez6AhhDY9yRFL6VZJZynKYw2pa_yxOY41izh2H2kYd43fmBhFW9S2TtpO0_baTc_zW5WR3b8bbMb5XhG2p4uEBIg-og8yS2cQL5_RT7xZpee6yw4zmfIIooIu1vaLSeWGxHgPWI_RUB-2nDWmiCW6uLa3HNkkuoNJuxsEKcz1Cx1_ilGk0e3mODgXovdRoMv6EsUysG6ZjFcQQxgyYsp_pVvm1mZzvZJs5G3WdeJXdU1wlClc6AWbB4yD6S34eIj4ZgMdzy5H2i1yFecK2a3OrdJqOLfkqSpil6f8k3YZaOgpAdHz1DJsRjieLEZTgmloJp2b1UNzzU5cRm_z9wZ1Rq4oQw1d8h3Fod68oWeTXXT-_htKtsXoFXcpaS1PPWJYMQIgxLpr6UHM_itW4NQM1o1nLI01a6CEtSqQzy1qrzHEYRpwLVcVG4krCnso3WoUKLCTUiNol3MU_Lxm4UTbaVKJEaJq3yidzyGCiN6wg-CL3yxPm7C8JjpLm6XsE3TlbSO6pEBMsLoKlrK7FHjOpzWDrpIVgElVxKSvXZel8C4V9qf2fIRYMYMZQO6UH5lGoLmB7ZTWVkcKau7RBuwdLJ-Kw4Rko7S7ThqWRhqmxDj6c6HNXxHXUtCPQlhmwUjQ1rGKWKp5JjOInklyjTiyEoziYPoAbXvZaJTebhClrzDuRWmYrbW_oZigiNuynVcKHVEo-C9O5XGTeOqxaEwmFlLnHvJlhLkQlHYUJRYJ80JZpQBPYfjg2IrS2SuOYUEiVySRPJHCEZ4tip5fPqpZjy2Ao4BB3UYimCXbAJ-UiWCxW0-r-QlUHmAbjIP9iVvBVabM9aB2s6qqdAi1HtDxqs4Tp2tGHqhOVgZeWA2ZmypUAWVTIqN0iKLt6nz7rHNWAZfn6_UYd8XEmPDd9eqc-VWUiIkGnS8hE0KfxjKwQBcsRvCuPjuFiXp3l12t0mp012qrtdPPBuQnD5an6fUYr9A2L1Zi16BnF85db-QAR0ZdWPREje6bYwIVm2BRx2NEn8kE5gOWRlzfUqFwh5F2oU4EZC1vlCDFSa8428QxDmU_kVaOMB3rWypCVWHpxWkRlmUwV2_icfSTUJpk0Vy-ZMHcSqbsXSzZWMxv8ex5MccJLBsfHtSXLuV_pIgSvoCP8GGMaILhk5JOrhYwgedXAyEeI6gXlGcQOQUuSx_UxUDE4llxLLNCdSN2QNVDU1mv3OJsslFTlaqTeLyfCfMt_CH-GaBYqFaWSsl7DvyqojC7XhNY3sAcHoiKKsuVW4RY7pU0wepc7jtGcxbJ4ohQZY0QLE97Q5hF-eLcGnaH_aMeTRMOzfU7fsf0aARVpVa1rBejMcfhuSWUHw1iPCYf59ZfsYiX582T1t_d8ZgSuaOQAMkxQLCifsPJHXoTZysxRgkO1ULNKTjEBczRKB2XCe2tdLcgxMvBQ35tFSSSsWK-Jd1-bqGC9QfN8T9iGX3EOFgBfWUhtmT3PrfcI9kThvh_55bfPoLGAyLCk3PLOforUM75uxuGieVamZ1KaVL5jENLebcqY01Elc6tf9qtf1icWUXlrOHSuC1w6DZsyWHvxTGFRrJc0E_ylrJUU8lBDQtpOTdasoHEfQHEhWXH3ibh7JRwd0p4eawQ3bjoz8vBtbXvw1CkDCQBcR_K8S0eB68vwwex2FSB6Yai5KfVyi3RQChNlm0A6UIMxdwAcIfpzAhwhamROAsXVnUFo4G6pbDHSozUMG4iPxTd1jYFOKYAd4_WtrqviyRBEFLkhbLl78MxekfzVaI9jHHWEtmHIvL360irNK3D0LjGw2aVwTuMIXZtQw7kEZP-fivmICPEFsUHcqRvHHLqNMV6Bqc2g1ubwavN0KrN4JtG8zpNsZbAqUvg1iXw6hK06hL4hjP9wUJ_Tb1OTbxbE-_VxLdq4k3aTS00bWOEU3vacY111p9z9-qR9ZdYTp0WVnX3atf9EHZ7B-Co34rLviff70PAZAC1VW6f-Z_4YPcs9MhP9SvhHIDDPsB63913vX8A3c6hVvatQ21aDuHRg-1XvEPVyjkUkX-oqrmHsqh1KIsO5iPvAF2odQCOfSKt8QbMLp9j5Sfe8qhXXl8iGiTqdCuap3zNpY44qvuhijMmJZnwWCbl929u-r3n-2_94tCeJMGP13Q8FvnwGWSE5RGoFTBK0TzB4fKIPH1N1MfLxjeC3-XR4DXmiNBEHcRlh9oUpIzYJO6uuPiSXHfVezBNpv4HjjlU9juKg5jgzK7izdgoZYJIMBLX1IptmUquR6QyVnoo4TIBSnmqlKmvxyKutbLqiEcj7P1sjmimOXs29gQX9yhzHJAxCcSlQ7nJxR2LKjPyS56rmbd3JblGj0Nm6isC9WgCVhn4Cp09G3lV5vxnXlXPJvBrHKCs7urRBFzk1LEIHKdYijIjpq8skp0cBk2XUJEbk7Vsn-KiwITwSVz_qcuBjOkRwkxeYDhwYvKa8nwYl96NfCXyfJWHlhm_elCZxqrqsExo1YxE5cxO5dDPuZ56VDIjMg9kZlB1u5P5r5JhpdkE6vRfub-ce6jphCx9RNW_kn6pOUhk_O2-MRLK2KCGy0qhWcCACb0-jcwmrE-zml5Yn1FuT7P2zp43wtVVcRn9wom45q5HIkZZPQYx2OoxPJMo4GmM9yYYFguR4dY1yGdknhKnpupKfpwWvsiU25tB5fPtDZdZQZroTfH_Go9lPsJyAihKjHozg9UcLDjkL9Rqco14Gl2DZ02pPjtI1nAlJtXjUvPsgZymwof65UwpnpR_SmNABOuCu2LluS9TkX97hxEVP31ktB7h6i-E9MnWDHUcsHSOojBne6ou9_f1HuMJkMr002vxS4WklpV9mYu4hefiNN8hXnxlsEYS1KI0f7l4jjEW-zbrT8Zm_xLJW27npNU-O2u3_E5Dlv77suHann3id9qO4za9xrYcIwHIMqBsO0_WHXHYkip7ZNqSheZzHC09FOIE9mcoW11Q6AYjkZQVvomh9Az9IqkkOgmb8xwv2HwUybrixeKiQsufYjvt7Dfk2T5bnDECW9vtdI7FOeOx6_vtzrHb9s-ax61Ox3WPvbbTso9d12ufHXsdz3GP_VbL9Y9996zti2eveezYIOL5Ljx6Thto7KYHBL7T9KR059hpnnXax37TPesct5xW06n8cj2zJpEJKChedKufRB6KNUMis2iRLZLBgerk4GX4IB9-mXI-T85PT9_f30_miE_ZGH8Qik8CNjudq0ydL3L7_0X45LQLf64m3W7_6s_g7oMMhvNHP_39qffRbkZf8OT-P-2X_vx9wr5MJ52X8VvcTprfu-8C9Ue3O-leSuWnufbsXDdRpmRvxYGGvf4w97QMuhAjKibQHNkBh2g-2WVF-_56dHG6-r8E_B-oAYaX
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Load the supplied PoE1 build code and inspect the small-cluster resistance calculation path for the 35% increased Effect affix. Reproduce the Lightning Resistance case, then verify that the displayed result matches the game's 35% value rather than PoB's 34%, including the analogous Chaos, Fire, and Cold cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100