PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

impending doom support calculates multiple times in full dps

Open
#8,966 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building, and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't, please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

they do not stack in the game.

What is the value from the calculation in Path of Building?

it calculates doom blast separately for each support

How to reproduce the issue
  • add despair
  • enable include in full dps
  • add impending doom support
  • add impending doom support
  • add impending doom support
PoB for PoE1 build code
eNrtXN1z2roSf27_Cg_vDeEjJOmQniEhaTKTNFxI2nufOsIWoFNZ4shyEs5ff1eSbQxBRsY-D_dO-9AatL_9kna1Wpn2_3gLqfeCRUQ4u2i0jo4bHmY-DwibXzSen24-nTX--PKxP0Jy8Ti7jAlVI18-fujrZ4_iF0wB1_AkEnMsv6ecOj-B0xIxucCcPaA_ufjKg4vGN85ww5siFhCZfvIpiqJvKMQXjYkP4IaHIh-z4Gr9fUK4QAL5Eot7JXUQS_7AAxiVIobREBE24f4vLL8KHi-1Ui8Evxqau4fR4_gppxJheZXAog_9EUUrLCYSSS-Cvy4aA3AMmuNbIoEVojHwOW40C2kvYxHJIQrhcT9mssQ4yMjaNrIrQeRDTCVZUoJFRt86OrEhQOOrBWL-WofWsVWLJy4RHY4m-_U1lNzBGz-IXFxSsM6Jr6K-mzMisTP5iJOIs1JaOxFfxZTCCneiHeMIixckiaMiVzycEubok4HA6HF2PZthX45RQOLoAUuBowzZObIumAfE0BWP1vPULSQdYQHxJjcQx3sAE-xzCNE85KzrIGQ31CrtnsywO2UpQxJAWW0Os-N64kpXmvFhCo0hQblRTnhMHSnlOjm1rVRD_OZANcZ_5Ql7ZzbCOybd2OUJW62WXb0XLvUu5JRXrm9H64g8O2q3z1vt0-PT07Y1N48Wq4j4iD6gNxLGIaTqJ_QLr-X1CpbffCEZZCcbtHNqg94QgcujrjgNDkAtEI-ssLOi4HJwAuyZ_mdFe8d8t4h9ZkIn6txW2ysEjCGO1G4-pdgRsRaRRKPLvmtEzTFL5K3czLnH2F98hWJnjCR2y9cZ1UmxWxWtk1sV4Q63njgCSjhJAS1OOjovApV00zXDYr6aLAimQTnqVLErtHSq-PzPebSTuzfFlVoxeWhJl_xAInDbSMrq9IKifIZt9YrdZcjdFiaGohMAAd6qf62IkeB_QolFaDnYQIQ8Fo4TboidDEh3B3OEGOMg9t12I1Mpkhd8SeEQ5GpGhgI9KS0FHUiJ_F9DHsydnaaFlEJs6jeJl0vIIWo1uDJQGx_U6SRXv3zqOVA_wlJ2imi1R7oLWFM7C8h2fXcpWxB3W9TOXcKYNbmziGxCHyBZhLAJ6DMwnNHX2cA6OXA0yx-dWqfH56eFxLvPfAmfyS9CqRepv0dIAKThRRClPlAOOQ-9S4qUG5KqMPdNutn1zs__hzi-zzT8FeZsodo2kUNeylFDbbeu56wTIDD7e-XMf4PcScA1C2KhkoCzjG3ELjFPJIQtJIqGSCIvSM4C35EgiMm27ilFGAl_cQ-L_gZROoUcqKcl-1Z92gK20lXdb-q2mXq6C5dcSA-_qX_U5K4uGjNEI2wI9TfAJ5KE6Q4DJFxKG95kwV8HwYuy4olzGqUgDy2XmAUbPJ4Exh5K06evlNA2qg9eCOsEdmsTj5FSOtd1uwuUGz3GQQFYRWdnnY4yUR0vkVgNNgkZAb0kyMo1_9q9pK9nOCmxH_rP43v98GEh5TL63Gy-vr4eLZFc8Bl-gw34yOdhcwkgUPiTXvSfFNvmAP5czgf6j2bUTDn1TcMvappPKgsJAjqbuWwqQ7XXlSfUwzcucaTG1Jfph76OsggiS8ivOIwuVxB5N6pg2mrZJK5U1BMszWLIY9JOZIBnKKbq-3_FiBI1s8f5b-9N05RxEWbHQGAFM6s2OMPxabVUrh_c35uRAZUJMyUunWYznYlCHgnSKU6-1D3RwVrrK0T9SOtNmE_jAM5QSaJJVadoqlRTTWB1_AnyzdUco0zOhz6okxB_pXyKaDtjZayEM7k3x6FaBw9YogDiqnknwYamMqSp2cHT95gydeQiykQVlTpwFGqIoyUiUGrpFbHxzV859ybPZlx7urGhVyvVa8syn8fMzCVDYRInqYDmPhu1Sg-EwarfcrCj9dl8QzqAmFKdR8jiG_YnNFsEmTMKhnOKaZ3-KXdlsr13wpV-YcghgkZQsEkUhb-d-tup_y9OLeu6QRDgQFfN6xuibe-9p9l24HuKf8pdWpKnRXmJrN8-sfmkb_aypPJI9mRdfZj6Qj3qqNMUd2wZS832ohGSyP85jWczdVWpqnmhb1-vb26ur57uvl8npWkeou3_yeJwqi4Ezb_ro9ME66aBF8XTyDxeNL4T_KoVGcJ0EBop6yhFywhnRaMuIBLNKeAKuGmqW5LddO7mtSawc7p-wwJq3PkPqJ8FwVa9svE9ShmBqhOlSnkbN3WJaWdkWhtXUCGbTpnFU_r21s5FXdtazVGDBVhIVIhaJSejezwhVQkJa5bMiK9OQcVTrgpOQ1XgF9-HA5S_KpjvpC9j56FvhW0MzKAdbG59behktMCr-o7Z6lUzaocPsY-stptBOzhrvnKm3yfYzSWjKuD0jTO9yCFoBoSqHop1Zq8pzkjsDB_lAovkIGjj9AA5KiUpDBxBprG0h3GOosBX-irI4iE1Zoea6w6LDWqsIBNtXAFYHJqnsbMyrXNrIiuCmn6a1X9Jd65gCpLGtMX9ZrTACWlv3mJ_MlwQJDr_Dl44CUyH1hIuW2RFCQPO-NXZ6LZzdTbbfejqHG8oin5Z5zsZtcOfpT4y7-BiahgnJiqoqnFQsVWNwxNhvowFPpjBeLsSWWPHxTVI1kHcCU5HizJH0lg8mINpfx4M193Zg9E6_0NhjMGCwg0goymIDxmzIThDFsSGIyut1u5EsrauFC-zFe60tDRHE-DJyw1FOcCQ7GEEe_ltQbXoxim7W7nFiKpX5DitxvDdSxxVmKn74XiJWJCye9xVo6_nwdF7XEbAU7fVh-oauqoPGQ5XOxjZ9eo301Odbrirc1ZyGzCRQrVS_-Y8_I8-h6qnpPnbSRq-UHEPCcyb0OstlaMI_53eZPT1uTnpPqvnrPlsZxBH2LwN9gOjJWcaofr05iBpeFiJNhvJlEsP6uJwNH0e3yt7zAkUTs4vKobUkGnyN4sBRojXKgG55DC73mC6iiJEPdPr907KMMBUbuPbJfB6z_E6B1jpTV7Rclt09xBGFcxPeLRr4LHboF4NBvVqMOggHrsMqrw6OzV4pF2XNWXW2y2GzVFW8seOYOtV1qBdmkNlkZ26_H9Sw2Jo1RAerRr06JZcCXWlmHbViOzW4MDye0ZtKbZT1f52xRAup0Cw8kyPocoaNLVFFQ67A_ukModeXdPaqivHlF-a1f3YrTyXJ_UsqjLGD8KYYllDJuzUkFA6FYOyWxHfqsf_B--UpRdttzTikCqqoldPqubqmqalW1dyqa2uPvgIVQI3Vvf67cqpqV3PHNS2U9Rx4OseZlNZ51ff42sqNk4qK1J9i-uVTQZVk8d7gf1m0urRbSrdRtJvIXA2I_OkoWQ-JC0lDcq-2egDjSjy8YLTAItECaxaZclPmNM3EE6PM90tgI13zFNYZx8qe6M9feEgRbbb3dY-iWL9a-gUdrIHk__ZQIbZaxp8c4B-StYBMN1IXCPSX9_uog-zH4-rn05jgYOJfsFBvd4ywXSWe4PkxMHG0o7JZm-kmsjZpLuiyk9E_kWgzEHnvT2w7O4z88Zxq9txcIirWRGZE_o407c1MAP6ymnr3Z1dsInPdTcZpswNkC37bR_sjbM076eAXuv87HwPJvmpEqd0jFhe2uk-aZs_diodNK5unywgQVrc129m6c708vWnLx_7ze3_8uK_pCaqOA==
Screenshots
Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified. Start by loading the supplied PoE1 build code and reproducing the full-DPS result with three Impending Doom supports; trace the full-DPS calculation entry point to find where support instances are counted. Done means the calculation matches the game's non-stacking Doom Blast behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.