PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Anoint dialog should consider existing anointment for displaying stat differences
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
When you hover over a notable in the list in the anoint dialog, it shows the differences compared to the base item. If the item already has an anoint, you cannot tell the actual differences in stats.
Describe the solution you'd like
The anoint dialog should compare to base item + anoint, if it exists.
Describe alternatives you've considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the anoint dialog as the entry point and trace how its hover stat differences are calculated against the base item. Check how an existing anointment is represented, then make the comparison include it; done means the displayed differences reflect the actual item state when an anointment already exists.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100