PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Bane enchance
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Quality on bane correctly scales the curse effect of linked curses but not quality from enhance (and possibly other sources)
says 18% increased (correctly scaled)
but doesnt actually scale the curse and shows in calcs tab
how to recreate: link bane with a curse and enhance and check the curse effect of the curse in calcs tab
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by linking Bane with a curse and Enhance, then inspect the curse-effect value in the calcs tab. Trace the Bane, linked-curse, and Enhance calculation entry points; done means Enhance quality is reflected in the actual curse effect as well as the displayed value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100