PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Combustions -fire res is being applied even when the supported skill cannot ignite.

Open
#8,266 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

I have combustion support linked to bear trap, but it only deals physical damage and cannot ignite, so I should not be seeing my hexblast's dps go up from a higher effective dps mod when enabling combustion.

What is the value from the calculation in Path of Building?

My effective dps mod on hexblast without combustion is 2.451x, and when I link added fire damage to my bear trap this goes up to the correct 2.666. But if I take added fire damage away and check the "enemy is ignited" box in config then the effective mod goes up to 2.666 again despite combustion in reality doing nothing, so I guess it's not checking whether combustion's effect is even possible.

How to reproduce the issue

Link combustion to bear trap, it will deal only phys damage with no chance to ignite. Then check "is the enemy ignited" in config. I just created a blank profile with only bear trap and fireball to be able to see the fire res on the effective dps mod.

Character build code
eNq1W1t32roSfm5_hRfvDWAuSfci3YtA0mSt0HCAtuc8dQlbgHZli23LSdi_fo8uNoYgR8Y-eWiNNfPNRZqRZgSDP18D6jzjKCYsvG60L1oNB4ce80m4vm58X9x9umr8-eXjYIr45ml1kxAqRr58_DCQzw7Fz5gCX8PhKFpj_iNF6vwCpC0K-QazcIL-YtFX5l83vrEQN5wlCn3C008eRXH8DQX4ujH3gLnhoNjDoT_av9eEGxQhj-PoUUgdJpxNmA-jPEpgNEAknDPvN-ZfI5Zsrxtuw3km-EXRPEymT7NFTiUS5lUCiz4MphTtcDTniDsx_HPdGIJj0BrfEw5QiCaA43Zc96LfazQLOW6SKOZjFMCjLed8i7GfEbcvOvk_E9M0wrerFfY4ecajiPDRBoXeXmTfxFeWdpJQTraU4CinodGU-zfg7VbLRLxgHNHxdJ7Rdlqf-xdXff13WczH9jNjlPCT8M0NBe-eIeVhHRKO84xu17286Ldb_Zbb7vaLZL7l7fXc7kX38tLtX1213ULmKSMxCyv4pbzOo4RSCO48o9GnMxzj6BlxcqijkX7EgiUJD6fA0hvDCKOnlVrmM-STJJ5gHuE4txK7Jt4JCtGIxbnw7RWRTnEEiYcfcLTeYZhjj0GuyrN0Ohc2wZuTeBrHKPqRrLA9ZSmrNENZbc6z43ZuS1ca-DyFZpCw7SjnLKGWlHyfNN2CgPo7T9i9MhGO8asdXJ6w3TOu-4eQ2-HlCQvwxviZcbmLv-cYmalu76f7hPD5ot3udFqt7me3324bN73NLiYeohP0SoIkgN1mgX7jvcB-wUpdb3gIOc7E2jG6_Y5EuDzXiFH_DK4NYnF5NhGHFk6Ag4b3h6B9CD274P4eRjLd584n_UKGGYScOAgtKbbk2IvQgWtzdFCi1jjU8nZ25jxi7G2-wmlxhji2y_P7JVrsVkFr5VZBeMKtPUuGEk4SjAYnXXwuYirpptsQR-vdfEMw9ctRp4qN0NYimwo357mt3H0ortSKybOWdMlPFPl2e05ZnZ5RnE-x7X6xuxS53cLEcFIGBh8fHeFb5hqE_SUqEFqObRgFLIksJ1wRWxmQ7g6q-pphP_HstqOskLqhUEXampFxgZ6UlmIdco6832Pmr62dJoWU4jjUb55st5BDxGqwBRAbH5z2Se6o86lvQf0ES9kqosUeaS9gT20tINv17aUcsdjbInbuEsbsya1FZBM6gWQRwCYgGwcTlusdGCcHCrwzCjDJZlFQavj5b0KpE4t_pyg6SBANJ4Yw9gCgkVsvS0TpO1WuCXoPuAdSwDc45o6qwJ3ypfCUvcB0bERLK7ZIOTlqOLbtbTF6NMLhPztr_ANyKwG3oZ9EIr6tZRxznBKzIAHsDnE8Rhw5vj7n_0ARQSF3ZRMwxijyNo-wnu9gLpaQ3uQcZW_FpyPGdrpgB03ZUhRPD8GWRdzBr-I_MdO768YK0RgrQvkGcGJOQtmCgFwqZn6-YS9D_1lYsWCMximTg7ZbHPoHGIsIYwelmdETSkgbxQcnQDGHjViFWiyUznUkH3zhRidkoADE0NUVVPhgoigyUbQbHhKGBPTiICvXGHV7uuepkITYD4Pvs0f58GHD-Tb-o9l8eXm52CK-YSv8CqFz4bGguQUmUPiTjIBPArY5hL-b9VD-SaBmijRQzdC4qT6JBBMR0FnNZVMYKr0uPCEevjGOYzEmXqYfBjLkYgiziH_FQXyzg2C6E2eho56OdqWgnmOuFkOeJ-3S-niFEire_ydBlIiZbeXfPqqGcsiiIKvwAApmVuxdCnGx2wrXDx8f1ciQcg0mxKXTrKZTK-QQP51i_VL2i4d7rUeIerHUm4QeTXwoj3TW0bNI0VJoJvrjorDx833nHE4m5sMAtNHEXymD5OSmLLprDuW2s8aBWAYTzJEPYdV84GBCU9jRlHDwdAPhs4jU3iBDRjDsX8rFcPjq75xr9bMgGCsvNw6UaqdKHZnlsSRU8xiiQMeIkOBIEc2aTMzmVB1HFkyl7ANTNZFYbkmsznKZzSfG_l_G52TokFIzdOaa0m6qb1Fl2-Jearl1lt-LM-fn9tXU5_tXeVfnduV2vY7P5L1xu36E-JaZTOUq8ShdICkewm3CJdh1IyCx92uZrFbiSkgcFCJ5y3V7d3c7Wjz8uNXbXJ5FWvUrTIKluPpQ_-9PWHMsawsnTpaxerxu_CD4RSoyBlcTGgubKEXbGGcbkExGWnMKfAVokuqeZHdJp7H2BGak21ccwX65hqLUiwg26pWNv6OUEigKVnEsMKGJCxozkKqARrDbqoLa4Cl5M2ZGERdURnPEYAEvnDQQNUrWo-94govtCFYqWRFPnKiKp1xsXoqqwC-eB4cxb1cw37p8M2PIGy8TgBo0M6vbJxO3Hi3wqk7iBq-qUTP7GHvIaLsaNDNnPRoWynvb0ygZVQHSNxbKRQ5BMyRUlFrGmb2lOCMxAz7xDY70odKENIEclZIUBk5Elgk3h3GOosBXsmNs8JAYM7OqrqjBBjFWkIkOOoUGh-ZpzFCqw2ZMZEWsquw2-k8X8QVToPtXBver0QInpC08g_16uCBIZP4dPjPiq0aOIVyOyIoSBtQL1WFkd6o6zHG7qjriHZRcv43zrUfN7N85ESeaEyjq5GIFIoKqGoKIrWoICziL8iTCZwPMjk8ie95Z8Rkk60acZE5HizKHblKcjaBaKWezy07P2dwy_8NxGIMFhRtARlMQHzwJx-AMXhAbllBSrdOJZG9dKSy1FZ60tDSiCnB9B1qUAxTJO0Cwl98XnBbtkLIW7D1GVHxVh9FqgG_uequAiWukZItCP4V7OnVG38-DpfcYjwFTtujG4raqqg9DHOxOAJn1GjTTqk4270SdpTuLcx6JEvofxoL_yVpUPOlGUkc3j-DEPSYwb5Fcb6kcQfjftCs6kDWx7mSJ56yRZQZIYqy-X_IToy0LJYfoFqlCUmEYiQ6bUpRxB87FwXT5ffYo7FEVKNTLzyKGxJBqGDaLGZQQp12C5YbB7DrD5S6OEXVU39DplQHAlB_zuyX45Z7jdM6w0pm_oO2x6O45QBXM1xhuDRinDerXYFC_BoPOwjhlUOXV2anBI25d1pRZb_cYNkdeyR8ngq1fWQO3NEJlkZ26_N-rYTG0awiPdg16dEuuhLpSjFs1Irs1OLD8nlFbiu1Utd-tGMLlFPB3juoxVFmD6mxRBeF0YPcqI_TrmtZ2XTmm_NKs7sdu5bns1bOoyhg_DBKKeQ2ZsFNDQulUDMpuRf52Pf4_e6csvWi7pTnOOUVV9Gqvaq6uaVq6dSWX2s7VZ5dQJfhmJFyXmsLTqcmtZw5q2ynqKPi659lU1vnV9_iaDhu9yopU3-L6ZZNB1eTxVuCgqVs9sk0l20jyWwgsXJG1biipD7qlJJmyNwd9oPy3D0TPiIh-meyWqXtTv-EsGaMYhboHpU2YUuThDaM-jjQ3Fkz6Z6XpNxcuW613GPI_DU25eu_wHH7nOifNzDffgDPn4vo_fvO9ipP0HpOdPmsGqZj-EjijdIbCA83ec0MamJkk18wQkzWhTyt5OQAayhsOCw2D7Ee14gefOMK-NG8kvgIzx3SVA3lvArLbxJSjf2kxzcfT1cmWc7Y0Vd9VfvrycdA8_hn4vyvn4q8=
Screenshots

3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked build code: link Combustion to Bear Trap, remove Added Fire Damage, and enable “enemy is ignited” for Hexblast. Trace the calculation that applies Combustion's fire resistance reduction and verify the result only changes when the supported skill can actually ignite; done means the effective DPS no longer increases in this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.