PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Tasalio, Cleansing Water calculates hybrid resists incorrectly

Open
#8,053 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

the fire resist on hybrid resistance mods only applies to the resist not included in the mod
Example: a ring with implicit 16% fire and lightning resist would result in +16% fire resist, +8% cold resist, and +16% lightning resist

What is the behaviour in Path of Building?

the fire resist on hybrid mods applies to both cold and lightning resist
example: Example: a ring with implicit 16% fire and lightning resist would result in +16% fire resist, +8% cold resist, and +24% lightning resist

How to reproduce the issue
  1. Add a piece of gear with hybrid resistance, one of which is fire
  2. Allocate Tasalio, Cleansing Water
Character build code
eNrtPWtz2ziSn0e_guWquy-RbbxJ5pK98tue2LFjO8kkX1IgCdqMKVIhKTvO1v73a4CURNKiLNny1O3ObG1lKKK7gW40-gWAfvO_PwexdauyPEqTt2t4A61ZKvHTIEqu3q59vNxfd9b-9x-9N2eyuD4Nt0dRrFv-0fvtjXm2YnWr4rdrLqAVMrtSxacxKfoN3g1lUlyrNDmR39PsIA3err1PE7VmeTIJomL8y49lnr-XA_V27URmchSobM2Sua-SYGfatHMdqbCQUQII1wDmFyo71t1vjYr0JA0AJJRxDvQGAHSR-jeqOMjS0RDYWrNuI3VXAh2dnJ2eX9bGFiX1sQFvv705i-W9yi4KWVg5_PN2bQtEJK_UrhzAv0BNxiMghW28wVzsIMQR5nhtcy7y9ijLi6dRuBgqFUyQyIYjuiDPMrUXhsovolu1k0XFzrVM_Gl_vAtvBizZsOeCn4ziIhrGkZ6tMTsbnRiHD8fSCXuZFjLePbuYgDIXbTAhOHMZZRTPx0uLCR7qgvwcFdfbMQj1Cb1o3KOrJCrUE5HP0ihPk2fwV0ftZHFnFMewVheCPVe5ym5lETWH1U07HXhR8iTpbWVKnoaljp7LIBrlJ6rIVD6hQzc6cU9kInfSfIH51ZBnKgMTUiyFcKH8FKzOsn0siXkchaoBSek80KUYqRBmDMdlG9RZoJ8lmdm7WBRuacJPG9A5GNjFIC_SUbwgZDE1chSL7nX0ow6J3U5V3lU_p2CEzyHYgESdE3iUTNnAwp1DsAHJSPcIb1NtEB4XjjFLe4dnUwkJrpWNIMExGINOX3V9n0e-jE_kz2gwGoCHuJQ3KqlxazPRrbBX10UCBq4L20FCdA55P8rUkxB30jh4GuK1TPMuTIop7ZyI0zA8hHhpy_dHEPXcT5DEfKsxgbOdbkAILPzXGvoo8Wvqg-cR_phkxl3UIpJ5XWiUc1i-OgjyYrUwzrSbygzU9ALN7-xKJVWPU2kR8EzzsI6V8q8PIHI8l4VazPhPWUH2XAFr4LqA51KdIV7GFkNoC0psEEKZ7YJrBt0k84h0CA1v2POwlhTaXqKyq_sLCOTjWjTbrQZ1-PHYduRwEVQj9zp-Xf6ELNbjLJEsxNyScvkss2Axv7bkmIxlNpnarkacKgZzNzAnc9Heq-K8gUQQERucdXogQJgsvxoSYhvOXKSJ-i2kdoDwYJIWmJxbmdd9mU3RfM0p4RdbtAoSCUAIVCvBQd1JWvpdp2jxcmhb2SAd1aILW3S7R8NFidAw7Y974zJDPVfByC-aIusU7jjh3I4h625nkexRNBhrHM_C7ZZEUUj_ZjcNrhYWnulkKYzm-C5GwyHYWa0VLQJiXpABmVVUj8HR48CnsLbrVg4jNi8aWbiHKfCDHsijUdbCvbQwHnRF5wZIrW7mFCCm0O0u7Ecn9ATM5wAcpSmrnKRBrX7R7Rr2IZ9eKDk2gAsm6WfpHQz-WpfO8uWgIZScho-dQ8lU8ut-YfoN8IU62EsCCEphNSzcRxtjVjeX0QBsap7vykJaQZWHfJJZJJOCmHJermTmXx_D7O_LOPbAGLxdq781v0wJcD-KC5XtwjvdqR5YmyLWFHXHbzaNq9RPR4NhmhVWLPMC4u50lBSHMr_WMbeNA-46COHA9wQjXGIuUBDA_z0PBSFGXDEIBw3quZLxAKZtp_y5My5blrQ8lxLh-DLwkUBYBFJJLoTncB8z18U2p7YjBSwBS_3UozmTWXE_LnKa8Zo3wE5eRIkp3oBljOM16-I6vdsKbjXDl2ka55PKqBwOVRI0aFxmSllybOd8LQszB_qHNYBRQ6BRLhwg808KqZ3ddyEx-1f_n8whwu5zTpEDv4hDnD6GqALDD045tvuMC041IKZun4G7IvqHjV27LzBybfglGEOizxyboH81ir5HgdYHK0mBPZP4urRPXYfhvs0Y63NNhNuMalyg5iDWJxQRGBx1SZ8ieO7bWJC-II7bd10b9zHnCIYBku1TQpirh05JnwjmYCDDHNQXlDGg61IOj8BR38EucGVTDGCOEH2b2tARaIALNGAC-wIh3aiZJ9jlAMwd4fQZc7VskAvjYsiFcRHdO_QHw8UuRhQGDWOBfjEGcC0hKhDTvFDO-8RFAvcF4wAOzzBY3Uj6mGIB3HMXxMFB2P1yRmAqtBgoYjAAhhjw6bgESDJGaL8UOUeMEPiXQivIB7jVPQEMJwKeEaHAAnAO8Bi7eqwMxMAFyLiaTqxHQIgw3Lg2dALJBcwsww6MycWir9vgNSRbMGAbQ3euC5LhVDMJak2FHgzMJEwo9IldwkBgCFhixIZRUMxgypjLsO4Ia5m4Je-0T5gNwuSMugJeC9vRYyZYix3mBJQLw_xhPV-MwAKFN0xrltZR0DFgCzs25vDGATEQ7sC0YTN5pQ4SQhzex4TrMTIIdkHKQvdNEPBOGHVAMNAAakNtLX2HAE-ucIEktkH4uoSvZw-BGEHzBIgOATSQQq62TbqCJbP7raaOJxEs2AIWYW3nhPBqU0QDlOvxtzcfz4_Nw2_XRTHMX29u3t3dbQxlcZ2G6ieEkht-OtgcAhKs5PX8JorjdU12cwv-t321t6t2frwfiL1gf_v8_f7A2ebf9vPP4clNfvhVHXxLv9xceL-2r7i7HlzdfKUH7pez8I_9-2_0JNo62M7fp871r9OvXz5vDU-H33bufn76-Z06mQgPyO_fwp1Q7myjH6GzvW6711vZ95Nvtz_owf63veKnUnfshPySo_MPV1d04CTfvh69L6JvR1--0tE-3XPzi5vgxx1y2cD5_Ru__yF3B1fD_POOu_c-vdr-8oV8us9u1_PBtu9_HYpB-jNl4vr7Wfh9-GVvEHO5Iz6eggHcOcwGdx8-HP3g25_2-e3H8Mg9-H0df8K32YV9J5KT7ZvR7dFI_fp4491mX2_4vX-7zr_-sXu5y7J32dcv4e_bf_xaL74HR9eMpDH9uX1u7_9xGx6kihTk5uDD1uHxh73j3eNU7u3k3_30Pbd_DNgf3u-f0Af6Zff4_vg23rXjq7dvzYRtjmfsTbkZlW-Wv3S8kkVg1kpnt6ktrfE-2hTrh_dpoXLdpl-Of7y50FOag1fLigM1yLfvIcDY1ylQqxxf2XINfaGK0lvWcd6uFdlIaS8YylGs338YyTjSrgXV3x6XW3tJmg0mJTogBa5Fh8Ilxcv7obbOW8fHZctWXFTEdHdjP1P6k2pAVlTTafPS7NdtTUe9I2M_N-OOEj8eBeooqWKviR-LpafHpvcqdU0pGPOUx6lOp5UcpolF1tqUJx3_9gbGVyEfxKknYzKlXfKNYc1eqYFegSeqkAGEIptHBXC1qVnbNPTgqcxCy1hGxzEmotBIzQazHh--_lGTfPWsgXbLSVhrjBCPmWzxbKITI65EDiofXvZiVd1srornybzvm7igzMKaXJcg9fa8zv3M5peSQtmNNe5ncTEsKAVd7SjKxKMtgElTm_VJw0sxPe6gMjalor7kattO0yL_M5aayRwgsdwpK18TkTfeT-TdePtSwh53YuleNlfM79koifLrQVXQnbBbfz3htv7ypZit9bE4q85CrO5naV54cZQ0rUn99YTV-ssXsxzTPv62Gi_po_HTDIeRz0mUQLzcGs6S3ns0GBgSBTgKz9ixxqw8aK1NzOy22qDMeF7Mw5v-ra4BAMCkRdf9_l0mdrnpm9ZMt0aZbFnJDER9GmqQhp2sv345S6l7sdLQMv2s2jHsKpjYQVXyaXDdapmw3Xr_Unw3u_nTVA4GequeF4IQtJDkz3VxW6WjvNSfmuRbLRPJt96_lOQn3axY4yZeay82FXMZ76f-KJ_lvNoQbR_Wbn-xmGzcj1V2tHpZHCV-pmSugvpZtlkiaQCmE8C2ZDrovZSAJt1Zuj9tpaoeX1BS26NM7wlNT7-2RdUCaIuo1fxSoqm6sap-_jQLdqjigSr-LJd5mbXCz-nLaZQ9efViMTb0YJkuVq9353IYBbvKl_ezdO3iLgqLrTCMI7_lJ7sAXiyK0x1ZtZ5WL4p_g3RjlexqhdpKAoiCVbexmQHUFsEMkJcShu7Kkklg6c5ezvScJtY7TeAkTUxZbO_nME7LQzF5Osr03qh5FTwc9VJmyWxoTHPiWkFGDe4nPdSFaUD0XqZBaInRkJstRdM0leNDmVWPF6ow9fWygq4fjdQMxFEyHBWGyNu1QZT737xRGJ6YIeZFZm7B7O3v7-1cHn3aq3an6yhm6N-S0cDTtyDK_463k2HGlFnVVj7y8vLx7dqnSN2ZgUCwLKM419zEsRzmarIva0rk1cjjiWOeSc1AHUaTayWzaU0Buint_VRZAfx-lpmfRapzXJP2RwZVdqjPqend_C5q-rJGN6Gycrujd9LNOboOSZnLMd1U9F2VTnZ04xzco8FQxp09V62PSKLQmySgoVEY-fogxPwp11sqJdQcuUyOAnfOd3VGqZuGuf3SRaBs7EYub7B0YVetc6Rqbs90SrVs7UavHHuHRpnGbuTJ0cw0ATF1UZlAzaH0Pk2MksOi2YpinXN0zizkJBOQboKnxbXKqrMWXZROwEaNQeYunCzyRkX3Mq5BzJGVOUbeISHd1o1ano_u4EG3zbFEjVPCHQKtw3STKg_WdhqyeahlXalTftVBtTlTUB3W7BB_2TpHCOMDqx38V81zFomxv1u3aRSUpxU7lksLbJ7BSPVm33PJmCOYzyfTPpP5fIr7scxvOue7au1G_1hEOqCZQaWMWRYiohfV8yjotfU8CpcQSBajTD2ZwHk7Epnins-PQSaHCGcij1vnWY7qbOGTKZQnIJ-Mbg5oPhnb2H9IJxRwMNcBTGDmrI9ilOyCMIo5a2NBUmZYsw3JlLulaJWucCanS1MsF3h1nWqeDShBHiEEvvxwTrS4GKXJOeNDJWN93TeNn0fwwbWx5xDTt0dGQ8g3x-ROZ8Xo03lYUHppkQPN6V2T58pQZ4szCHWP683mOKszZ1p1nlUdCL4oMl15-5Wmgy9v19axKJ-rA060OtQEMfduBDOXGY0b96QB_3i7Vt6nfGNKDtUJK_08OWDVTWCUq_LyarkxZjBqx6I0lfJIlChz6nOp945eW-db53u9z7CAr63LuyiLeztpJmPrHDS09zGJfoyUdbT72mLUcThXwkVuwJjvMOwI20fI9gIb-RxhX_qBYpJjxiQLpYclIwIFLla2S4jbMwMwonht2aRnns7Vj9cWt3uQ38SRD-vhtYV7r4hrFak1KHXR0q4K3mH9blf9LJQedu8VM0BVeGJB2qbH-8qxH6Iy_l_6pSkDltGUNi-9f_qZDAsV_OsVJlMAXR4xR_5roLnJ9iFXP5fJlbIy_e_bNbTB16ozZlU9oBOCPApBH4Vgj0LwRyHGF0hMRaulFU2l-Pj-6MPHvd55lCtdtwdjap1dpyqJfvZO0lxGvvUOUierjIt7ZZD52hIEV8_bMh_f8o5i9dpCGwwj3iuj6QoN5prYvXqAPQPLtlldCwW1Ayfg0iNYnyy2SYACm8gwQJI4rm3blHqEc0IChR3msxAh17f9AKCRQL7f1ELcqw4RQle96uzka-tg_Xz9vKafgrf00zHqIuPYmm4B1bWFuAAR1TY_tESMZjX475krZQpWnrKwjTZso6_WUGXVGd7eq1Jzx-rc1uBXZLZmd7y37q5BqhasluP0rlwbGNUHOr6tYplCB4CrpAUN4L7J9zV546ktT-l9jDKVDmZ08Z-1dOZA2I9CON3Lj8ywyWexvAK1B9-eFb2dSBcJlbU1GMWqqC8JBZofcMW4L1wWhIxjx_OpIyRxuU0d37EFcpQH1toNXSFcG8GScagUynY84jmNJeF0G2YytZhbMaRooLa5Bb5GB1ow84ejBEwz6B7RugGeUCVX4FK01tesNi7XTulSLV20s3REYE0_8QIUaF3pm0vmlUtn-IaG0deJyV_YuD-uobP0j87QP4gDIBSyDtM07J1lyh9leZpZB2AsbkFqY5tPbafT5iPBSV1VMaME28q3ketI5FBXECR9hkUYcAgiwtDhAZhzUErMFPVEwEmIQtuzqWJOgERTVWdbb7Dd69sN-w0DbNhvzOtGT-cv1uU1pKHXqVYwIur623slHGPrDIc97NZRjbmeGHEdhmhbruMXo3JtTesR3m1t5xnXHTCqMYBMlVrwB6vgbzu7iJ1lM8OcdzId_DcEzfn_5JW5PYjTLNKnXMAIw5SOlR1iGNKp7WBhnbq2e9JBni0YwxAbBw4NXBv7AXUUgwjF8zxfQkxkg-dHzMMqpKFkvu1inwQ2_IZQqhGr2FNtJ6genTS0G_UOZW4loMDlegCLixB6IWWZJWA-w5Ac6gjnPJVZ73QIodKFr4awvOqichnxghCHIDJJkKASgT1QjgzBo_meix2ubKnvQQUOCEkIjlzbC6m0mQ3GIuRNUTkzDcO21QrrUNMssEYsNI3sSl_Vs0W92biTqgXTeos-BDlu2QqC3MImc8E2sSY3lsf-TxsaXV7Me5Q1aIDw9A15bYaiG2WVeyw9gusWogy56p5OTD3dPAf7t7_TyA_VdDtL08DahiChtzVQxfV9XjzIgqkKfEdy7jseD6TreyoUJBQOlsgL7dCVHHya6zihHyocoNBR3PZtqSAPDgU4sXb-UQu2WDsLprO9CMxzw0Nhp0sxXzE2K0cmbDbhqSZx9B_uXmaphN1UiZOtg6Od3oUPUYHMxs7hAOjpvNeUpnVifFFIL4qj3Lj_RlTuMDDvvi08zoXyFPFsDyEOKamyQwT_SOygMJBIhjbXcQ4LIFHFioHaYK5IOyqvWbSazrRsvw5PMv09DTW-kpWbdHKUg_1qhC5mj8XEwyb-GX_oxapumZSFxRVN6SxhO7OEvaMPjEiIiMC3yrhYQMqw8liAGLM5C2H94dDxqC8cH3OpqI8lVYJQRphnB7YKmEtsBwLOINSumiGnWZRy6CJSxr1LCakOOFkIFLx7nZ8MIpAzLDAt5maEWE7CRLw921nxJCy8amZNgjtrEt5F-htPWsl3o1udcZoodzIV-xkEq-mgEed4hIGzdqmnAkq4qxgOhfD1VwoQxm7IHcE9l_mYMc_hYeCHjJBA2IIzsIw2a0wCeOWZk9D01qhHyEM5T5Wd2o0CzEAf4xnLFwJpvYxhBo8Gg1Giz8-DsTuMkgCQQ8hwMK3qL7kVhZrcuKxRwszGP5HRoMQmHdgaAnBfLvTCqDmf70_PT7aOYVUNtVjeZVFenzUupee7HKwUzAlkYGCTqCQu4wyWkvQlDbgHtgkSMMjibFtBusZIEBJBncBTrDlrVHSEXAe1KSQtD8cbAVd5Dqsr9FlEajNlgmfp-F4S6K9-WDDmrPg1Ve5tGevPZ9TFJCnDxHEdIZHyQs_nTCnEhPSwcAJObYjfQYeRD9JybAxqzvWj7waMwGrAzciUObOVm7KWcjvzjIgQ_5-MCCbzJRz5N3kU6zh0ImZdTb5MsyKN8kYWIJQvbKY8sB8YsiXl2gpTEC0DI0-IxyUXXKAwDMCsU-rBW-nYylfIZYpD4DUnC5gja3uerJk9o5L7ZzlJPKsqcyDBluxIfRqht5vJK_CZvn51oL1SrFO-cbJKMOvMVW2G7F4VGMJaFHj8Ywao1uJ6CBzYMAUMhT7DSnGCscckgcDX9xCYBwdyWlgXIac-ohDxSN8nHFwvZwjZIVFeeyOontZOLcf6dquKI9q7RKKeDI0PaJT5VCsAroo3rzB5WDys1eAp2iAPSvCYLVDxqeVgZeXdJIF_2a0kNmuDMQUVvYes__IuXb8oUggs2rmVsMHv-NQNCQ6JdCmDHEpBJBdS5jjS8aSNAhU6EEl4SMkwxH4I4YatwIUJGSreDuZqutPOreqpsp6maWZen6pqj3Favm4Gd41Uqyx7N2rQryh-NNEif8FEC_OZRTiIpsAn6NtU4DmuYfbMzoK1reKGQ8bU92wkXS_gQSh9JHxCbeb6LIS0G2J87qjQ17shRPoQdnIHe4gGlFEEibrrsG4t4a2C0CsqHu414BnVtLoNwWjDfWBEagDuBjXaUW9er9Sxe0dxnTnW-LOJk-KRPpBghVk6qD48YekDJa0yVuWxygg0SYvxRl0fAvn0l97fy_RHvMDqBn_XhTSbdmdh6ELG5Yfre-8SbS4sfZdqug0iup2t41A6dbYastPZGtB6-AkaHApzygLrkxTIZlL4kE8R8Mo48IitXE8EQQjqryCAd4QjKScuDcHDU9ysITt8trM9WNdb3vVQ3aZzt0waPpabvYijpICX0ZUqS1T44SrR1cvH904Yfuywhm42IzWVAcODVvR0z9I3dKaQrT34-gXEv7qq668jdR8Xan44KQajARZjcOZ9PD_Wp5vK-yjjq9C66SiYfm6zG2N6X3-Mwx9DMV98sba8-zzXGaGZa4tPCaBHCYDzaOOTJfDLlIXW2CSLsmld3Mlhu2-2RN8TQs_gf_yBqhXQmM2QWAFDYgUMPYnGLIbwMto1Sz3pCiRCVsXNMvpWXg1-ljxmrDbx7BGQpSnUlqv9tD7pqiaAr0Ab8ArWB17BONiSqlCbBv4sI0OeuybZCiS4vNuozT3GzxIAfa4AyDNX8XIDCO7HeccztLAMMJ5DYfbS5s-mIFblPPGqrMzyulnr-okmkj17LvlqlGoZ5svTk1ME8lRbSFdgUegzFyV7Jj5ejfyf7CuXVtoaw85iGDXdcBcdW81qP0Wq_Lm2ekXTwlZlXFYWWtOn2s3ajDyKqIvK9TkUT7NNZDWTsDJXsYqkjz2NpykWW0j4Nf3F7GnSX1G4wZ_top7v5MSy5mAKT59kPh52WBZ_ym-T6CtrMlAX5rraZ6XrmHl5p83cODOfLEmTMLqq7p6VP6rbZwZ_8sYqoiJWtc_S1MtGZ7H0lT5QrbJqsErfs6v-vOz48yU2msikA6H-12LHWLwbx5SyL6qvPbc-ktLZR_PvEdXwiMvmdOWn5sbfcn1pftr90MeEMF6HYwTGuDunozy6iuLT0FwRhvGZe84LjG8wOSGq_3SsPudimNvRZ2cuVBzWiPBHBjz5psAYw6GO8whO9deg0jg2lcy6kozVeKJ65SVM8-sfvTeb7b8Z_X8pOkD6
Screenshots

image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the supplied character build code in Path of Building and reproducing the hybrid resistance result after allocating Tasalio, Cleansing Water. Trace the resistance calculation entry point for hybrid mods and compare the displayed fire, cold, and lightning values with the in-game behavior described; done when the affected resistance is no longer applied to the wrong element.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.