PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Search allocated notables tag

Open
#8,009 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

We have a lot of conditional bonuses in poe, sometimes it is difficult to tell if you're maiming, intimidating, crushing etc.. this is especially annoying when looking at things like cluster jewels or any other gear that has many different conditional options since you can't tell at a glance how much of a benefit it would provide. (as in, using the 'replacing x item with this item will give you y% more dps' tooltip). Other use cases: finding overcapped resistances/excess attributes/counting charges

Describe the solution you'd like

Implement a tag that would highlight all allocated notables such as #allocated or *allocated. However formatted, this would allow for combination searches like "*allocated max rage" for example.

Describe alternatives you've considered

In the example of rage, there is a section in calcs to help you determine the maximum stacks you may have, but this is only helpful for buffs/effects that have been specifically implemented and also requires more work when these mechanics inevitably get changed (Such as the case of rage effect, which currently has a huge impact on certain builds, but has no calculation displayed). A more general display of what is enabled automatically (what pob considers 'always on') when you grab notables would also be an effective solution to this problem, albeit having a similar problem to the previous calcs topic.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the issue tracker's search function and trace how searches such as "max rage" are parsed and matched against allocated notables. Determine how an allocated tag should combine with existing searches, then verify that searches like "*allocated max rage" highlight the intended results without disrupting current search behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.