[3.25] Eternal Apple shield warcry trigger and related exert uptime calculations.

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

1. Pob is not calculating exert uptime correctly with warcries socketed in the eternal apple because it is counting warcry cast time. Warcries that are socketed in the Eternal Apple are instant triggered on meeting its trigger condition.

2. Pob currently assumes that warcries socketed in the Eternal Apple are used when their cooldown expires. While not the only way to use the Eternal Apple to trigger warcries, the majority of builds that use this item, automate warcry triggers by having 2 minimum endurance charges and a source of "gain an endurance charge every second" (Enduring Composure passive, warlords body suffix,). This results in a set sequential 3 second rotation of 3 socketed warcries, triggering 1 every second, provided your build has enough warcry cooldown recovery. Currently Pob does not have a way to track or allow a user to set how often they gain/lose endurance charges. Nor is there an easy way to override specific warcry cooldowns if you are also self casting warcries on the side.

Describe the solution you'd like

1. For pob to assume that warcries socketed in the Eternal Apple are instant cast, because they are triggered.

2. This one is harder. Maybe the simplest way is, when the Eternal Apple is equipped, for an checkbox to appear in the skill options labeled "Is a warcry socketed in the eternal apple triggered once every 3 seconds ?"
   -bonus points for warning text to appear when you do not have enough warcry cooldown recovery, "You do not have enough warcry cooldown recovery for this!"

Describe alternatives you've considered

I think it would be more work maybe, but pob could detect when you specifically have any source of "Gain an endurance charge every second" and the Eternal Apple equipped and perform the exert uptime calculation automatically. I personally think that users would benefit from a checkbox just to be more aware of how the shield works.

Additional context

The warcry is socketed in the Eternal apple, it should have no cast time, and its cooldown should somehow be set to 3 seconds if I am gaining/losing an endurance charge every second.

P.S. Side request: support for the bonus damage from the Echoes of Creation helmet for the number of exerts on an attack. It could just be a number count in the combat tab "How many exerts on each attack?" or it could just automatically apply and round down the average exert uptime calculations.

• Bonus bonus points you can also display somewhere, how much the helmet damages you for after your defenses depending on the number of exerts on each attack.

First time submitting to you guys thanks for all your work.

No source files, tests, or entry points are named. Start by tracing the Eternal Apple warcry and exert-uptime calculations, then determine how the requested trigger timing, cooldown recovery warning, and Echoes of Creation exert damage fit together; done requires agreed behavior for these separate requests and coverage for the resulting calculations.