PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Change misleading config text for Admonisher passive node
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
What is the wording in-game?
Triggering a warcry does not count as 'using' a warcry for when you use a Warcry, but it does count as warcrying for when you Warcry effects (e.g. Lead By Example, gain 5 Valour when you Warcry, if able Banner Mastery), and also as having Warcried Recently (e.g. Admonisher or
Deidbellow
)
What is the wording in Path of Building?
shows up in config after allocating Admonisher
Character build code
https://pobb.in/T_YWng4OWsB2
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the config entry after allocating Admonisher, using the linked build code, and compare its wording with the game's distinction between triggering and using or warcrying. Done means the Path of Building text no longer misleadingly describes the passive node's warcry condition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100