PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Minor error in flask charges used calculations

Open
#7,578 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

In-game when a writhing jar flask with base 16 charges per use (i.e. with local modifier roll "16% reduced charges per use" or higher) is used on a character that has at least 33% reduced flask charges used, 10 charges are consumed, meaning that the flask can be used 4 times at full charges. At 32% reduced flask charges used, 11 charges are consumed, and the flask can only be used 3 times at full charges.

What is the value from the calculation in Path of Building?

At 32% reduced flask charges used, POB states that the character uses 10 flask charges instead of 11 when hovering the flask.

The minimum value of reduced charges used to make the flask charges used for the writhing jar go from 11 to 10 is off by 1. In POB it is 32% when it is actually 33%.

How to reproduce the issue

To check the value in POB

  1. Equip a writhing jar with a base 16 charges per use to the character.
Item Class: Hybrid Flasks
Rarity: Unique
The Writhing Jar
Hallowed Hybrid Flask
--------
Recovers 470 (augmented) Life over 5 Seconds
Recovers 130 (augmented) Mana over 5 Seconds
Consumes 16 (augmented) of 40 Charges on use
Currently has 40 Charges
--------
Requirements:
Level: 60
--------
Item Level: 85
--------
19% reduced Charges per use
73% reduced Amount Recovered
Instant Recovery
2 Enemy Writhing Worms escape the Flask when used
Writhing Worms are destroyed when Hit
--------
To achieve godhood, they would cast off all that god has gifted us.
Mortality, compassion, even the sanctity of flesh.
 - High Templar Voll
--------
Right click to drink. Can only hold charges while in belt. Refills as you kill monsters.
  1. Get a total of 32% reduced flask charges used.
  2. Hover over the flask when it is equipped. Tooltip states 10 charges per use when it is actually 11.

To verify the value in game

  1. Get 2 belts with 17% and 18% reduced charges used.
  2. Get a Writhing Jar flask (in theory any flask should work) with 16 charges per use on the tooltip.
  3. Allocate the 2 sources of reduced flask charges used on the passive tree: Careful Conservationist and the small passive in Natural Remedies.
  4. Swap between the belts and use the flasks. Check the difference in flask charges remaining.

Note: the devs hate the worms so the flask doesn't refill in your hideout, you will need to use the ryslatha pantheon or other charge generation to fill the flask

Character build code
https://pobb.in/shLIueqEd5BY

Change the flask charges used roll on the belt (between 17 and 18%) to observe the difference.
Screenshots

https://youtu.be/qo041C4pweI

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the tooltip with the linked build code, a Writhing Jar with 16 charges per use, and 32% versus 33% reduced charges used. Compare Path of Building's result with the in-game behavior; done means the threshold and displayed charges match at both values.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.