PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Missing Damage: Ice Trap + Slavedriver's Hand + Frost Walker (% inc cast speed with cold skills)

Open
#7,533 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

Ice Trap is a cold trap skill.
Slavedriver's makes trap skills enjoy Cast Speed as Trap Throwing Speed.
Frost Walker gives increased cast speed with cold skills.

Therefore Frost Walker's cast speed should be reflected in Ice Trap's DPS when using Slavedriver's.

Note that I have checked the tooltip cast time in-game and it does go down when taking Frost Walker.

What is the value from the calculation in Path of Building?

In POB, the cast speed is not factored in. It seems POB is not coded for Slavedriver's use with "specific" cast speed mods. Generic cast speed mods do work.

How to reproduce the issue

Ice Trap main skill, equip slavedriver's hand, hover over Frost Walker. Remove slavedriver's hand, hover, damage hasn't changed.

Character build code
eNqtW21z4jgS_jz8ChVVe7VblwRsYwi5ZLfIe6qSSRaS2dtPU8IW4IuwWFsmYa_uv1-3ZIPDIMcGMlWMsfppdbdare62Of3tfcrJnEVxIMKzunXUrBMWesIPwvFZ_eX5-vC4_tuvtdMnKiePo_Mk4Djya-3LqbomnM0ZB1y7TiSNxkx-y1g534HVjIZywkT4QP8johvhn9W_ipDVyZCGfiCzbx6ncfyVTtlZ_Y9AepM6obHHQv9idT8lnNCIepJF9zhtL5HiQfgwKqMERqc0CAfCe2XyJhLJDKSqk3nA3jTN3cPTY_85J1IQ5kUClb6cPnG6YNFAUkli-Dir98AydMxuAwmsKE-Aj93pOkeW7dYbhZDzJIrlJZ3CZWnoYMaYv6S2jpz8nwn0HNHZ8yQSb7Auz8F0NVvzqGOc6SliV6MR82QwZxdRIC8mNPRWUCOuKu1DwmUw4wGLcmoZEbc_MLeaTaPeQlJ--TRY0jodu3VktdO_TjFOrBbUOAP44uScw5JsMQti78ZhINmW4CcRxCLcQb881KjiRcI5-E0p2j6LWTSnMvgolpm3mA6DcCvr9SJGH0faQ_vUD5L4gcmIxTkn6pqwDzSkFyIusb5I-cQiiDSyEmDAPAHBqeocFZH3wYh9oLTtItJKiqSADeLY3aMyQSc3Y0W1rgZl6Soz3k6gPkTocpQDkfCSlHIV75yWieqSvecCXde87_7KU3aPTYR34Uo0q2UX8MtTto_N8s0F7vbP9VUx5-r2aXUouO2jbrNpt7quY7fNx9BkEQce5Q_0PZgmU4j_z_SVrSZ03I7ZA8cTGULsMmHtllGx6yBiW8AuBPeNsI5RUjjSRGzCWW6raI_lxOoUZA3eCRLfhV65rf8SRiqW55KNAv6I6MOGwrxmyFlZyGqSdF-WOdT1XGMWphMuyil0z5g3uYH0r08lKxeUV2o4xZZF4lKWRcJNljXz_4ioYCYEbjYTnK5FoIqGugpZNF4MJgHjubzUKkWfiXZBZ2WgytZ5fCmbf5ywkt_koRXN8geN_HIHS1WZ5jTOB1zHHOy1vTR9OfdkkMoCwGdrOXbHMVcJ4j9YI_CKuF40FUlU4phEHTRxKRWy40KXVX3mJ1658-mcQ1m4Jn6RVJxXQvSkpN7rpfDHrNIklRDLek1BB8lsBoEDV78sAzz1IIcPcgnMYav1OfUj-G5-EzeLzsf1Cezu59SlJ1ie-eXVWIOU1wUP7fVp2mXIS0-xXNAHiA5TiPyq_H8QuUhrXBwo20rVYIqwZC34JN5A8gl2ceJq1JDcrEKWUZSIhX8vSvP_QF5qgqvQTyLcCqXnWEdsmgZbKhw22iWVlPhpRvyNRgENpa1aTDGjkTe5h6W_ppwPIRKc1fN38dsa0MrW9rSh2mh4dTediUgS9o7_PdFILs7qI8pjpgnVHeATyyBUNTiEHc7rZDARbz1_jlo8C8HjDETobMZC_wOP54gxQrMg4qEQSkf8QqY0lnBIaa-MUehcE-7ORzOSUIAAkGRYx60Du9Oy3AO31Wp1Do67reMDC2qO5oFjdyz4bLst-8DpuO0uEHbtLoxaNtK0XbyDn27HbrcOji3HBZDTcg9aUC3Ap9PtALLdUabFOo5Gi95HUcIANJegTa7baLfSRiISOEqxL6cv_Xt18WUi5Sw-aTTe3t6OZlROxIi9w7l25IlpYwYgMMlh_BpwfohsGz34Ox8_9K7653_Sdy_oXiy80TF9nM_uz4f914hd2PfD3nwUn3-_HfHpfPp-JV8XHqDOztTEjWzmU92RjBv6G0aHKAArau9qoOmVH-Da4MVXIVmMY3gz-3I6QNFiEoNr3LBpfL6AHX2NmctamyVdXKQeMKndM4_JWqU-G9GE4_3fE8oD9LVm_u69buuGIpouqzNgBb6GB4_m-LyYoTP07u_1SI_LlBlOlzmedrBUIBL4mdOlN1XTtreS-oJyL1ZyB6HHEx-KmjTYpavO6RAlwy41ViN-vvmb47Oc5sspSJMS33AxpNzOIGnv2gbNx2yKbvPAJPVhozfuJKjQQD0aih1c3cEGi3RcV3sY6Zf3lOt8uPNXzq7pNY5fahPXP0hkZRKt6eSJJNSLGNJpumVhAqJmSB1Ky5c6U2pm5VDaZfBS2VRR3IWzRCpmZ_VpEHvfh8lohO1x0EBGquV_dX19dfF89-0qjX95iNLye5hMh9jP1f-vTqkBU9kYiZNhrC_P6t8C9qYEuQTLBjxGnTins5gtI5PyiVRyDrgCbooKSuisrb6Z14rAzOnqnUUQSMeQyXtRwIxyLcc_EUpPiFm-bsFv5oZdZzMjnUVeQBjWVYjBUuoZgZkLdt2N6uBgARaOIMqNM6ejn1hCYlQATw1GgYdHbfGSYwzRVAV28Tw4pb1FwXqnKbCZh2rjmxjoQTNYt-JN6HS0wKrqMYDRqnrUDL9kHjXqrgfN4GVhK0L1DGszlyVVAaevIlRODpumF3BMV40re8XZksTM8FFOWJRmGyZODxCjMpLCjRMFw0Sat3GOosBWqt9msBCOmaG6oWTQAccKItGHFovBoHkaMyvdljAGsiKoLl2M9ksLoYIlSCt-g_n1aIERsr6HQf90uGCTqPjbm4vA18WwYbuskRUFDEjbdmejKvzd2ayX_LtzvIZM-dW43umoGf4iA8xoNnDRmUspJripduOAe2s3Dv31RGKF7RenEMsqcyM4Gy3a-GnxuTUHXSJvDVcV_NZoFb4hm2WgQWH8XtIUuLdMwkswhixw7ZKslFib48BKu0q89Em2UdPKHPX-TJ8AFW1hTfIJIziKbwuSvXKcll2oW0Y5vnYg-G4Mf3jStZOeQsY09C-xjb6jotiFT2bALJPscVO2vlrSda6njayOUn0UrGzSJs9ARliQ_i3E9E98bON2j9yu46avOKj7aT19nNbQkPFeBmD4SDlMNisS_ht7psDg2O123Gbb6tj6CcCpqkjT-h6vs_I-iZl-2v0HozMRqttYKOviDQjzNXcfSle5OCEvX-9-f7mqDTidMz8CjtE_ABz_Kya3YKBabzpM4gl5CKSMa-nhe0Icq5V9Oadx9vg_4OyEWDWdohCdo5yQdruWT1p-pL9ndJzA1V0IyT2yrKW9gxNiN2tpz-SE3ByqfzVlvz7764S03BoUIjzwAhxv1v4LMXTMTppH7v_--bPTPGw1fyFSkEv2Lhkqmyf42W42wbrNX37C7kLEQCqfpCoRUJx80GINeeggLsKHDoDCEpxkr10RVZTV0ibN2yTwJkTimCKLCb40QPC0g2ljyahPxIjg2ZWfIkUnKNNwkSInsEDkZwuk_ig0viCDTPTurd2lA7HSYvlgJEZLYEGpBSSwZQTpzWZ8gQObVLCaP-FLduCVSDGGkgA4kuVRdUD0mUNERNTxQfRBATozpFygTAvI9VLxgxgugvEYHF0ppXix6UJ1Lh6E30ftibIBvq_m1lNnTXsbRgr7UwrnU4rWpxTupxTtNN6oftFyx2Gjy7QtP3bAuJAEqr_p0_Clf48xRPdZNIZgE0zqxlQzE8UEOWdckt5wEceUE719iF0Bn025zsOtzsPeAw-LDN7AO9cYtfegUHsPClXhcS7gCFtn4FRgcMsgAflhbXf1ja3MsGlN3D2sibUHHq2KBtmXT-5jk1XhoSqaSlbf6IH2jv7jVBa5ygLdcDFn8S5usnnXtCtzqKymtbOaVda2N004k3twQWcPYdHZWfVWZXNX8eM-5jn2toGvsnIrgLXVFnUrG2P3Y8XemcPuMrR2jW2tfcV2p5Ik_oLoRuf-45a7r9Pa2o9G9q5LVDmD2jm0tPejubuzIE7ViGXtamxrD7F9b3vK3c86tHfMX3bPRnbNoPa0FZ19hYa9MdqmtNjOFvvyyT0txdZ7ZEdP2tvpYO8hUOyDh7UvhfYWtX5kpHs-2cs2qjur3rUR4SgYZ68bemwiuM-idAqGva_0R57Z2zOd_Fv-m-jzP7nMQK4REgfjgD-OVHNuIKl6QLX-ok7BRNmbNRnE-US4bB8up7CL6dM3twXnqqGWN0Mx8OOr3zlcMWz5YDmjb5sB0-VvVfH3l9iyHKgXcvAlrAHjo5yWbvZEIF3t08b676P_D8CAgHs=
Screenshots

see generic cast speed reflected in trap speed:
image

see specific cast speed not reflected in trap speed:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by importing the supplied character build code and reproducing the Ice Trap DPS comparison with and without Slavedriver's Hand and Frost Walker. Trace the calculation path for generic versus specific cast-speed modifiers; done means Frost Walker's cold-skill cast speed changes Ice Trap DPS when Slavedriver's Hand is equipped, without changing the generic cast-speed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.