PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Born in the Shadows damage reduction incorrectly applies to Righteous Fire's self degen

Open
#7,525 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

I noticed I was losing life in hideout after activating RF while the POB Net Life Recovery was positive (+88 per second).

What is the value from the calculation in Path of Building?

POB shows a +88.4 Net Life Recovery while Born in the Shadows is allocated
When removed, Net Life Recovery is -7.0
The 15% reduced damage taken from blinded enemies is applied to the RF degen

How to reproduce the issue
  1. Select Righteous Fire
  2. Allocate the Saboteur Born in the Shadows passive
  3. Notice how the Total Degen / Net Life Recovery varies
Character build code
eNrtPWt32zayn6tfweNz9n6JYhNPArnJ7pHfbuLE9SNp-qUHJEGLNUWqJGXH7dn_fgckJZGSSEt-5G53t2lTCZgZAIPBvPDQ2398G0XWrU6zMInfbaFte8vSsZf4YXz9buvq8vC12PrH33tvz1Q-_BTsTsLI1Py998Pb4rMV6VsdvdsSdMvKVXqt889TUuRXIDVWcT7USXyqfkvSo8R_t_UxifWW5arYD_N3W4MoTNWW5UUqyz6qkX63dTFUfnK3ZanM07G_V6tQbpLrSQrQQ5UqL9fpB9P4YJInp4kPEIGKMqA9UmF8kXg3Oj9Kk8kYBoW2rNtQ35VQJ6dnn84va10L43rXYGg_vD2L1L1OL3KVWxn8Bf0EDqlrfRzmQEpFE6BDbMGFvY1sxBzh8K2dTszdSZrl-2oEHzelcDHW2p8h4W1HtkFC95rAaFu0kr1M1fhymCZ3MJ-X4WjeLXubMEExlkTaXKAu_L0kiWC24vmQtglvbfEs1QdBoL08vNV7aZjvDVXszdt17G3HxqwN-3EYp5MoD8dRqNMZFt0GaW3n4EIbyLZbOZDkKto_u5jDSmELAvQdTiki3XjJXJRaW_gS5sPdCGb0Ea0Y3JPrOMz1I5HPkjBL4ieMr47aOsS9SRSBBK4Fe64znd6qPGx2q512MnLD-FHcG6RafQpKcT1XfjjJTnWe6my-DtswT1Ws9pJsPrtCdIGe6RQUXd7AsB9AuNBeArpxExTTxoaYH8JArw-50TgqhE1787hxHFysC7eaMObbiBJH2oJK7pBO9Ed07xxMwnqQF8kkWhMyn6s7xHj7evq9AUlbIff1txoY6SDYgLRbTdVJXGMwlR0E65CIofYe3iZGMTzMnEI9HRyf1cyIZNuc2Q5oBkZaV-vZ8D4LPRWdqm_haDICU3GpbnTN9mHWIb3XwzwGPdeGLB3SqlEOw1Q_Bm8PjHMbHohyu90cqiRrQ8QI8a41OgfsYCV4Kd4bA30Se_NpYF10r-K00P51Vwjcky6Uc1iFxvtyI702zryZajXP1TjapgLN_u1u-FrHVev3MwIcyy6kD1p7wyPwXc9VrtfT6zUJdjpZbYDrrO6kuoLTiK2HsMgzvI0w4tR2CGM2Rl1EVvMMO104G7LsINbp9f3FMNTRfGjEQevAT3u2p8broBZcr-PXud_usTZbXMWQtQa3IV--qNRfz05t2KfSETQ4M1hG7W0T7bBOnI86P2-gIcS2KUbtnAOM2cqreV4PIs1Ebw2RA_ClCVpjYm5VVrdLSNJuvVgh1CWGtQYspxrCA8Dw9WLc0m7H0uQ3E4RFG-IN0lEymXsLDItu8S_h11I7U9NaBsjn2p94DVve7pjsRhDpLw6BdfQrilahtPZskOfKu9lP_Gu9LkrRyEYYs6i4QL2YjMegUI0MLBCQZBvTLi8BAqSw5h-2r7I58CdYynWlZnd5Ewv0272xOfDa9Gcu0tqDWMBYbAl1-jcLrbxGbA3wtQczm9FTUJUjMIlFXuY0qadm2v2oQ4iJ1wpwC8A1A-2z5A46PzRJumwzaHAF5zavtSupjv-4X5t-A3ytBg5if5Ka5bB2G4sYq5oxma8IFtu-ypXlVzHEZ5WGKs6xkSEr0yr1hh9g9g9VFLmgDd5t1UvNtwVENBW-tztFltR8OhmNkzS3IpXlA89LJnF-rLIhiDd3kKuZ9nyONaKIUh3YFPnC8cBt8m1KkBdoSbcK1HOtohHMzt6Wpb8Zgmcqze9nqU8DsjfNjpb0A-wRKV0_oK7m0nV87ElfIqEcipWnA0UCz9GkdE3fFuRgOFkexkWexaRooy3rYpjcDfxbw8zLJImyWYtqPNaxP_1a0LhMtbbUVJ95hhcFq80XawQ9BN-hXB9A5k8Iu5jTZ-DB0n_2_2QmJ9OnjCAHvhGBCesTiik23xiEZ30shaniNnLsPiKYm29YSkn6yBHMACKI1XlfAOQ_G3nkE9_MuxUnMD6TfcU26yMb4PpYCCb7ZeNMcigXgpA-IY6AgqKH1EaoTwRwrs8h0OtjSh3c54gzA0eQ3SfYlqiPsMC0z6mgUEsxh_4Xo3AktvucIPjIkRSo7yDC-zAYp18OjCNBaJ9xiK_6SDIb9amUjuiDTNikD32lHBqSQvaR4EAFPGtK-tA8dMimtiFAkQRi2PRZMgbgNnUQkMQSaguGMQ6D6TPGoJxwAGGAD4OBtoG1tkAYCAhJoSXDEEINCJbwF9DC0LLDDZ-YQ4EBNoeJQ5TjvjTF0Atq96G3wjAKSfhcsJJwwQTMInMAxpGm_xj3sWOaRxybJrlhA5UEICgTMCLKIT41LIHeUoaB0xQCCJgEbsNsOZKbz8gGpkvBUR9DsMkMd6HnwExgKadAFwO6mR0JDEQSvgFfnLIY-s9s6FYpK8QGVOgX9Ax4gaXpDEPQdMF7CdELNGHDiIBFzBAwDKCUA6dBDgx7QPY4wFABI8WUAEwhksSG9d1HDCHHjAw7ACNMOTITjEB8oJwYPoKQ9AWEStAvEDejYEwKSaX3g6YA21tWDgusts0CLkG5gWKqebHWfnh7df6h-PDDMM_H2Zudnbu7u-2xyodJoL-B67ftJaOdMSDBKn2d3YRR9NqQ3RnAP7vXX_e9n3-W72_Q3URefOQfr8Lrr2fk283V2e_s-ujoaByMzvY_Xw-Z_PLHyddfr1Jn75fP7vHtPo5_PfGPXg9G0debj-Jr6n48uMvv_kjIIdrdG55e3brfRu_5rz_fchpf8vfnZFfexvwudffkzeX-zW9fPx9-_nB1dX_68doO7I-Dq-xU3F98Pv78IaL79z99Hb3Xd1-T49HnD9nx4W-__n588O33s91vLNvbl1c3AzKgzumnnPz8LXP2vx78onTyxebx-ws3_3x9LPPkklAqvMOjA9fOfz5E53dXo-PwPPgRu7Z3dPXH8a7i345_PMm_XESHtstYkJ2O33-Ww9fZ8dVY7wln3z3d__IFOfuXIj74SXy5vT8e_PKjPdh1Dg7RCdEi--Vw6L3__OVukoY_2X_Yr7P3J0fjQ3HzRfgXN--KydmZzs7bcp8qK6eq-lYoqGIujUbYssJcj8zXKs-zDFdohTkcaoMrFMQcrjKB0J16L94aHycNQUWWBnLHqO3ClBm9bj58THJdwJrC6Ze3F0aGMisDm3SkR9nuPTglhyZMWkjDV4bBQF_ovLSwdZx3W3k60cakBmoSmfKfJioKjZGz66Ufyo3HOElHs5QckAI7ZfznkuLl_dho-sGHD2XNIMorYqa5qdEqjVPVISv0pwarKiz2EwfzXu-pyMuKfoexF02AtXHlr0FvwsgYYdf0zOyjmtSTPx1RFiUm2NZqnMQW2lqkW2JXMwf9q9CPosRVEZ7SLkcN2NflJJ7qXPngu-ycwKxmO2ZcOwU5-LQLPorZpTNOT-GXGIR5YbHqm0W_11hdfTYA-yXXtxpdQtNxLQyz8G2q7sZqVPkApg2raGSnfYglgekYZfcgZ7MM8Vzin6rr0GsOdFZcgdZGXJXUMV9u6IM0Ta6LOG5nzdmVa03v5zAvutkY9bxwNth50cuNcdbGTKWY1h9eRQWZR60j6OWtCQJefBWdgaCoqMHkadGMxdOCl2Nw1cKaEsTWXDp74I1_ivc1-AWNAdbKWxdPA_flBm6asUBhlg39pcRrvWV8GMFY9yFWa8xArXTG-FrZy_G7aMQqWvluzK5sIrYu7owVekGez41GOlmhPWel7SZjjveCxnLWyHebgmMdjXT-NN6LteR9X-c6HVXphQb3F2pmrF8ofzm-NxvakPfoX57z5yZfqpNJZrK_Dc4v1Mw4v1D-cpyfNWQVLf0lxL7g0mkYg6wsyMFmBuBiMhoVJHKQPjfJs8bUrKid66Sl0lp3ip683IyV_bLaulDvnNkM-GtpMmetiTtWeVpuks9ma1o0m6JpwctNRNXCd-PvblLM9cs7RgffMhVfT4w6bmqrZsWM1c3il2N4o52dZ_ZL9qKJSZAvhe218naPvI77gh552UwRzWfPzgBDdRD7oEX0_Lj0jA1Lta3MWEHn5VhiGrNU7FumOatq79lFYwhLrikUpqRdHEr4FxSEooHvHiV8D9V-mCZZ7oYLiqdWOg_K5mUvGJTNGtl51mGaE_Lm3AWw9ibWWdPzWK6cDXqQZWbrIM5OVXrzormzqqH_ganP_jezivaelweD1FNxmEFkBwu4wYCFmnm-1HyfLbuXTByW7VtlB75TPLKb-PfW9KzP0kpDa3nFZhv5se6wOQu0pzJP-XrJCi7VzTNwizWzacF2rVNFauyZHWEdZqPQezC5_Tidn8TmQGUKroZf7pk3l-hSdbs1WEHpBU1DrTWrau6_nsL38hQWr2Y1mDKt6OTHHPsF1Vt5nsR_IUfyJPZSrTLtT-3YCiFpgWllTSvNl-PSrElr2uZLSc3S4C7yNLzRWTfHKqD1WTaj-l15Nm11yYhWHy90Xmxyl9vY5mNhvwqIk3g8yQvy77ZGYeb96k6CwFwmhdECWXNR9uDw8GDv8uTzQXWsrI5ScOTXeDJyzSXE8v_moEYJeaGLo65WNnGz8qPZTdN3RUf2YcLCKDPjjCJYJHp20qrYp656Hs2060pqBdRxOLt9uprWHKCd0sE3neYw3i8q9dJQt_ZrVv9Ap8oGzWHy8gLqamrmpmQ7ofKArtklKg-7t3CquBbbTsXISetwTGUH7slorKLWlqvaBziRm5MKILthEHrmBGP3lJtzDSVUB188b5Iq775jvqvTxe00iqunbQTKynbk8vpoG3ZV28HV4upqK1fL2nb0fe2p1rGXle3Is_sTSVzc-F5NZQbVQeljEhdCDotmEEbmIHDrzB5EegbSTvBTPtRpdXqyjdIp6KgpSOfCSUN3krcv4xpEB6-KO18tHDJ17ajlFaaWMZi6Dk3UuMrTwtA6TDup8vZLqyLrQi0Phbfyrzpi3jEFVZTVwv6ytoMJ05slLeOvqjsWSaF_B7dJ6Jf3DFqWywJYl8JIvJunkykuTzydzOJtiqdTPIxUdtM631VtO_pVHhovZwWV0ptZi4hZVE-jYNbW0yicLzoSc9zzbhdidnh_JfK0tmvhV2f6H02hvHnwaPTiYsSjsQv1DR6uhhF06u8ZTId455N4H5iRd4j2mqSKbq3WA_PRbUSrtGQrR7oxxXJ9VteQu5ZwCfIAITDFxx3O3nqUZvd7jrWKzFMZSfQ0gkvXrZ80ziTPVOwXNy-fOFBz2XMyBmLTnn1a5a3Pp3SR6tudaRxV3AsxkU11dwYiMpOD_CNJRl8hSsVymyLGbAcjhmhZXp3xxdW5XvB490NgfFoIzLRVA_jzu63XmKBtxASVCAkuykucb4tAtzpzbD5PjxxPMl2-0VBuKhTF002EAql-Dvgcwt_8_o119fHkp6uD3pHJxlom0oQOjHqfwzT0ITy2ftR3OupdxeHvE22d7L-xmOMTDzkaMxY4HCGlEXIQdTzGuKtYQBwdYPOuhOdy6DLizLZ95UrbJlwLjHpFRwomvLEc1vsQjkKTT8uTNxbpQWARhR5I8hvL7iH2N5PtraJecCXN6pulCqyxTq2FbpsoGGLYcxVDfWr-Ni__sK1q4NXhb9ODJk_wOjyBiGkE7v0yS4iUge-oQGkbYSFdjAKbIK4E1cqTUpFAU59K5jFMHCjWiivpKao8zT0v2IQlr5y_QbGloqjGj9IlM0oue06mkCcxRfu-4gGIio2Q59o-Qr4g8BfXQUC4IwgTNgVuSKSEFEpjiYhnM98LPK4RCxpM4eJfhSm0yZTzwflB7yKJrL10koGJ6H0Gc2NdeHqcp7ohI8hHWhHMbRFIIh3XJZjazKHU9R3MJGgJoX2mle9pjwWIYsWl5zAFfMHKw00ZEb3qyL8ZfnXR4Y119Pr89XmvgDnXvxdcq_EJ9ajdtZ56WNarzfmWac3A9zNLMMNkRPlyFbVNlUPrNaak8FWzHucNws3slVUG7FaQpFP4P71UBTDX_6ROHbGonba7zvx1QOAHIciDEPRBCPYgBG-XNLZC0i71aKyz3DoEew_CNhjpfHgP38_he13aPO5J4TMX9K4KHJ8hm3ocecrxXA-70vEpgsUZOAEGEEc6SoGqZi73HSKZ7XmL0jaXKeY0ZeoVxsXiK-4T1xZd7xVxChGAdRBf58PeK0QKAaoCOOtcmaQbFBelo9JTsIwX33tFaUHTnJprkKSsKJ9dka5XzoTmFbPrFE1k8W8mLR0QTrs88ZXq_LjQ32ma3PWOEpUPQ19b5THxXjVTbyxhTz_vwkKsnkMJIw3KZxvVxY4KrX3Pd2yPMttnGIPfY3PJsaKO8H3Q-J7Q0rcdBQ4DBrvg2cQO3MBhnusK22-KndOi5I7gv92aSMoFa4BpU_Cos0rucClLhcaqiRGyQUkmgTV9vGGqzfaSGHzE0gA1FOC5DkyqOrMAc1H_Fe9YWGUyV6fZv5AYrhIQpykgp4Ojk72eiQlSkAYz5dZ-eGs2-MySsopw2nDqIM7TZHxflwOuEPelcojGlGOQBBH4ngBPGHwkpF1iM6w0t12XenYQgPEjrsaC-wHFWnO54BDhuhzUrJvdnHdK_mal5pENmKPByGyhWNWjLtrvgfKpm5Lpay-W2cvtsXLKZ4VqbN5W9K2T2AhFHt0XTg9M8cloNImhI6XCM6cUjNVCpLrXmllhYJxw37qDSl2CQOMrsCFe13_obvTDNPlDx38p3bVKrERTrD5-Oj8dfOgdg7eW3MFYjcYvhanhPXpCuBzMFQdhIQQx1_OZ4wXUJdoh1PdcqQXxNdVaBA7xJPglinnECzARWDW9R-qsliCKmxK0uv9yhR0-D4Pc2lUxLP8wnxhfZtnjA1mn0jNKToCbixn4fwRDeORID1M_8LGLPU4EEeAXisCVQkKcBxpSeQyBZZaNIRC-UhmeNxQhXvD3EO_09xCqVxfGtu7UYSOnWNas7VItoUu1NbdP1MmXStAqtqx6pOGIFhJQvDuky7yP0dH_CR4esleI1l6SjjNwexKV9spng1cJl-aOsiFeEm6gvYCBNSUBIshxqAbfz4YV4iIVQBhFMBI-CWxYHdghwne5JoSThnAxulq4aqJFcFO0jNfXIVqEtzruNdlyWmSrDDRwSzSBGnJl8oXWNGFortQdxHoU6uwvrzYRWmWO95XrRjqdnhz8aRJ6N1kYgdmaG-R8qK1j1ZQXZpwxFoBYsEBqSbBGLoZw1EVC2Yi7oHQUEZ6J0n3uc5AmVzHtyMDWSDiLWRvUok8XLDIWc4s8naIebhhiXaQce404b_q6UKksLH9iTiNU563-Xx0khFeasqVJqDMenF1JuK2oL4Hljs2JJJqAHQuY53kce7YfBGAlAkolpR44Sy4s6EAJBg4zlc2FKlv4vo4ZQ2SVPJ1FxpUPJtFq324A_sttWE5cbVCB9InyCCIS3Dpw9rHtEewHjkn1aOQrjxLue5Kah3m0xzwtwPxhBUZP2r5WbjO3Y6_n30GkWfjUVVxXbUuscq6KTXwjM8a9ki3e1RRopW8HAdFkbJz94jJ9Jx1VyCV8de8X8Z5JB62czVV5qF0Ty-UJzOJ7rce9fQ28g3Du1IjkLJjD4Eq0RnMYS9krt5itco8ZlL3t9Oq7zstYxJasLh7IFtrGKJAuqBbtaA-7CmFOSQCi7_oCOZR4BCI-avtCmULw8ChxGAbPhwq8mA-diQeuWydrF_4c1QXGaQrMn4F5MmqSmpwAAo_DKxNNxpJU26dNy_RKyKXEwSuMVqYi-AoHZvaMt9FV0Asde_dmEZWnr2oJCtpIUDTY_dc3W2xlmmFfQ_wLDgKEweXnmzC2iktXNckE_7VVMs17T81Ug-8KGweBHXBj0HyXBq7PFBIu5dpntlYYK9cWBKSP2lgT5DFbBQ4Dvat0M8NFZVuqAf7U3SC8EDGUoCACR8WODMhIdUCw1AcFooVYcRi0h5yGw72QkGhudjRtIKDWK4vjttNfOZhCdKAv6C9oc4asyq795aWOr_Kkh-FIp6EHHB71Po1XR2lc-Fz5LHBAhggIlQIv2nN8AfbK86RgEj5qikWAXI_rgDFXgp0LhO06IHCLmdLVKavd17uNOK1p2R7Oy9utzrQkbSn7JtJqP5sYNUR5VwzH8Wap-1fEXkrn_jf5WlzbWRbQL4nJK6q8t5fej_PqespcHzLSoQ-x5GjJUiP0kKXGwqlLP_aI9sHZVJpprBUsAjug2sc-5tKjSCohHZe6vm10p-C2K8BGuybyDCCedHXTkcMtWnS30KPNNcD4gncn1zDQqMjknsQ5FIbXujDEbJVONVt9Tbv6Cjsr871yKZg0uMWRr1lCcJ7jpWIpMbwizTtzA_8Tchhipb0Hb7p42wdCCZ0NYd6VOUBj7eoob-6K6gDUrmdrbtvKc7DWjNiBL7QLOpcEAcSi4CAGCDsCYUY4cyhXKvAhppCuthcTxTX5WtCxC4qpdO4kXiqb5aG0BeZgW5YBkdlALs1nHUBu89L3q1W_Nkm3rs3o3mtw_5aEyBwtsYI0GU0TZeY0z4JhKPVDFXbESW6V54X9fpUptowaHppl5_9X5_rFHZFlnVvtVlgH97p9-xQcR0k8CXEJwl4gHAhePK64J1xOg0BgO_B8EmCBqOsiYtuSCE8xasJ2qiCmXzrQ0bF9Slq2Tylq7mKVu1qrg4ZXRK5UbtON1Ic2TMm_-YbpyiM_q5Kvg-skvgctpfysN8iGGSxRbV2CTctGKu5NP1iXoU7N7NWnWZBWDw_PeT2IwLKA7sisqzhQUa5NbmvBWatn4l8RvmTyXhFRzGp5iWjJKZv_ONhMupY20gvZKqMTCFCNriov3Zow5j_KfOGVWdYv5uXY5PVdmI2nmdYyEXSuQqPR5z4adVC7j0YpuEQLPprAD7holFHW1B-kPahYcqs4W9QvjZmexatFCAn2oriwWcz6K75ql7xD6Xx_MVmYQPOwaduRx-aLpxEYS_NA7Jl7df7BnM8s77DNXy2dvh47k7Y2FOPAWAP3PsvMgitfosVzfPsh_GmTizTY5jTwM9BAxeN0i4T4MwyIP8OAVtIoqk58ILD4VHBJrDiIaNVeD5429tDMmmTUYg_IBqMon2hapIA2oLBKuB7Fx1WTyp5hUtEz0KAbMqT2BLR4klQ_xzLdhEa5iVJju3iUCOInChDZuMu1GUL4IZTyrNhTBGX1uuEbU6j1mq430FovEelSMNWb5XUFU3vGfE0Fs5pTmyzLwWgS1ceJHy3H5Bm08yY0Vo-dbiyatcXgPIRhgro6AttIfdZEY83RzTH4oxY625gbtRlA6HHLDD95oT7dRG5kEVZxjj6X40M26snsRaHn137suaw-ep4R4adOEd-UQE202eO0C3-eobMnq7lNpKpQWnW7JB_FbvQM-v3ZVhV7nongT3SE6JMn8qmu2DMtRvJcyuHZCD0mSKnJON-AGTXvBz1JKp9pMh69SuZ4stv1LH7epul6zn7xZt3YdoUwPpuJwc-ga56DBnquAT2b4lsmVGawps8yFfd4i1eZkjgIr5feWHJV7JuXWqbvMQ2iMFXz3wX09DCJfJ1W0DrWo_vySaDZe0yObXfDm-Tx9Pc4p0isG6X6OdMkiopkXb2xh9uaPtc0xSHtOFl4HUafguJpgotcFe8rTNFQK9Zolv3-EpotR-1fFE8pmfsgFzoKajQeGOdU30zhqfldvm6U2dslUxyB8ANMaf5IbK13mJDpXfNKOt7unKl8-Ckofn0RBOLvvf8DmPdIWw==
Screenshots

image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Righteous Fire and Born in the Shadows calculation entry points that produce Total Degen and Net Life Recovery. Reproduce the reported build in Path of Building, then follow the damage-reduction handling for RF's self degen. Done means the self-degen result no longer changes when Born in the Shadows is allocated, with the reported calculation corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.