PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Hand of the Fervent shouldnt work with EB
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
Sacrificial Zeal granted by Hand of the Fervent only adds physical damage based on mana spent
What is the behaviour in Path of Building?
PoB calculates added physical damage even if no mana was spent using Eldritch battery or battery staff. (Also would it be possible to add the degen from the mana cost)
How to reproduce the issue
Allocate Eldritch battery
Choose any spell
Add Hand of the Fervent
Character build code
https://pobb.in/4xZvohw2Pdj2
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in Path of Building with Eldritch Battery, a spell, Hand of the Fervent, and the provided character build code. Trace the calculation for Sacrificial Zeal when no mana is spent, then verify the result no longer includes added physical damage in that case. The mana-cost degen request is mentioned separately and may need separate scope clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100