PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Frostblink is not included in FullDPS

Open
#7,460 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
How is Path of Building expected to behave?

Any skill marked as "include in fullDPS" to be shown in FullDPS section, but default frostblink gem is not

How does Path of Building behave?

Pob doesn't show FullDPS section; nor include Frostblink if the section is enabled from other skill

How to reproduce the issue
  • create a fresh build;
  • add default frostblink gem;
  • toggle include in fullDPS;
  • see no FullDPS section appearing
Character build code
https://pobb.in/ktiaLSvc5pwV
Screenshots

изображение

note: I understand that skill dps is quite unstable, but even basic approximation AverageHit * TooltipCooldown would be nice to have, as i can tune cooldown as i need via custom modifiers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test entry point is named. Reproduce the issue with a fresh build, the default Frostblink gem, and Include in FullDPS enabled; trace the FullDPS calculation path and compare Frostblink with another included skill. Done means Frostblink appears in the FullDPS section and is included when the option is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.