PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Fleshcrafter not calculating life and energy shield for minions according to their chaos resistence

Open
#7,276 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Is your feature request related to a problem?

I'd like to be able to see the conversation from life to energy shield:

Minions Convert 2% of their Maximum Life to Maximum Energy
Shield per 1% Chaos Resistance they have

I ran in to the problem,

  • that my minions in game had zero life while above 50% chaos resistence - so instantly died
  • and zero energy shield in path of building, regardless how many chaos resistance they had (at least 20%)

and so the DPS calculation for ignoring the resistances:

While Minions have Energy Shield, their Hits Ignore Monster Elemental Resistances

is not taken into account.

Describe the solution you'd like

I'd like to be able to see the conversation from life to energy shield, like stated on the item:

Minions Convert 2% of their Maximum Life to Maximum Energy
Shield per 1% Chaos Resistance they have

So if I increase or decrease the chaos resistence for my minions I'd like to see the increases and reductions to life and energy shield.

Describe alternatives you've considered

I don't have a real alternative. You can only see the real DPS if you apply another source of energy shield to your minions. Especially I would like to see if my minions life got zero.

Edit: I found an alternative:

simply put something like this in your custom modifies in the configuration tab:

Minions gain 20% of maximum life as extra maximum energy shield
Minions have 40% reduced maximum life
Additional context

With 20% chaos res no energy shield on raging spirits:
image

With 73% chaos res and "grave intentions" life is still not zero, but some conversation seems to take place:

image

allocating "radiant path" to get some energy shield for DPS calculation:
image

image

Ah I see, red text is not yet supported. Maybe you internally have already an issue fot it, Sorry, feel free to simply close this one, if so.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how minion life, energy shield, and chaos resistance are represented in the Lua project, then compare the calculations with the issue's 20% and 73% chaos-resistance examples. Done means minion life and energy shield reflect the conversion and the energy-shield-dependent DPS calculation is updated or its unsupported scope is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.