PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add support to take into account empty sockets when assuming socketed

Open
#7,226 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

In game my Total Health value is 19243. In my build I have 17 empty red sockets, 0 empty green sockets, 0 empty blue sockets, and 0 empty white sockets. This leads to Untouched Soul granting (17 * 40) max life (total 680) and after everything else in the build brings the total to 19243.

What is the value from the calculation in Path of Building?

In Path of Building, my Total Health value shows 18763. Without setting additional configuration options to overwrite the expected sockets from Untouched Soul, PoB calculates 600 max life, 40 max mana, and 225 accuracy rating. This would be the result of 15 empty red sockets, 1 empty green sockets, 1 empty blue sockets, and 0 empty white sockets. This leads to Untouched Soul granting (15 * 40) max life (total 600) instead of the correct (17 * 40) max life from empty red sockets.

The issue as far as I can determine is because of the order of the sockets on my Body Armour which is socketed as Red Red Red Red Green Blue or RRRRGB. I have 4 gems socketed in the lower half of the chest piece leaving the first two red sockets free. It seems that the 4 skill gems in the item are socketed in the first 4 slots regardless of color instead of skill gems adhering to their color (since green and blue are spots 5 & 6 in this case respectively)

How to reproduce the issue
  1. Equip "The Untouched Soul, Gold Amulet"
  2. Using a 6 socket (links not important) body armour, place gems in any of the lower sockets but NOT the first two sockets.
  3. At this point PoB will have calculated the stats from Untouched Soul wrong because when 4 items are socketed in the body armour they are assumed to be be in the first available sockets (color doesn't seem to matter)
Character build code
https://pobb.in/88G9VsD9oTih
Screenshots

image
image
image
image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the linked pobb.in build and follow the reproduction steps with The Untouched Soul and a six-socket body armour whose lower sockets contain gems. Compare PoB's assumed empty socket colours and resulting Untouched Soul stats with the in-game values; done means the calculation counts the actual empty sockets regardless of their socket positions.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.