PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Vaal Cyclone CoC Ice Nova trigger rate calc incorrectly assumes 100% hit chance when Vaal Cyclone is disabled (🟥 Enable Vaal Cyclone, ✅Enable Cyclone)
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
trigger rate not available in game
What is the value from the calculation in Path of Building?
Socket group: Vaal Cyclone - Cast On Crit - Ice Nova - Inspiration - Added Cold Damage - Increased Critical Strikes
With 100% crit chance, 5% hit chance and thus 5% effective crit chance, PoB calculates the ice nova "Skill Trigger Rate" and "Eff. Source Rate" to be 6.03, while the "Trigger Rate Cap" is 6.06 with no CDR.
How to reproduce the issue
New build
New socket group: vaal cyclone, cast on crit, ice nova
In Vaal Cyclone options uncheck "Enable Vaal Cyclone", make sure "Enable Cyclone" is checked.
Check "Include in Full DPS"
New item (Weapon 1): Cospri's Malice
Go to Configuration
Add the following custom modifiers:
-10000 accuracy
10000% increased melee critical strike chance
Go to Calcs
Select Active Skill: Ice Nova
Read Skill Trigger Rate: it is 5.34, but should be nearly zero.
Eff. Source Rate reports 100% hit chance from vaal cyclone
With the average hit 1323.5 Full DPS reports 7067.4 but should be like less than 500.
I have provided a build code for this simpler setup instead of the one I described in previous steps.
Character build code
eNqtW21z2zYS_hz9CoxmetNOzxJJvfjl7Hbkt9gdy1YlO7n7lIFISEIDEioJ2lE7_e-3AEiKUgSKtJjMJBKxz2Kx2F3sLqjzX7_5DL2SMKI8uGjaLauJSOByjwbzi-bL8-3RSfPXXxrnIywWT7PLmDI58kvjw7n6jBh5JQxwTSRwOCfiU8qp8wU4LXEgFoQHQ_wHDz9y76L5yAPSRFMceFSk31yGo-gR--SiOXEB3EQ4ckngXa2fJ4QLHGJXkPBBzjqIBR9yD0ZFGMOoj2kw4e5XIj6GPF4qoV4pedM098PR0_g5JxIN8iLBij6cjxhekXAisEAR_HPRHIBi8JxcYx_-BW6YxcCq17J6favjdE_6p07PabYLwZdxGIn3cZgsCfFyoE7XRDkKyc1sRlxBX8lVSMXVAgfuej7bskzIHdS9ItphzARdMkrCNffWsRFyV577MxeYXY8mGaXTb52enjp2p3ti2SfFMC4ymHGpn6lYXDJQafVJJPR-HlBB3ocdcRrx4P2LyyPNWxkzBs5ZinZMIhK-YkE3pTLz5v6UBu9R3SAk-GmmrXOMPRpHQyJCEuXMp2_CDnGAr3i03luniHJEQggbYgNg7QFMiMsh0uQhttXqn5SYZzfaOOEDnZHylJXWkgCqSvO-ddxMytJVZvw-gcYQWctRTnjMSlKKdXhzCpzozzyh2Wquybdy7DYIbaO13weiHL8Nwt6xWb5XLtTJu08xKiDd3I3W4fy0ZdudjmV1T52-bRsPqMUqoi5mQ_yN-rEPx8Iz_krWE_YLLHW-EAHENRO0Y1T7LQ1JddQVZ947UAvMo-ow6YcllACZgHsmae8Dt5xzvwShCvG5BKJfCBiDy8mMZcpIScR6isRxy-Qbeqo5CZL5VuWW80CIu_gIGd4YC1Iuuq9NtFitkraUWiXhDrX2SgIqKEkCDUpqnRaBKqrpJiDhfDVZUMK8atSpYFd4WSKaSjXn0aXUvTldJYvJQyuq5DMOvXJnTlWZXnGUD7F2v1hdmrycYRLIagHgka1c2zLXC_wPWS2warBB6PM4LLnhmrjUAtLTQZdJY-LFbrnj6JJBwVdWepCKsUqIgRDY_XrNvTmpNEklRFa4KegkXi4hYsi9L8tAHnOQz9NcYnPUL0H9BIZbyn_liVh-gjV16QmyM778LFuQ8muR53SFxazJS0-RbegQQoMPIV_V8UO-jivGNOkWSrh8iXVsnXZb3e6p3ZdFllMI210lJhwnXyljKJL_jnAIkCaKwDtdoLzCkUBPAZLVvXRCBDkt_Qp2l-SaLkGP_BXnZOofS5lOe6WnSHldrVymOjmVKsgRfwPNL2R_KSoRS3LUkI-tczCj8kIS_LUqzX-DvNQEN4EXh9KVS8-xjdg1zTP1IexH0TUWGHlJAv8JhxQHwlHNr4jg0F08gOneYsamEMnUTmRP5bctoJ3a5nlb9ffkp3t_yUOByDf5n9zZ1UVzhllENKF6AnwiQQPVT4CwyVgTTRb8beC9ylU8c86iFITwckkCb4PHc0gIwmkQdKUQao3yC_LBPuGE1V4VSaFz7cF7T6oRBRwEgFTs5KTTkUuU1SMOV4NNwoCCXALmynUpnU7SgNSc5LQfzl_GD-rDh4UQy-is3X57e2stsVjwGfkGh2bL5X57CSAQ-EhZ_JFk2x7An8v5QP1RjNopp3PdmYza-puMJSEFmfVetuVCldalJuSHRy5IJMfkw_TLuXKxCNwqFB-JH12uwO1uZZKz1aBJVCmpJ0RoY8hj0papR2Y4ZvL57zFmVO6slX_6oLu7AQ_9rHQDVrCz8pjSHJ9XS6n6wcODHhkwkTCT06XbrLczEQhRL93i5KFq3g7WUl9h5kbS1hENXBZ7UPckUSYVneGpFE12q2XJ4uW7wDlGsmWkt_IcxEmIPzI-xczJWOlVQiGN5sSXdjAkAnvgV-17AWtoy4W0FTv49Aljlotjym0kZuO5sondT4c0kHkdME635s-c7nPhcz0iGV3rTWluLMHOnGpLCy6PA80iwH7iU1IUtEsW2LxpxFksnfeZ-EuGw99iSGB0oKlBc5mtyKPmKZAHzYbq1o8T0pwCkyd55EH60oKXUJfpWGzXa05wvKana6aP7FmmhexJfu11rjY75ZMApeVLglPitipA6RAkPyofVRT3wTIWitlF06eR-2Uaz2by2kWe-6G6Sbq5vb25er7_dJOcXnmIWuWXIPan8lJB_7_OkSZE1QIoiqeR_gimTMmbEuQaNEtZJNfEGF5GJDtXVIxJJGeAK-CmqO5odkmzm9eawMzp5hsJ4RicQxHphpQY5crG9wilJ5QFpjztTdzk5YeZka5hpDXrAtigKXXVZOYivcC4HOWWZiwkEJgZZ05G92hCyFMGLJXOqCsTpeItl2eSpirQi-tCjuWuCvY7KcDMPNRtkomBHjSD9Z2QCZ2MFmhVXUcZtapHzfBr4mLj2vWgGZz1VHhwJyPybi4ZVQGnRx4oIwenGVAmiyXjzt4wkpGYGT6JBQmTXNHEaQgxKiUpdJyQTmNhduMcRYGuVIfXoCE5ZobqLqZhDXKsIBJtdPYMCs3TmFnpjpgxkBVBdeFs1F9ShhdsQdJvMqhfjxYoIW25GdafDBc4iYq_g1dOPd2KMbjLFllRwIAy4HA2qr90OJvthtPhHG-hkvpq3O9k1Ax_EVRmNDu46MylFBPpVIdxkL51GIfxdiKxxo6LUwgVvyCdI6DowgCW0RTsr4iDazjkRMHelmSlxNrtCOulVeKlQ_nOlVbmqA00uXMrsmFNsocRnEV3BdlOOU5ZE_COYCZfAOHsMIbf3S0etE4uIhx41_IK48CFyhuQeAnMUsmedqWr6y3d5nreTgsJ1QaSqX3So4KCSxb4f3Hu_--ieeQ4rVP9LWlLdJNWBCR61xTUHSozSeeShP-9aCavJp2r0itpjOSL7zgi-mWDzwQveaAeyz6RrlKAMC3MZCch37gYw2OxOkMvj_e_v9w0rni0DOm_gEf0nwgNoTJzSeM38gYRlnjollPWSHpsZ2gUEuS0-i1r_egqDkF80dDFCiCyEaeRtFPgo9VI2khn6OMR_G0oTYzJn2eof9KATBpmpXLUafydiH1m__Nzx_oBCY50Vbhd0KL1G11rkPPPz06vJOg5pPM5CRFGWjgQXl4BIHW6ILAWdT21zeHf6I2KBYCsltNLOnaAAyB_CxqPHKV3QkgbTOPvEAdzcma1ev8MPC9CP55YR7Zl_SSF_NHuW0eO_KJmNiG61lE_AZwC2N6kl8-VzFEe-ePJkd396QfZhwoJBltGuqBCqmJqgJqO0X0gAEbn0v4Q7EZMQ9X3b_StPHBbh7q8QHgOKXIk4CtVtgJpmQ-1oSrDoYgeS1GQEkhe__ZSI0wKdSOFs5eis5eiu5eit5eiv5fieC_FyV6K9FZctVgy35W9RpODbzYhGRcICiZ_NH0ZP8ioo1sTGoMgTsjB-7ziTZBLwgQaTFdRJHdaeQRy1nhrHz6dcptHrzoPpwYeNpq84eU2o34NC-rXsKAqPC45HHrbDDoVGNwRSFm-21u7igg7bONdati1J70a9sSugUe3okLqssk6nKwKD1UEVNL6Tgt0DrSfTmWRq2wQHP-vJDrETHZ7Tb8yh8rLtA9eZpW9HfgxI6IGE-zUEBY7By-9W1ndVex4DCXWe_xVB77KizvURXuVlXH4seIczOFwGbqHKq5bV2zvVJLEWyHdG6w_bvXqOq3telbkHLpFlTOog0NLv56V9w4WpFM1YtmHKtuuIbbX5lO9evahf2D-cng2cmgGVZMrduoKDbUxek9p8T5d1GWTNW3Fu33kQEuq7XRwaggUdfCw61pQbVHre0a655O-n6L6vOr1FB7M6Py7l03cOBLcH3IvWr-cIvuIloVw8kZAQ33Nd-581cF00_5dpPt3bv71gBHDLllw5pEwmYkExF8lP-FNX2o5zv_mYxd9_ue4KahXDEk9MCV3nP1TpK-6pJiOWayIzil7mqnXaicCq_dXt9_R-R7lZ_1h-fNXEhJvol5Dka8eTQib5XjsWV7ymwDOmOr85XVZDMxuf1NA_7gYsPkrhNxE6T1FYlHn7e1fw_8fRbgnSw==
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the supplied build code and the Vaal Cyclone and Cyclone enable settings. Trace the trigger-rate and effective-source-rate calculation for the disabled Vaal Cyclone case; done means it no longer assumes 100% hit chance and the reported rates and full DPS are close to the expected near-zero values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100