PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Trade search lists items in semi-random order when sorting by DPS

Open
#7,027 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?

In the Trade menu for searching items, when weighting the items by Full DPS or Combined DPS and sorting by stat value, the items with more DPS are expected to be ahead in the list.

How does Path of Building behave?

The items are perhaps only roughly ordered by the actual DPS they give, and many lower DPS items are listed higher than many higher DPS items.

How to reproduce the issue
  1. Go to Items -> Trade for these items
  2. Adjust search weights to only Full DPS or Combined DPS
  3. Search for Weapon 1
  4. Look through the returned list and observe it is not in the correct order
Character build code
eNrlPWtT20i2n8e_QkXV7JcY6Kce2XC3zCNAFgKxISTzJdWSWliJLDmSDGG27n-_p1uyLRnJ2Nj31s7dqRpiS-ecPu9zutUtv_vHr1FkPMg0C5P4YAfvoR1Dxl7ih_H9wc7tzftde-cf_9V5dy3y4VVwOAkjdee_Or-905-NSD7I6GCHkx0jF-m9zD9PSdFvQGos4nwok_hSfE_S08Q_2LmYxCINsx3DFbEf5gc7V-LHjuFFIss-ipE82LkUqZj4Mt0xRObJ2D-a3_owub-XaSwmOWAMAc7LZXqhOOhN8uQy8QEmEFEmd4yRCONB4v2Q-WmaTMYg2Y7xEMrHAuj88vqqf1NhL4xL9voiEj9kNtwBEX97dx2JJ5kOcpEbGfw52OmBpsS9PBYj-AsURTQBcphibJM9kxCHcMp39pciH07SLH8dhcFYSn-GRPcsqw3yOpUnQSC9PHyQR2mYHw1F7M3HQ21468JeTqI8HEehstdL8GfPSGPUCnyT5CI6vh7MYJnDOLf3mG0zYnN7OV6Sv8zOYQTKrI6gdO_s2diyuWObrA3vLsyHz3A5oTa29ygyCTDIl-Ge38dhLl8hmkK-TsIsiTfQyysEPppEEQR9FbNVqX2ZyfRB5GGdyXYfSkZuGL9Kl5ciFkdJNrc0Xgp6LVNIJ3kNA72AMJBeAhmoisLNPb7KOM3YrQNehIFcHXItWUqEdbl5nRwng1Xh1ib8Oob6kGZXgxwkk2hFyHye7YiF22PhZxUSt_vNsfw1B2P2EoI1yHaC5_FcDMaW0KsCWrSdv4dEhfTLqtFp5uTsel6ksAnZiRBum5Zt8mUeN9cpZLIlJdB7q6DPY2-uCUKXEb6NU52WKrWTYGQuQ-mDi6ly7UZyZZz5MKWrzjBtc8-iNuImgkJvLx_3Xsbl4E_zkRHaWzr0hZTe8BR6nr7I5wwzm7ejqVw1t5K9XOEKuKrwpYmzQd3MWQ1hUXFY9UQ2-I1jOVAUlhFp1py5Zy9DatabZbWr7SSW6f3TYBjKaC4etlYBnzJ3JMYrYGq9V9FX0n99vCaNrITarJdW1DuR-qul4nkdXQq2JutFc6Nw5iFH9zBdCv9R5v0aCiZsj7TaA8BnATpHwdYeW4Yy88xVPBLgn9lvBbs9iGyl3Fx4VAFddSbSWiAuJfS5gOHLVecE12nyXc06ovXQeukomcxLJUWkPdVqMQqEmhSUtDI1fMpCDzxET7r60p94tWpmY2iCbW5SB1mMme0TBphQrioRcBlFa2H08lx4P44T_16uNchaGLNJoUYdTMZjSL3KIRYIMKhYren2fZiCFrOw0ivZ5GXgKwjmWu5DtH1aoNy_PgJ6GfjZCNRpr5r3wzyGac3KwyxgPB-rXZqhSLKFcXbbWauALw7ysl0vIWWOoITqpYLLpFKj9lr5ew8TvJVmaxqwPodszwTJI_A-VItC2XrQl2Le47bznMr4z6eV6dfAVxrgJPYnqYqJxTFWxlhpmJ62GhQkOboIR2Gl9SkxbsIRZOEsOxa5MPyyEf8s0lDEOdHrWpkUqTe8AHd5L6LIhSRysFO9qr_ptbD3YZTL9BiuKTaVuhYp4unA7_b1Ap_6dD4aJ2luRCLLe56XTOL8TGRDaJNsEghs2gGmZuD4JMBCCAd5LvGQ5Qe-T1zPQ16wo1H7UkQjMPTRjiF_KYLXIs2fZgt2CuRouqZX0A-Q7xBiQlnmqm2W8MeiWPi2g6hHPekQ2wxE4BX8anIgTpaHsV5_AN1G0Y4xGCaPPf9BCXyTJFE2G1GMxzL2p181jZtUSkNM86OndKFtoL4YI-AQupEi0oDMvyg1udVlFDv_3f0XZ5ShroWpBV8IdyjrEgs5HL5RjrHdpZibTN1DFkVdxkEY-IYJNp0uhfmRgoSJDwE8StVnG1GnS2zKFZbJMAEajNrqHoeGmHepg4t7MLlS9wBbj40w7jLLhG-1NdRzX3tLnICOVLlkFu4WjJrAG7BkW12TcfhLkEO60Hc7XY6UVNS0ELDFTZt0MSW8W4xIoCm3uhSZDhBiDmZdbCKHdgt5Cz4oJYqg4ruLbYScLtjTBOpYS1fISwhWg3KOu6WcxFJ3HVAqMGcSYEH5AIyFQHfYhv4AKFswClO8dWGKibpqDcsEQDUIV-upXWZyuIBsxTFSpAAdVENMagGEjc0utxlzutiyTN4tLEgcJQhHDkjsmKBl4NqE8bFWF0MgB8cgNnaQso6WAqQ2wfQgFmVgTYC0AA-ZhHS55XCQHGgihecAUw74checGgETDCoUKB7UA0pGDK6YwBdoBwMkxxz0zdVNTIAOqAIxG1QE-gKxYEIJSAyYBYcBqRjv2iAbSABGU8ObwDDoWrkoaLXrOEoaDP4Kly1Eu0rtrGtzqjSDgU2YZmLwA6I0yBhRxiUYc2CZg_DMUVQoRjCuMgrAKyaUzKD3wiVBM8r5wDbKjUGJ4AxgIpDCNoFzjkFo5XNUSQSqAksAHWw54E6m9hHTBm0T6MIIxA-oAcwKcQ6aMgl8tuFCEUBF8FEG5gYF2kqZ3LRgJB1QoG4wPbOV85kgPUByi4NWQPuA65iWrUJEZUm1lCTSp149UOiOkUMyqDzNILR8TFHEkcoLv7277V_oD78N83ycvd3ff3x83BuLfJgE8hc0wXteMtofAxJklN3sRxhFu4rsfg_-O7w_-Xj_efLwx61F0vuz-NtJdn5xGPZ__XNw_fW0PzgcUBSc9SN_9-Pw9rvlhwM-zNj52Zc_ndM76VxZI0cm790PtyeBeX_27btHAjY8d_v-LT8Lkivyc_z1j_wqFsOP8XUwPH-Upz--jHbH38YJHVxd9fv4pI9I5n794Dun38_Shy_Dy9ubTz52v_qRffhgHn-l4dfb9OTpl9Ubfz8EW0-cj8mf1_SYPhwPP91fn7Bfu9_-ON_NMUl7zH5_dvIpGhz_9O6S8fjz8PvPPz7FR09P8d0_nbs4fP_ZfIiu_vnz0x_pp8jx7NPvj5_6XFyHZ3eBeSZydHNzvTt2o-QpHD063675zR-36BcLvqf9H5--WujM-8L42NpNvuK727sJPjbv6ej064UZky-PD-GNmzx8-EYnN-PB6IEd0l7vUvh-dJN8OXLOflk35z8mk-F4mD0ej7_8PDq9-fazd7p7dts_tY7cr_KrDeNnnz5_2h0eB_c0cr497X7QBt6fWvhd8TQp2y--qcYsDSGTFkV6X1UIXTVVCVEfPkJFz9S9qWeME7kH3eN3se-qwprtiyCIQj0RGXr7_9CudTB_wvU3MRr_XXtMdnCYxDIbihzKj748lCIfifFBnk6kGnM61ruBhodin-ancpQdPkGn9l5NJRcW2ssSp6AHMi-aiCrOwY4irZqDQEwidf3TREShKtcEVS9fFI__4iQdiQj6nXA0GQEtKLlqalGQvHkaq4LTu7go7vSivKSmxpvW36LOlhwZYSXG9EX9QK83Z_tIRF6mGQ9jL5r48jwuu9hKR-Eq3tTzTLWM50-FWqA0G-i3d8BPCXwaJa6IyBSlfMpJ0E7tPp7e13ZSeaFiqR3jZyGlun5caKyEVK2K5v1ejtTdS5kLH9q7_XPoArN9pZZ9zRt8aqJY5cSv8aAoz1Wje7Wi6ItR2dFU6e1vTe7S2ofpJNccNgu_TNyZuzyn0Shuo2wz1K1L1p_kQ9WFbyDYMxIryzXD3LpYA8g6Q5jS3kkxVgsirxbuKEoyqXKMyNeXTyMbJfbWZdSLWPUloA0EXUZtQeAyDzVJrKkYUzJGSWfror-H_8Ngk2hcpLCyTaeIZb0s8tlfL6EfS0iUo3JGub4eyyTeTGVlXdbRt-clh1GS-FkuVF9wKOK4rWitIOGdSBcorCwdoBol7vZEq0dob5KKV4t2rfq89cUq0FaViK4Y0T3fD5UXiOjL9QZh3UhmZdFO4kithcr4rx7detlN5-JXe4fG1nTW12Mv9mSWp1AArlOg4OXJNkOgoJ6kmjko9KNXyzjj804tKYYy2ETUGY3tF3q1F61uilfU9-dEVhay3AwnDY3_v9CuXYpwI9mq6KtLpbD-4oHe8zwoAd5TL_bVrsVsw4IgvTB7VSWfo25_7qWK-aW4D71NJl_Piawe4mma3OuHiNuT7QLmJRulrmcEVhZHYRoadfttuX6SUDzv3aQ3byKzeoOusY0CPfurB_ihTDOZ_ni1nyzirz6Vm2JuuS3vv2qaOpXmGYXV11AUqtHf7nR0Vv2P0qfNu5AqkVc0IAr9L-7tnydRrDYnhq9baysV-lE-NhNaWal19O35y2USwexiMJTqAe5rG_MGGqv3PBrZKLC3nv-PIPVexcXU9Eb8kBstvLXSWn35DUgYj0OQtyBjFHSexUj5cSBz_aSjeNigPuoo0RDn8XiSa9IHO6Mw8765kyBQZ25ACXmqzxSdvH9_cnRz_vmk3N9QRdGK-hZPRq5aSCj-ne-EGEj9tMTIJm5WfAQPDOWjZuQYtBRGmZIwisQ4q2Rt9TCh5DwCvCXUNNRZODud00xrDtBO6eSXTHO1sAqznTSUrXzN7r_AVDGg2g6p9oO0UVPnXtoJFaVeWbvY1dmiKX3GqJ2K7p_bkNXNJbjno7GIWkcu776giVw9TgK_DYPQU_tolptcPXwqoJbopZwcLLF3uTuunYY-ENRGoLjZjlwc6mnDLu8u0ao-UNSq1eJuO_qx9ESr7MXNduTZRuEkPlObl5qpzKCWUPqYFFkMgqYXRmoLW6tlTyI5A2kneJUPZVru1mmjdAk5agqyNHDS0J3k7WFcgViiK33GoUVD6l47arFZv0UGdW9JJqptWG9RaBWmnVSxzbs1kS1DLbYztuqv3By5xATlBuEW9Rd3lyhhuke6Rf7y9pIgKdaRH5LQL_bJtoTLAtiyhJGoWdumZPTm383JLO4G3pzi-0hkP1rtXd5tR7_NdU_ZQKXoY1YiooJqMwoqtjaj0F9sJOa4_eUthM5f0AxKNXNZlsBmMEvsm0_iYyhy-RLbrkhKs9UcCHPR1qJVpPJGSdemWGuEl_lwpcdtJwS16GxJt7MapdnW7DMpInWCN4k2I1juswHOtiFnkmci9vXhmQ0FVed1JmMgNuXsqqldnZt0keq7_elEQm_EVa19uYt5kKdqhv1nkoy-HuzsYmyhPYKYo7Z8UlrcKLci2eX2I-j5jkPQfKo9ZjqsAvyiNt-bzp7FbIQxtZzy3OM7Pb8q90apz9OtUZNMFidOi10S-nJl05IC1fKwYoLfF9AEP701Pl71L3sXnQ_Cl4ZOE53bOPw5kcb58VsDeyYyPcosxAgiEiPb4hxxy5aWbXum6VlY7aLGJkGeiwPqcs9xA2qxAHnSxLSjR9UyvzUo7ZQ7qt4aqKMv9uXPtwaxOtBTR6EHPqzuqCmcwquzzets3348_3R70rkZSuMuzKRxJX50DsNsNMmHz8VwsEcCi1IXe9L2XGIzjD0bS0lsYrtUbRBn1PcQIgH1iOcEzOfEF8S0mBnYwq2JQVizGHZdCshjEJdGEVZdw_zdSNWJHulPp6-58igjCQwpvKEBzaJKL0aQpDDJDeHKE_QKxm3sqQ3g_vS-iIyiCVFZzQgzI0oeZZYvjlYOcS1jmUM6lZlh_15F3HTUYXg_VMOqmfelWsOLYbRU_T3YQXu8CBwynZu3QkyPGzSY26ybu9_rn3SuI3EPFv0A08PORZL60ZMBl3LZKRqrtwajqPx8KLLp0fAwkmCPPcxNWvUJ05bICij4guczgoXpMuR5yHQRQYHlcRMxzw0cgV1mYdt2PQpOD6FAfI8LRkTdtXnVJ8o9mMD1br_iIABU85A3pmXkiVEw3HlDiPo2KrKmoZqCzhtMflcX1dGhigXgOi2uqyM41RtLtY1ftMfKFlsCwdptatVtetk7PT_qnIlI-bCvJS5CV7mneh9KrF7iUrUZE0wIlyDqMRv73A8CiGbX477nOo70pOs6JuOB6VCHEMcVcIFbknBuCUcwB9VsxkhzHMP1mplOQcI8M85HowlMUZ-U3gdDsLAOGozLvdmZEQYqBfsqjiJZgEh_JYs06cpu8P_DNBxleRJL40aqlqTTn2R56BkDkQ1ranJsy4Yc7AYCBZD7RCCFzzyHUeK5aqO-rikW5GcUmD7jnJg2ZG1ObRdRwnjdtUk1VbOqbnAHQ1oJYy-VQklerCcu7hfrYDzPfTCFGz0Zqs8zbobQxQ_BsztvuNXg-rZ2cXUur-b6TmNEkBoj87RVJsLHEMpCsbBkFAuC_0ahsgSCvwhhtruQ01gxj4WaPCV_gx4h-3sGvhNNIIMehWrdUxq90SSSedWZfFNwEzvQgJgWFHrMIbawi5EDddMRLkXQBXArIJYQGEmGSeBjy0emcGwEYO5izM2dCZt1Z3qDHR1cOTRD92AvaNGMY_krl4r_DkdzL5p6SrEgYBQrAp03lDW7DEWNPoNR1WemJxINvbJYLDRD56ieo5QeCc2cMYJ6CtUUqBV7I4HZ8AeMpqzSMesENcDUAZ-R-__lf0sgrHYPxaipIhT5IxTx1EdVBg7zhvYUutHA4UHgCWlKG5uBhxFCmDLmmQxqNHd8C0Gak5z7PrW5w9XpNuFw23OEJYOV6sFie4qt39VrvVQnBG5wL8LYEGXdKk5UFsaGRsrwYSoFN9Vys06IhbesZNhGdeGGotC7T-In4yxJ485ROsmgjU-NMwlz1XzWFmHoPNraIhsj2qnFEUjsdKpLbYtIuGoCaJgI9QPm2gEUYuj6odYS5gfClo7NhOd7ju15liktdcnm8JlZbsBM7mPf9slirWlpo-qNFF6wCGuoQtPlcohN9YSjw3gVqFCHTjELSYQ0J4vp9dnx6upNq0paFzdFWK-dGdPXQyykG00HePPDyX9CLcKkqZ-R6pHee1Am9DJHiXrq3V_o-DwrsKDjczB4C2bEC2wzoD6EMPGZBHdzuaDchph3CLeg75OeEHDZdgKTeIzVOz6KllUfgp81IXXHKnhXzWkxBQ9UhwrNi_YL6GIbZ0sZlDWr3XP-vRt2TBusdgzq8I0z8HBoSJP4T5lBapPGqZjEOfQO2SztcKc161i8Uy5mvzUsc_q5Ea7iDK5tIgltP3IC6GdNz8M0CAIkJCWBDJADs4BAYAZpiNvQelCKJUYmEsx3TN-0nboz4MZcc1rLNIu5v9ZlTvtJ1S8oKysjl5JMk84bzp93toS2TOrYX8FPXs4QjZ7Emir9YOIq-fIQQmY2D1SL2fN5oHpgs5AThKDUCbyAmNIJOEwFfRlYrieJ9JmLLclZIOAGQR6yPF86LvY9bPseI9S2iVV3A2auNgtkZs30I7VBYZrbwfyUzrvTacY31MpLpy9H8C0zjiZpBv-Ab8As8f_Mno224A1RfSLu1aw1CsdjmWa1yD5MkkpUq36hfY3FsuaBjRFvj2zMMKst0VmQ1hES0L9ZjsNd37Q4d9zAxoE68S6QsB3EmXSsgNooYJDxGZMIB77lYWzTVWJb9xG7p9VOAi0syWAdr_NZxxuGqms0jDQEudXWWBRgs6lsY2ATvkrv8B_QIDQt-KlHT-rQjeychpGvtPtL1tbwXIQ4CqCnhNkphD_GLrJdhyIamFAALBscxwOf4cRkiLoSBcLjNJDEFxZiwl6p-ayWg4U1Xl6rB4vrHj3fz4yiLBDn2V3-0qIINrWzLfax5U5YYygepKGa0vlcxBOQWgy9jUNBklr3Ul0JmYH8B_iV1eBXd4k0jsLUi2TnWkzEs67T970AZikEERNDDwFFxrU8J3AhH0EhCRziWlxajHqWTaAnFci0LOLavskJYHJv8bFH-wIaTCuqDYKqfaXfaLcp1jKmDwyS6TZo6Ctww4qZ055m3tj_7gvGa_cV6gB--zOv-tn8KMmNEHCu3dv-hXpGV2zkK7AMtW82L3Yx4tl6RhvOoYxyo-c-ZZma0OssYZA5AfQS_nTMRRp8fRpkCzSwMXgU40VC5hYEMrcg0Do0dJuySICuQaBYNVmkgNdhocE3XqWGJpvwLdgEb4EGW1Mhc3B7I5_cRpCtQ6OYglS0jtmrXJBs6EB0bZ4rFuIvYZxGenaygZ80h425NoWKovFqcla4tF4n5zoxVTwamSM4r3VCuoXEuA6NZtHZ2m5VcWT8IopqqWoYZK3kt7Z4lZHoq8KUr62Pig3mmUETO_cBXL_CTjOkXs02Rf0gH2VklJeqpJcQ0G-PqxMoL61IQL8trk6gvNREYK04Jxtnis1LNNu0S2Db6pvoWpz4T9Plgq2nX76trgNvRyKyqYnW7gQrCeGVRdDcjuh841S9jlfpvFud0FivUjfeQo3aWlTx7RjC3LARYxsbctNWcEvBSLeVHLZG6DWTpNfpYo5lbuSTWzLFq2NkQ0_aWn0gW0gU26CBtyXQ1rLWc0LFAlZxMFVtHhe-HOiN43dSrdll5WDqrduP-op6U4teB0OzA9zTF2Qa-g2Zz3-dqhyokXgxfnEWNomD8P7ZyVapVqIXXxs3PeBK0ex30J7hnGeHiXpn4PT4rP72HNabZHkyukz8CugbzNHyR-gNhBZ_sW9ObvrLfc9xip_ym0Oqn_RrEWe2hrqoA9Ksg0kmn7-I3U2SSIq43NT_HGk0-1G6fm0M3qpl9ch4RY7U29jl9BXqFRu2kVYLzSuSLlhRK8mLCLiFl5mgH8Ej3Sf1vEMfNl48Ol1zlSQuXv6ln46ot_uok6sv6bTgrfLrgNMh0DInKn9Xce4as99XbPCiSRAUbw2EGCkOKr3E1EyUQynV-dO-VA9Co6dmzOtIeFI9ApJpVajyRxWn8ljV3yRsgq_9msPMonw5UrvfE_LCcA06f2Gw6u9zTFHYS1I1RcBLvDX69hKkub-q3zJUz_cH-ki6euY_kFFQcVz-MrvrivjsJz9W1k1TSNrOy3Z7nuiX45Q_UJNEkX5eU3XK5YjTFmxuhJe8uK0WvWjz2VHaGYZJzFaULLwPo6tA_7wH2Pr-eXJ6tz8tme_2F39l9n8AgnAbEA==
Screenshots

image
image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Items → Trade menu and reproduce the issue by weighting only Full DPS or Combined DPS, searching for Weapon 1, and sorting by stat value. Trace the Trade results sorting path and compare displayed order with the DPS values; done means higher-DPS items consistently appear ahead of lower-DPS items.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.