PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Charm weight calculations / trade links (TradeQuery system)
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I'd like to know which charm mods are good on my build, and would like the "Trade for these items" functionality to calculate stat weights on the charm mods for me.
Describe the solution you'd like
The "Trade for these items" should include an option to search and calculate the weights of the new charm item type when selecting a jewel slot, similar to base/abyss jewels.
Describe alternatives you've considered
No response
Additional context
I've tried adding the functionality myself by adding a new option to the TradeQuery that had category tags like "animal_charm" and "str_animal_charm" etc, but when searching, I got the error message "Could not find mods" and I'm not experienced enough to do this myself unfortunately
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the TradeQuery system's existing stat-weight calculation for base and abyss jewels, then compare how charm item types and their mod categories are represented. Confirm the expected search path for a jewel slot and reproduce the "Could not find mods" error; done means charm searches calculate and return weights without breaking existing jewel searches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100