PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
(Crusade)-Slam from Sentinels of Purity/Dominance minions not working correctly
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?
The slam abilities of Sentinels of Purity/Dominance should be supported by Multistrike and Melee Physical Damage (dmg, attack speed, repetitions) which is working in game but not in PoB.
How does Path of Building behave?
The slam abilities from the Sentinels of Purity/Dominance are currently not working correctly with both Melee Physical Damage and Multistrike support. Both support gems don't actually support the slam abilities at all (dmg, attack speed, repetitions).
How to reproduce the issue
- Select either Skill in the Calculation Tab
- Compare the dmg/attack speed/repetitions between the default attack and the slam abilities to see Melee Physical Damage and Multistrike not supporting the slam abilities
Character build code
https://pobb.in/hzeaEyGcUzE8
Screenshots
Proof of Multistrike working in game: https://giphy.com/gifs/CNFPzWHDr8jtajV3n5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin with the Calculation Tab and the linked build code, comparing a default attack with the Sentinel of Purity/Dominance slam. Trace how Melee Physical Damage and Multistrike affect damage, attack speed, and repetitions; done means those values reflect the expected in-game support behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100