PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Precise Technique is not calculating correctly

Open
#6,870 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

In game when I select the passive tree node Precise Technique, my attack skill for "Ice Shot" increases DPS to 18,415. The buffed / in combat / effective DPS values scale much higher than in-game than their counterparts in POB. In-game, the buffed value is 37,804.

It appears that In Game, "Precise Technique" Keystone raises my DPS significantly, in POB it lowers it somewhat. Perhaps it is calculating "total base" life against "MH Accuracy" instead of "Total life" to decide whether to apply the Precise Technique buff?

What is the value from the calculation in Path of Building?

In Path of Building, the unbuffed "Ice Shot" attack skill shows 12,210.5. The "In Combat" value shows 30,316 -- far less than the in-game buffed value.

How to reproduce the issue
  1. Select "Ice Shot" (Arrow) as the main skill. View the unbuffed and in combat values, and compare to in game screenshots. 2. Note that the "Precise Technique" keystone reduces the DPS value in POB. In game, it increases it.
Character build code
eNrtXetzm0qy_3z0V1Cq2vslss08YXKT3ZLt-JHYiSM559zdL6kBBosYgQLIjrO1__vtASQhGZBkabf2nDrnkUjQ3TPd0_Pr7nnYb_72YxwaDypJgzh620WHZtdQkRt7QXT3tvvl9uzA7v7tr503NzIbffKPp0Go3_y188ub_LMRqgcVvu3aqGtkMrlT2a8zUeQriJrIKBupOLqW3-LkPPbedq-mkUyCtGs4MvKC7G23HwaJ7BpuKNP0oxyrt92BjO5U0jVk6qrIO6m-CDz9wh3JRLqZSq506_1pFl_HHrz3ZZiqrjGWQTSM3XuVnSfxdPK2i7vGQ6AeC6LL65tPg9tK14Ko7NrHOFJdUO2XNzehfFLJMJOZkcIf0EmwkLxTp3IMf4I0GU5BFLWROESM2KYpLNE9auU9niZp9iIBw4lS3pwHHwrMmkhvEvXO95WbBQ_qJAmyk5GM3EV7ZhPftrTX0zALJmGgR2Md_cUz0chsJL6NMxme3gwXtNQU_NDE1OaWzWk7X5yt785vQTY6DsGiL2hF817eRUGmXsB8EwdpHC0x2uiQsDX0yx5DOD602rpX0wpl2DwkNtnMglVWiil0sNExT6ZhCGhQ5Wg0-0ClKnmQWbDcuWYvi8dOEK2O0kaanMRx6MWPUWXKmM2z61pG8iROF55DaBvpjUoAlbIlDnMNw1C5MQBZlUWIQ8o2aKeeu7HBq8BXm1NupUvJsG1vXqbHu-GmdFsLflmHBjAJN6McxtNwQ8osqbg2b54536uUotFtTtWPhcvbtEVelRKJRjy5jBZaINwmcJkSNffwIdYIsN42ORq9u7hZQBGHKSMs00KAAS0gO3pKA1eG1_JHMJ6OIfbcyntVgQLG7GZ3vRtlEQBaEzMyMcFN3GdBopoYBUBWM1qFXnODvLm7EFTjtJHTRqxtWlYMYrKWxMN9rakvI3fOYJE2uV-iJAf6asLS0oJmGcA01CmSE6qNeRbNlNN5k9yiaOxORWWLTwsm1sp0pZQ7OoesciCzShaDrDYAr_SI0lYLa-olC-M2uTUWJs3gscyxaixCDhFFFscQWJHZqk694TA5JG1c9ZZrRudIJXdPw1GgwoV2jGxCPuvaiZxswJnbvcpetb-5WXt19tiIdUuj_CYTb7MAtW2fHmRaBWNkU9tut1jBUTVWy9S5VpBmA4unVvJ_Sxzi5gom_qbrl3Brzn4yjqcb1CO5JgXxRqM-CylFJj5Q3tTdLIYdh1CEblpVQa_CcCuOfpZJ9_409u7UVo1szzGcTiYAIXroV_iakwIdDiHnDyqJkLUB8Sdw3eoUNtvC5qp8vp54VT5Ca7OB1VbYhhyrTbUH8pVWDsgm5Btba74ocA3YMIYQkK8pXMcLYEGHzYnlGdR5GxVtOeFyCdk8reJH6PxILxql21FDzrOIYI1dSVT082lj-Uvk1QZYM6J700RPho3bWOXYSI9-PmyQDqvxVTAOKolOyXEdRDAv165VIUrsQ2xSQU1G5wnJM-bltSZ0aNlzf9-J9tm6DmaWeWgJRAjCmLSz1SzrPKOsXdbZrJH6VZ3NeJ8vtxDbOkRsDf3y2FgWPWztXU0rJvAwW3DMNzBflZOZBNSysWjsY8uyzjPaNcs6z2XXLOtspstS1YKAuI2wPROqZWnPyp6x1KaqaCPyLTu3eep4G4wh5UrTU5lJwytr7V9lEsgowxoxjFTJxB1dQeg4k2HoQP7wtlt9mn_Ll87PgjBTySk804il21iViGYY9OYo3wvQny7HkzjJjFCmWd9142mUXch09LYrGXYlDK4lBBPIsiRDrkcFpzbzGIw_QUpKSpxuzjpQMhzDXDnpGuqHFngjk-xpvr6vSU5mWwCFfNNDjvRNYVHqutzHHuXKEZx7vlCehx3uIMxtr3CuN7k4UCfNgih3Xb0LEXaN4Sh-7HsPWuHbOA7TeYtyMlGRN_uay7hNlDJkDs46odS2yMdAf6nuXFx6ueHH0GcY7SIOg-B_CsrsHhYY0X_1_km5xVEP0Jnrb8iEoqxHGWdEv4MCTfQoQhy-EJPiHgcoR_AFW8QCLhuY9SuLmbjHuGDoX10jikE9mFoYqtReIQIjC5qkNke0xwTmPQLTDfU4IibvASoQuweFpNCPbavHsYVwj0B6D48BAXFPUBBhsx5j0FKPgHVZjxPKSI8CgMGftimEFoFZD3OG7R6zMDWhu5iwHrLg3x7XdWav6DiHhswe6GXZPW4KrZhpm6QHgCt4D3ET-oyEDX1mNrUoPLEZ6iFQ1-zNDGabFryFrkJbNhKaEls9ghnoKLDWiyIQjEEBEGNSBiSIQqeoENAsAvNz6IgN3ccWI7xn62GBXmKqTU6sHqYQAWAwqNDtgQ0omAoU1wNBqTYdxeDHWm8tUHcA7EXgCQWLsp4AjSjC2mIIzEqh_2B5wF9QpRhnRGwwiUAmqEgwjCFFuieUIxBOgBwE2oiCaUFn_SfTlMKEocqdSBALjKb7A3ZgwAfGxiYItoEHBomCPrpTuX8gxIQFpuTwGTqvTWxq7Ylpg24cwh0wCwqaWFQ7BwOvQJAzgDihrQeSOfgtQ6AstrANdiPgjjDIlim6RgazorIDiHG5sadnAc4nyC9vvgyu8g-_jLJskr4-Onp8fDycyGwU--oH1H2Hbjw-mgATTK2D9D4IwwMt9qgP_xzfXR7LCKHk_ccvXxMyPnuSH30l-I8Plx-__R1_FTcj6-wiwv0zehl40fn44YIQZ_J1evDp4vNv6o6wb6D69e3XZPKdfw3eXf3Dmp5O8emdfDz4aeIhO58cm-a3afY9HAwOPvnUy772gxsMQz60rr89Pv6MH9yH8Jtk_dHJg3UZX52pgXP-8-SEP_AfAKODDxG69PCNes9HH0LWpwpSix8_Y_rd-TZUXiwHP9LTT8P4_sQ8n7jn4effhjb70B9G5r0dDL2Tg8sP48eLwfHVu6E9iA7O_86HfoA-fv44Iehp4qgP1Onffvgy6Jv_CO4f3j_eXj-8P38v5eSj8-3h51m_734--_B06_YH37n59TH7Pn76Fdp1R_TefsjEycGV8tj7g3wgjmYj8abYLU2Pim-6qkgCwI8iqhxpSMthXmOe_vARstFUv9MPZ1_eDPVQpRA-kuxcjdPjJ4jxZzporUT9EjQ19VBlRViq8rztZslU6XDjy2mon3-eyjDQAcCsPr0qtp6jOBnP13tBFGC4rlcLibdPEw2D_aur4k0_zEphurkZoBfAXXbICLwZmJcP8w3l_qLXJzJ0gTcKIGQEkRtOPXUZlTVS-TiUju6b3kvX65reTKc0jEHj8xBCf9pdlVvwFnPjDfSvZAZqR4Z4JrnQGtHu0ms0b0FL0tPtLJRjKALSUdf4Xqisn54W5usad2qsv1-rTHqQLhxdQoGRHmmrHOWdgU_PJeQjsKJSHuXLzkXAUETDnNfImY821Eis06gc1svITZRMlac3ovXCzDBLgnttz231nLvJWpGbKz4XZcxkGTNh-zZE3_Ogx3HozcqJF-vfJGlztXMJhhZhlDL2rW0htn8Hc0anf_BSF58vVrlV3OZ6XzxN4mykknEgS43fFPPn34kfx3Gc1cEHWgceuU3LAqPSE7TFaBxDaXjfT5L48bm4XNILwaYqd-tRyJmN572CyBPqQz379sWzPJsvFmB38MFaMVtgbM5uFPybw4v9UpzdGWbWSdwJZf9NsFMseN_GxRLMDspfQWGukhUxm2tc9MPIYqMUsSXaoBdizW9KTuLIQLtlK2t97tJVUH1n9fbNqXTRnquxAZisSqsz81zowkANvgZmz6X9iSJ_JinrhrSyjfApGobyKYjuzpL4p4reRWr8tMswbyp6CxQFzz4Oss3NwDc0wzmAMzjVrzFkVbvoXC9ncwVLfqMU8B9M0LwnY7YfvQturvW7fpLp1DV5OpZhqBdrX5yANUvaYoLNZBhzIX-C5n8paNL_GtAs95uKMnkHXevlbJFiFfxlvf6fQ4sLFY5V9m8GCogUaeZosH_xctAzCVvMlznv3pyn77rTRLpP_SgvJ9L-NHk5-N0kyg2Kw1Bb67bg3ZtuFzJLXrK6UWqzwr7FakbBeLTzMsIGNeZ4HEeD2L0_j0M13u9awjPhWxuikABIEEfKeN7DGYHycoqC4BlelB-HKstXz4v1cf0xt1dOcRlNplne7tvuOEjdr87U9_U9JWgOUEjfwTr5dH3cvy13eKv0eX--RtOxo2_hFH8vDpIMVX5KzUinTlp8fNv9NVCPeS9OwXhBmGrtw1BOUjXf28xXv8tuh8DXIi2nugjmd5rqZS0ImiW9-6EgcYjufpOJmwSqsV_z92s6VTSot9f1jniTtNO4TbsitJ_o3eh8q73BUvkRmGYpOTI1MeuXLbyX44kMG1su366xRKb3P8CjAz9w9ZGC9iHXuyUFVYtdSthtGe_yjGCzjPycTpOA4mUz82wFpZ67ujhSb9X8oE-jVYu3zeynypWNuhcvm5nnpzfi6EKf5KqXMqdqkfSxPEMEk6YfhPpAX-PIvgvVnKRZ4Ce9iF2eTmiSdA0ANSNpnThJ4Eyz5mlcoWixVX7cp8FC-l0za3H6vkEH_a4FiZZO9TQYtErTLKo4tt0IZG2sxeHORvuVR0VbhqCsPBvMX7xtMcLsXHiD_uXrlklS7K08xIFXnBZumC4rZG2AEesybVcx-cnn3cWsnoneXeJZKNP7xvEu3zazf4GqG9KbGilFjrORED2pdpOg59ZuEgaricSCd9CeQuT4BTmiAkO3AticpmV8s2l0CkEuaxnbDUXl3aqfCAvVtpJVQHmtpltLLBy0vDjW5sMFyRpBEIsuWrKdzSTND6pfKBnqg69xuJvAZxfkdtIzzlIZeaf6AOeOiurzn9MJCJv17FNduroY0lWpb45mVUR-FFGn9uU5zmGW6KWGn3E8_vvb7gHn_FBf3swflGdmeHlOBnK90wAsnuSeMmtOE_4fcCLTZIeouFTxJi-zyrM7-vPs6M40VcU92mKjKH9cOVWjSYsTNbRYyhhIyHqfXhuD_uBd5wxSa6PIZJPOr0Goij1c4_MUWkk6X6Lg-xQITl8b3HEUdaRpKZdhz2LCdhXykOv4LnOE5bu-6ylmM1sKbhLH8nxuC4alPqxHTJN28o7k6oMwq5N_Gqjvrw3GOtCDMHDBd18bqKMzLwOxvxixb8yu_pQrX4ZMjXc_skQa-R2M8mmn73mpgYjem8NmdaVMPymXCDuvbFN_HRfuaGi07bzC-C_6YSGtCOsaJzoU_UUvJZVbnIsrUUZeb3SQVX2t4cqY4ZUB_-ntAKiSOv90E-lnyvsXNqv0kBBqCFlo9Rhko7KfRlGk5oUslKH5T-IwEv0n1M6HrFsejipL3UYKvJaCrKWgaynYWgq-lmJ25zFfRljx2GWHve6fX550fgs8ZZyDFCgTjDyeVb3U4gpT11bMoraNLIsRn3pKIiypy5HrIdu3fAe72HGVkhQJi5mur4jj-oLYEi95KcWd8qzaa8OsOCy2qg5rdl4hSztRCXRGeblkowGqUxvXzNPTaXpv3D4GkeqAeJgfxyrMlhQnilgIUc8npsU8xPQRZVdx4QsGqisGGlvEIcpFFHvYwdwVjmsS5CjiW9Jvnp7cXJ6erxCvzqMiGTeKbLzzyiLPJxmixSTT87Iyx14RkT-f39qqvhwoX69-pAZ_hgHa1PpiYzljVFKZaK_0zAQCfZ_NAGxfbfSPNrHq_Ics-8-Xj5efv7zrfJDJNDB03dN5L2EK9cfTUC27ELIc5LkeF64nPI48QrAPKG9ixwZ3koJpH3OwkqYtlcAMUN9xuAlTCZyKiiUXIqyK8CsehJEeo1P1I1O6j_CA6QcQN1V0l43AY8wcq2dLHcZA6tWpDjHbUXnp9eyiXfmykbeMIX98v6iL_ycySXTQuoBp0umPnWk6Mq6DLEs7ZZEJ44XF7Msx2K68wQ6WA-iD5ETgzhIE5PBYrdBrmBixq47nSosx1_MEM23Pgb-xbyFX2iZ1HJ_Yls8tjgWCvJQTT9k-IlgxiYi0sUK2tex4lrkAbWx2yoPVr43jg_MD-L_ilZStwDgR2ukuowyqy-BOZ2RFZpFDml1gyvO8gvCl2F5YKseeFWgsnHwGjbpW046-gKsK-hUpEM7x05ioJM8onowP-SHJjs6NVrIP3Vxeoxuza01_ZhC5-JoM4jR4gDha2DZPIHSiCeM60RBTdUslAOIAAj1ELEsRgV1mOhYRDnaI7-srNKZkFFuOL13GhDAtYnObe9RHrpBsOaSKhVvajdHV7OjMBqLe5Xg8hQznKXfIfEnU8OMEnDDNU_3UCHyd-HvG40hjWEHiQdQc64PthgxD43ia5EH1caSinHZPHlFnZ14bcm5HUBcdpJmaGP001ZtHneFI3sFDyF_0CdoFyGDBWkDG5rQ6MI5lEmoqQQR1HYE91_eFguAlTCT1jSTJ8kCGhesgKl1bMgThi2CAFxMpny8PjF2PF-fP8IKt4gW2l8MYseuQoIxdENKa3xreVO81GZ-iNJRTSIc6rzh9lkhhtia-ufMjivmKR6XQmC1Al_5yM4LWoVN__KBn1QS9wVRP_ziedC4TPQQr895E1MKObyrm6AlPpe2YWEAKhCnliNs2Q6aNpOuAm1EpLddxmE08qSj3MaRCzak0pcuJUFG36vGidVnuvHIldCk9ytnyJBxq3oao9ApbDUk3bU66f0_uUDfYds1g38ZJPkvOINt1R52TIIPsF9Axflwacw4o7wqfmT5Sjq18ZXHHQth1uI2YiTGAio-guHSQazH4izNhS0e5FnIkcfDqmDdCSv6vsQQr9iqsWMuwUnhJnhDjZ35SvM2BCJm8Mqzl61d283DPqyZ7KYVZbeH37hWixisgV4qhOJSJnEiwxD9iL5AujJ_US7yVsGSZVnNc4tRGVSdSDtTcgjqUuMgRINf2PMld7ElqCduR0nUlJBGOS7AHia7PfYY8vUKmGFfC95bzWLvViaopxPM8NneWlQBk05bo9ArZNXU7q4WQRbFdZLRLCfPv3VmQWZcyDt1RHMrkf-QkTv83NfICep46gssYFzJRVVeA6KEYsTxCkaWw71APsMXBtk-oZxOIL8SxqA8JCzeF8G3LVY4rAXAc01MUiF-0DoVgrif6pyPp44LFIlRePEDy17GbU4dZ8lGs_O9pfGptW7ug149k-JRmM9uCpkn2c9m6J4DhsU6MqyaW2MYuVwhTIWBCmYwIblP4oiwhqQP2tzUym5QgSyDq6HcuVIyQvHNKLLIM2ajexGRlbmFSteNszbfD0MLyhRl114cjXZDBJHuKp9sYeWMXrzVy3fLhcRKM0_wo1XASJDLs3D7GB8XZqtXsBxEfW8xSyDNtzqjvQfxjHhYe5p4UkksL4p_LTeQj5lLfcjg84phIkzMgtJfNyluyn1eIr1mrK5cadTWzOLIA-GY1pUO4PY3iNRsA5I-RDr0sO0akpUDWKxSLefjJSbOk-MFrS4uGjou5RI7vSgJxzaYI3MRzKfYcKJVdm1lIUp8Iy_GQII4iXK_KW1RQRSCvMpfdpQHoVovkiyDyVJIakZKJ8zTbbim2UTBdTMUVnFuumaM403NTnxMuFmMaTMTqls1GwRiSM9e4iJOoMwzCe6XX0GJvkTpwgZozB70ntmRFlyHfdpTn-2BLsAsVFgb4kgTKDQggSthcSQewzJLMsaUpqPBdzGwLc2Kurt7T5hWw84NBi10t0ZYi1O2fEVK7flVZjxe_m_X4ldHXP4mgeW91-YcUhOBLAfDcOF8GV3rvtzggOvsxA_rVZXU2NzEs7vrNWOx1LPlCitF3ntJU33TPB9tgCwHmWgEqzFb58Rb8BUKQBQcyN1XTGD7KyWrbdIu254J20L-Ugfcgo14hvgeF-B4UepGMOoXQNt5V555kDxbB-9JmG38rLorsZI-a2cZ37gHeWkJlurKXtUn2NQBsD96A9jA_0B76Qbd0hQU53glj8K5Tku7BgNtHjcrQI7KTAciuBsA7TuLtOjC_nbqLExbpxS4S6mc221kC31fsRPsCme19s9L0CxGS7jyWbD9OtY3yxbmQBQN5KRSSPSAK2XFS0h350X7s_-JQubXTVhRGm3FUfAOhTTtX4aEvsSvbFa33NDB0X_Cyt9yavBQ5t-DTS35LY4hfhk54P4Owt2Cxj6qPvkynBZfYyPoV_7VeZvw95Rts5xi1e5Tj26LBgp6_CD2eN1is_cwuCudH7fN7wnHkB3fPLv6u_lLFxV3h2S9XfH5ZuPhtiwvK4rcuzn_mvKtGceippKRW-rxX-ePdZxeLreov1qmjr_4OwRkTW88yuz48v8C8ppmZx8_oEWE2bmRJg7sg_OTnvz5gmMn85_TPOdsbKn_fRxyG-bpd1RLtjPP7c3MGwnE7y_LvGKl00eR8dt2jdIY3R6u_i_P_AZLFMkk=
Screenshots

Screenshot 2023-11-19 124109
Screenshot 2023-11-19 124458

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the supplied build code, select Ice Shot, and inspect the Precise Technique calculation entry point. Compare unbuffed, in-combat, and effective DPS with the reported in-game values, focusing on how the keystone's life and accuracy condition is evaluated. Done means Precise Technique increases the Path of Building values consistently with the game.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.